From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
a.zummo@towertech.it, rtc-linux@googlegroups.com, wim@iguana.be,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver
Date: Mon, 15 Dec 2014 14:38:50 +0000 [thread overview]
Message-ID: <20141215143850.GD13885@x1> (raw)
In-Reply-To: <5276146.VV460E9Y1P@wuerfel>
On Mon, 15 Dec 2014, Arnd Bergmann wrote:
> On Monday 15 December 2014 13:50:52 Lee Jones wrote:
> > > >
> > >
> > > I don't think it's necessary to have the MFD node if only one of the
> > > two modes can be used based on a DT property. It should be enough
> > > to have both the rtc and the wdt driver list the same compatible
> > > string and check the property in the probe function to decide if
> > > they want to drive the device or not:
> >
> > I tried that and it didn't work. Only one driver probed.
> >
> >
>
> Strange, the code in really_probe() and the comment in device_attach()
> suggest that this is not the intentional behavior. What error
> code did you return? If it's -ENODEV or -ENXIO, it should keep
> trying the other drivers, otherwise it will give up.
Oh I see. So if I return -ENODEV it will keep trying to bind with
other drivers. I'll try that and report back.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] mfd: Add ST's Low Power Controller driver
Date: Mon, 15 Dec 2014 14:38:50 +0000 [thread overview]
Message-ID: <20141215143850.GD13885@x1> (raw)
In-Reply-To: <5276146.VV460E9Y1P@wuerfel>
On Mon, 15 Dec 2014, Arnd Bergmann wrote:
> On Monday 15 December 2014 13:50:52 Lee Jones wrote:
> > > >
> > >
> > > I don't think it's necessary to have the MFD node if only one of the
> > > two modes can be used based on a DT property. It should be enough
> > > to have both the rtc and the wdt driver list the same compatible
> > > string and check the property in the probe function to decide if
> > > they want to drive the device or not:
> >
> > I tried that and it didn't work. Only one driver probed.
> >
> >
>
> Strange, the code in really_probe() and the comment in device_attach()
> suggest that this is not the intentional behavior. What error
> code did you return? If it's -ENODEV or -ENXIO, it should keep
> trying the other drivers, otherwise it will give up.
Oh I see. So if I return -ENODEV it will keep trying to bind with
other drivers. I'll try that and report back.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver
Date: Mon, 15 Dec 2014 14:38:50 +0000 [thread overview]
Message-ID: <20141215143850.GD13885@x1> (raw)
In-Reply-To: <5276146.VV460E9Y1P@wuerfel>
On Mon, 15 Dec 2014, Arnd Bergmann wrote:
> On Monday 15 December 2014 13:50:52 Lee Jones wrote:
> > > >
> > >
> > > I don't think it's necessary to have the MFD node if only one of the
> > > two modes can be used based on a DT property. It should be enough
> > > to have both the rtc and the wdt driver list the same compatible
> > > string and check the property in the probe function to decide if
> > > they want to drive the device or not:
> >
> > I tried that and it didn't work. Only one driver probed.
> >
> >
>
> Strange, the code in really_probe() and the comment in device_attach()
> suggest that this is not the intentional behavior. What error
> code did you return? If it's -ENODEV or -ENXIO, it should keep
> trying the other drivers, otherwise it will give up.
Oh I see. So if I return -ENODEV it will keep trying to bind with
other drivers. I'll try that and report back.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
a.zummo@towertech.it, rtc-linux@googlegroups.com, wim@iguana.be,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/8] mfd: Add ST's Low Power Controller driver
Date: Mon, 15 Dec 2014 14:38:50 +0000 [thread overview]
Message-ID: <20141215143850.GD13885@x1> (raw)
In-Reply-To: <5276146.VV460E9Y1P@wuerfel>
On Mon, 15 Dec 2014, Arnd Bergmann wrote:
> On Monday 15 December 2014 13:50:52 Lee Jones wrote:
> > > >
> > >
> > > I don't think it's necessary to have the MFD node if only one of the
> > > two modes can be used based on a DT property. It should be enough
> > > to have both the rtc and the wdt driver list the same compatible
> > > string and check the property in the probe function to decide if
> > > they want to drive the device or not:
> >
> > I tried that and it didn't work. Only one driver probed.
> >
> >
>
> Strange, the code in really_probe() and the comment in device_attach()
> suggest that this is not the intentional behavior. What error
> code did you return? If it's -ENODEV or -ENXIO, it should keep
> trying the other drivers, otherwise it will give up.
Oh I see. So if I return -ENODEV it will keep trying to bind with
other drivers. I'll try that and report back.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-12-15 14:38 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 11:25 [PATCH 0/8] mfd: watchdog: rtc: New driver for ST's LPC IP Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` [PATCH 1/8] ARM: multi_v7_defconfig: Enable support for ST's LPC Watchdog Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` [PATCH 2/8] ARM: multi_v7_defconfig: Enable support for ST's LPC RTC Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` [PATCH 3/8] mfd: bindings: Provide ST bindings for ST's LPC device Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` [PATCH 4/8] mfd: dt-bindings: Provide human readable defines for LPC mode choosing Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` [PATCH 5/8] mfd: Add ST's Low Power Controller driver Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 13:38 ` Arnd Bergmann
2014-12-15 13:38 ` Arnd Bergmann
2014-12-15 13:38 ` Arnd Bergmann
2014-12-15 13:50 ` Lee Jones
2014-12-15 13:50 ` Lee Jones
2014-12-15 13:50 ` Lee Jones
2014-12-15 14:06 ` Arnd Bergmann
2014-12-15 14:06 ` Arnd Bergmann
2014-12-15 14:06 ` Arnd Bergmann
2014-12-15 14:38 ` Lee Jones [this message]
2014-12-15 14:38 ` Lee Jones
2014-12-15 14:38 ` Lee Jones
2014-12-15 14:38 ` Lee Jones
2014-12-15 11:25 ` [PATCH 6/8] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 12:29 ` David Paris
2014-12-15 12:29 ` David Paris
2014-12-15 12:29 ` David Paris
2014-12-15 12:52 ` David Paris
2014-12-15 12:52 ` David Paris
2014-12-15 12:52 ` David Paris
2014-12-15 14:15 ` Guenter Roeck
2014-12-15 14:15 ` Guenter Roeck
2014-12-15 14:15 ` Guenter Roeck
2014-12-15 16:23 ` Guenter Roeck
2014-12-15 16:23 ` Guenter Roeck
2014-12-15 11:25 ` [PATCH 7/8] rtc: st: add new driver for ST's LPC RTC Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 12:28 ` [STLinux Kernel] " David Paris
2014-12-15 12:28 ` David Paris
2014-12-15 12:28 ` David Paris
2014-12-15 14:17 ` Guenter Roeck
2014-12-15 14:17 ` Guenter Roeck
2014-12-15 14:17 ` Guenter Roeck
2014-12-15 11:25 ` [PATCH 8/8] ARM: STi: DT: STiH407: Add Device Tree node for the LPC Lee Jones
2014-12-15 11:25 ` Lee Jones
2014-12-15 11:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215143850.GD13885@x1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.