re: drm/dsi: Add message to packet translator

re: drm/dsi: Add message to packet translator

[Dan Carpenter]

Hello Thierry Reding,

This is a semi-automatic email about new static checker warnings.

The patch a52879e8d7cb: "drm/dsi: Add message to packet translator" 
from Oct 16, 2014, leads to the following Smatch complaint:

drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet()
	 warn: variable dereferenced before check 'msg' (see line 326)

drivers/gpu/drm/drm_mipi_dsi.c
   325	{
   326		const u8 *tx = msg->tx_buf;
                               ^^^^^^^^^^^
Dereference.

   327	
   328		if (!packet || !msg)
                               ^^^^
Check.

   329			return -EINVAL;
   330	

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drm/dsi: Add message to packet translator

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]

On Wed, Dec 17, 2014 at 02:53:05AM +0300, Dan Carpenter wrote:
> Hello Thierry Reding,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch a52879e8d7cb: "drm/dsi: Add message to packet translator" 
> from Oct 16, 2014, leads to the following Smatch complaint:
> 
> drivers/gpu/drm/drm_mipi_dsi.c:328 mipi_dsi_create_packet()
> 	 warn: variable dereferenced before check 'msg' (see line 326)
> 
> drivers/gpu/drm/drm_mipi_dsi.c
>    325	{
>    326		const u8 *tx = msg->tx_buf;
>                                ^^^^^^^^^^^
> Dereference.
> 
>    327	
>    328		if (!packet || !msg)
>                                ^^^^
> Check.
> 
>    329			return -EINVAL;
>    330	
> 
> regards,
> dan carpenter

I've had a patch in my tree for almost two weeks now, I wonder why this
is still there...

Ah, forgot to push it of course. Done now.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel