All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Magnus Damm <magnus.damm@gmail.com>,
	jslaby@suse.cz, linux-serial@vger.kernel.org
Subject: [PATCH 02/05] serial: sh-sci: Fix default RTS handling
Date: Wed, 17 Dec 2014 12:52:55 +0000	[thread overview]
Message-ID: <20141217125255.14480.64174.sendpatchset@w520> (raw)
In-Reply-To: <20141217125236.14480.78833.sendpatchset@w520>

From: Magnus Damm <damm+renesas@opensource.se>

Fix the default SCIF handling in case CTS/RTS is available
on the target board but disabled by user space. Without
this patch the RTS output value is not set.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 drivers/tty/serial/sh-sci.c |    5 ++++-
 include/linux/serial_sci.h  |    1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

--- 0004/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c	2014-12-16 14:31:53.000000000 +0900
@@ -522,9 +522,12 @@ static void sci_init_pins_default(struct
 	if (!reg->size || hwflow_enabled)
 		return;
 
+	/* Setup CTS/RTS in the case hardware flow is disabled by user space.
+	 * The CTS signal is setup as input and RTS as output with value 1.
+	 */
 	status = serial_port_in(port, SCSPTR);
 	status &= ~SCSPTR_CTSIO;
-	status |= SCSPTR_RTSIO;
+	status |= SCSPTR_RTSIO | SCSPTR_RTSDT;
 	serial_port_out(port, SCSPTR, status); /* Set RTS = 1 */
 }
 
--- 0001/include/linux/serial_sci.h
+++ work/include/linux/serial_sci.h	2014-12-16 14:25:40.000000000 +0900
@@ -57,6 +57,7 @@
 
 /* SCSPTR (Serial Port Register), optional */
 #define SCSPTR_RTSIO	(1 << 7)	/* Serial Port RTS Pin Input/Output */
+#define SCSPTR_RTSDT	(1 << 6)	/* Serial Port RTS Pin Data */
 #define SCSPTR_CTSIO	(1 << 5)	/* Serial Port CTS Pin Input/Output */
 #define SCSPTR_SPB2IO	(1 << 1)	/* Serial Port Break Input/Output */
 #define SCSPTR_SPB2DT	(1 << 0)	/* Serial Port Break Data */

WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Magnus Damm <magnus.damm@gmail.com>,
	jslaby@suse.cz, linux-serial@vger.kernel.org
Subject: [PATCH 02/05] serial: sh-sci: Fix default RTS handling
Date: Wed, 17 Dec 2014 21:52:55 +0900	[thread overview]
Message-ID: <20141217125255.14480.64174.sendpatchset@w520> (raw)
In-Reply-To: <20141217125236.14480.78833.sendpatchset@w520>

From: Magnus Damm <damm+renesas@opensource.se>

Fix the default SCIF handling in case CTS/RTS is available
on the target board but disabled by user space. Without
this patch the RTS output value is not set.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 drivers/tty/serial/sh-sci.c |    5 ++++-
 include/linux/serial_sci.h  |    1 +
 2 files changed, 5 insertions(+), 1 deletion(-)

--- 0004/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c	2014-12-16 14:31:53.000000000 +0900
@@ -522,9 +522,12 @@ static void sci_init_pins_default(struct
 	if (!reg->size || hwflow_enabled)
 		return;
 
+	/* Setup CTS/RTS in the case hardware flow is disabled by user space.
+	 * The CTS signal is setup as input and RTS as output with value 1.
+	 */
 	status = serial_port_in(port, SCSPTR);
 	status &= ~SCSPTR_CTSIO;
-	status |= SCSPTR_RTSIO;
+	status |= SCSPTR_RTSIO | SCSPTR_RTSDT;
 	serial_port_out(port, SCSPTR, status); /* Set RTS = 1 */
 }
 
--- 0001/include/linux/serial_sci.h
+++ work/include/linux/serial_sci.h	2014-12-16 14:25:40.000000000 +0900
@@ -57,6 +57,7 @@
 
 /* SCSPTR (Serial Port Register), optional */
 #define SCSPTR_RTSIO	(1 << 7)	/* Serial Port RTS Pin Input/Output */
+#define SCSPTR_RTSDT	(1 << 6)	/* Serial Port RTS Pin Data */
 #define SCSPTR_CTSIO	(1 << 5)	/* Serial Port CTS Pin Input/Output */
 #define SCSPTR_SPB2IO	(1 << 1)	/* Serial Port Break Input/Output */
 #define SCSPTR_SPB2DT	(1 << 0)	/* Serial Port Break Data */

  parent reply	other threads:[~2014-12-17 12:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 12:52 [PATCH 00/05] serial: sh-sci: Hardware flow control update Magnus Damm
2014-12-17 12:52 ` Magnus Damm
2014-12-17 12:52 ` [PATCH 01/05] serial: sh-sci: Break out default CTS/RTS pin setup Magnus Damm
2014-12-17 12:52   ` Magnus Damm
2015-01-05  8:25   ` Laurent Pinchart
2015-01-05  8:25     ` Laurent Pinchart
2015-03-19  2:16     ` Magnus Damm
2015-03-19  2:16       ` Magnus Damm
2014-12-17 12:52 ` Magnus Damm [this message]
2014-12-17 12:52   ` [PATCH 02/05] serial: sh-sci: Fix default RTS handling Magnus Damm
2014-12-17 12:53 ` [PATCH 03/05] serial: sh-sci: Expose default CTS pin Magnus Damm
2014-12-17 12:53   ` Magnus Damm
2014-12-17 12:53 ` [PATCH 04/05] serial: sh-sci: Add SCIFA/SCIFB CTS/RTS pin setup Magnus Damm
2014-12-17 12:53   ` Magnus Damm
2015-01-05  7:46   ` Laurent Pinchart
2015-01-05  7:46     ` Laurent Pinchart
2015-03-19  2:20     ` Magnus Damm
2015-03-19  2:20       ` Magnus Damm
2014-12-17 12:53 ` [PATCH 05/05] serial: sh-sci: Expose SCIFA/SCIFB CTS pin Magnus Damm
2014-12-17 12:53   ` Magnus Damm
2015-01-05  7:53   ` Laurent Pinchart
2015-01-05  7:53     ` Laurent Pinchart
2015-03-19  2:18     ` Magnus Damm
2015-03-19  2:18       ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217125255.14480.64174.sendpatchset@w520 \
    --to=magnus.damm@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.