From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Magnus Damm <magnus.damm@gmail.com>,
jslaby@suse.cz, linux-serial@vger.kernel.org
Subject: [PATCH 03/05] serial: sh-sci: Expose default CTS pin
Date: Wed, 17 Dec 2014 12:53:05 +0000 [thread overview]
Message-ID: <20141217125305.14480.3038.sendpatchset@w520> (raw)
In-Reply-To: <20141217125236.14480.78833.sendpatchset@w520>
From: Magnus Damm <damm+renesas@opensource.se>
Expose the CTS pin to the ->get_mctrl() callback for the
default case. Without this patch the serial core can not
retrieve the CTS pin state from the SCIF driver.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
drivers/tty/serial/sh-sci.c | 20 +++++++++++++++++++-
include/linux/serial_sci.h | 1 +
2 files changed, 20 insertions(+), 1 deletion(-)
--- 0021/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c 2014-12-17 18:44:31.000000000 +0900
@@ -509,6 +509,17 @@ static void sci_poll_put_char(struct uar
}
#endif /* CONFIG_CONSOLE_POLL || CONFIG_SERIAL_SH_SCI_CONSOLE */
+static bool sci_cts_asserted_default(struct uart_port *port)
+{
+ struct sci_port *s = to_sci_port(port);
+ struct plat_sci_reg *reg = sci_regmap[s->cfg->regtype] + SCSPTR;
+
+ if (reg->size)
+ return !(serial_port_in(port, SCSPTR) & SCSPTR_CTSDT);
+
+ return false;
+}
+
static void sci_init_pins_default(struct uart_port *port, bool hwflow_enabled)
{
struct sci_port *s = to_sci_port(port);
@@ -1227,11 +1238,18 @@ static void sci_set_mctrl(struct uart_po
static unsigned int sci_get_mctrl(struct uart_port *port)
{
+ struct sci_port *s = to_sci_port(port);
+ bool cts_asserted = false;
+
/*
* CTS/RTS is handled in hardware when supported, while nothing
* else is wired up. Keep it simple and simply assert DSR/CAR.
*/
- return TIOCM_DSR | TIOCM_CAR;
+
+ if (s->cfg->capabilities & SCIx_HAVE_RTSCTS)
+ cts_asserted = sci_cts_asserted_default(port);
+
+ return TIOCM_DSR | TIOCM_CAR | (cts_asserted ? TIOCM_CTS : 0);
}
#ifdef CONFIG_SERIAL_SH_SCI_DMA
--- 0021/include/linux/serial_sci.h
+++ work/include/linux/serial_sci.h 2014-12-17 17:52:55.000000000 +0900
@@ -59,6 +59,7 @@
#define SCSPTR_RTSIO (1 << 7) /* Serial Port RTS Pin Input/Output */
#define SCSPTR_RTSDT (1 << 6) /* Serial Port RTS Pin Data */
#define SCSPTR_CTSIO (1 << 5) /* Serial Port CTS Pin Input/Output */
+#define SCSPTR_CTSDT (1 << 4) /* Serial Port CTS Pin Data */
#define SCSPTR_SPB2IO (1 << 1) /* Serial Port Break Input/Output */
#define SCSPTR_SPB2DT (1 << 0) /* Serial Port Break Data */
WARNING: multiple messages have this Message-ID (diff)
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-sh@vger.kernel.org
Cc: gregkh@linuxfoundation.org, Magnus Damm <magnus.damm@gmail.com>,
jslaby@suse.cz, linux-serial@vger.kernel.org
Subject: [PATCH 03/05] serial: sh-sci: Expose default CTS pin
Date: Wed, 17 Dec 2014 21:53:05 +0900 [thread overview]
Message-ID: <20141217125305.14480.3038.sendpatchset@w520> (raw)
In-Reply-To: <20141217125236.14480.78833.sendpatchset@w520>
From: Magnus Damm <damm+renesas@opensource.se>
Expose the CTS pin to the ->get_mctrl() callback for the
default case. Without this patch the serial core can not
retrieve the CTS pin state from the SCIF driver.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
drivers/tty/serial/sh-sci.c | 20 +++++++++++++++++++-
include/linux/serial_sci.h | 1 +
2 files changed, 20 insertions(+), 1 deletion(-)
--- 0021/drivers/tty/serial/sh-sci.c
+++ work/drivers/tty/serial/sh-sci.c 2014-12-17 18:44:31.000000000 +0900
@@ -509,6 +509,17 @@ static void sci_poll_put_char(struct uar
}
#endif /* CONFIG_CONSOLE_POLL || CONFIG_SERIAL_SH_SCI_CONSOLE */
+static bool sci_cts_asserted_default(struct uart_port *port)
+{
+ struct sci_port *s = to_sci_port(port);
+ struct plat_sci_reg *reg = sci_regmap[s->cfg->regtype] + SCSPTR;
+
+ if (reg->size)
+ return !(serial_port_in(port, SCSPTR) & SCSPTR_CTSDT);
+
+ return false;
+}
+
static void sci_init_pins_default(struct uart_port *port, bool hwflow_enabled)
{
struct sci_port *s = to_sci_port(port);
@@ -1227,11 +1238,18 @@ static void sci_set_mctrl(struct uart_po
static unsigned int sci_get_mctrl(struct uart_port *port)
{
+ struct sci_port *s = to_sci_port(port);
+ bool cts_asserted = false;
+
/*
* CTS/RTS is handled in hardware when supported, while nothing
* else is wired up. Keep it simple and simply assert DSR/CAR.
*/
- return TIOCM_DSR | TIOCM_CAR;
+
+ if (s->cfg->capabilities & SCIx_HAVE_RTSCTS)
+ cts_asserted = sci_cts_asserted_default(port);
+
+ return TIOCM_DSR | TIOCM_CAR | (cts_asserted ? TIOCM_CTS : 0);
}
#ifdef CONFIG_SERIAL_SH_SCI_DMA
--- 0021/include/linux/serial_sci.h
+++ work/include/linux/serial_sci.h 2014-12-17 17:52:55.000000000 +0900
@@ -59,6 +59,7 @@
#define SCSPTR_RTSIO (1 << 7) /* Serial Port RTS Pin Input/Output */
#define SCSPTR_RTSDT (1 << 6) /* Serial Port RTS Pin Data */
#define SCSPTR_CTSIO (1 << 5) /* Serial Port CTS Pin Input/Output */
+#define SCSPTR_CTSDT (1 << 4) /* Serial Port CTS Pin Data */
#define SCSPTR_SPB2IO (1 << 1) /* Serial Port Break Input/Output */
#define SCSPTR_SPB2DT (1 << 0) /* Serial Port Break Data */
next prev parent reply other threads:[~2014-12-17 12:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 12:52 [PATCH 00/05] serial: sh-sci: Hardware flow control update Magnus Damm
2014-12-17 12:52 ` Magnus Damm
2014-12-17 12:52 ` [PATCH 01/05] serial: sh-sci: Break out default CTS/RTS pin setup Magnus Damm
2014-12-17 12:52 ` Magnus Damm
2015-01-05 8:25 ` Laurent Pinchart
2015-01-05 8:25 ` Laurent Pinchart
2015-03-19 2:16 ` Magnus Damm
2015-03-19 2:16 ` Magnus Damm
2014-12-17 12:52 ` [PATCH 02/05] serial: sh-sci: Fix default RTS handling Magnus Damm
2014-12-17 12:52 ` Magnus Damm
2014-12-17 12:53 ` Magnus Damm [this message]
2014-12-17 12:53 ` [PATCH 03/05] serial: sh-sci: Expose default CTS pin Magnus Damm
2014-12-17 12:53 ` [PATCH 04/05] serial: sh-sci: Add SCIFA/SCIFB CTS/RTS pin setup Magnus Damm
2014-12-17 12:53 ` Magnus Damm
2015-01-05 7:46 ` Laurent Pinchart
2015-01-05 7:46 ` Laurent Pinchart
2015-03-19 2:20 ` Magnus Damm
2015-03-19 2:20 ` Magnus Damm
2014-12-17 12:53 ` [PATCH 05/05] serial: sh-sci: Expose SCIFA/SCIFB CTS pin Magnus Damm
2014-12-17 12:53 ` Magnus Damm
2015-01-05 7:53 ` Laurent Pinchart
2015-01-05 7:53 ` Laurent Pinchart
2015-03-19 2:18 ` Magnus Damm
2015-03-19 2:18 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217125305.14480.3038.sendpatchset@w520 \
--to=magnus.damm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.