From: Al Viro <viro@ZenIV.linux.org.uk>
To: Omar Sandoval <osandov@osandov.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lei <ming.lei@canonical.com>
Subject: Re: [PATCH v2 2/5] direct-io: don't dirty ITER_BVEC pages on read
Date: Sat, 20 Dec 2014 06:01:30 +0000 [thread overview]
Message-ID: <20141220060130.GA22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <f9b69250ba0598807d96857e9b736d57e6841ba3.1419044605.git.osandov@osandov.com>
On Fri, Dec 19, 2014 at 07:18:26PM -0800, Omar Sandoval wrote:
> Reads through the iov_iter infrastructure for kernel pages shouldn't be
> dirtied by the direct I/O code.
>
> This is based on Dave Kleikamp's and Ming Lei's previously posted
> patches.
Umm...
> + dio->should_dirty = !iov_iter_is_bvec(iter);
dio->should_dirty = iter_is_iovec(iter);
perhaps?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Omar Sandoval <osandov@osandov.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Ming Lei <ming.lei@canonical.com>
Subject: Re: [PATCH v2 2/5] direct-io: don't dirty ITER_BVEC pages on read
Date: Sat, 20 Dec 2014 06:01:30 +0000 [thread overview]
Message-ID: <20141220060130.GA22149@ZenIV.linux.org.uk> (raw)
In-Reply-To: <f9b69250ba0598807d96857e9b736d57e6841ba3.1419044605.git.osandov@osandov.com>
On Fri, Dec 19, 2014 at 07:18:26PM -0800, Omar Sandoval wrote:
> Reads through the iov_iter infrastructure for kernel pages shouldn't be
> dirtied by the direct I/O code.
>
> This is based on Dave Kleikamp's and Ming Lei's previously posted
> patches.
Umm...
> + dio->should_dirty = !iov_iter_is_bvec(iter);
dio->should_dirty = iter_is_iovec(iter);
perhaps?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-20 6:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 3:18 [PATCH v2 0/5] clean up and generalize swap-over-NFS Omar Sandoval
2014-12-20 3:18 ` Omar Sandoval
2014-12-20 3:18 ` [PATCH v2 1/5] iov_iter: add ITER_BVEC helpers Omar Sandoval
2014-12-20 3:18 ` Omar Sandoval
2014-12-20 3:18 ` [PATCH v2 2/5] direct-io: don't dirty ITER_BVEC pages on read Omar Sandoval
2014-12-20 3:18 ` Omar Sandoval
2014-12-20 6:01 ` Al Viro [this message]
2014-12-20 6:01 ` Al Viro
2014-12-22 7:12 ` Omar Sandoval
2014-12-22 7:12 ` Omar Sandoval
2014-12-20 3:18 ` [PATCH v2 3/5] nfs: don't dirty ITER_BVEC pages read through direct I/O Omar Sandoval
2014-12-20 3:18 ` Omar Sandoval
2015-01-05 14:41 ` Anna Schumaker
2015-01-05 14:41 ` Anna Schumaker
2015-01-05 14:41 ` Anna Schumaker
2015-01-08 9:25 ` Omar Sandoval
2015-01-08 9:25 ` Omar Sandoval
2015-01-08 9:25 ` Omar Sandoval
2014-12-20 3:18 ` [PATCH v2 4/5] swapfile: use ->read_iter and ->write_iter Omar Sandoval
2014-12-20 3:18 ` Omar Sandoval
2014-12-20 6:13 ` Al Viro
2014-12-20 6:13 ` Al Viro
2014-12-22 7:32 ` Omar Sandoval
2014-12-22 7:32 ` Omar Sandoval
2014-12-22 7:32 ` Omar Sandoval
2014-12-20 3:18 ` [PATCH v2 5/5] vfs: update swap_{,de}activate documentation Omar Sandoval
2014-12-20 3:18 ` Omar Sandoval
2015-01-14 3:18 ` [PATCH v2 0/5] clean up and generalize swap-over-NFS Omar Sandoval
2015-01-14 3:18 ` Omar Sandoval
2015-01-14 3:18 ` Omar Sandoval
2015-01-21 19:14 ` Omar Sandoval
2015-01-21 19:14 ` Omar Sandoval
2015-01-21 19:14 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141220060130.GA22149@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=osandov@osandov.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.