* [PATCH] staging: gdm724x: fix coding style issues
@ 2015-01-03 16:03 Ning Zhou
2015-01-04 1:27 ` Konrad Zapalowicz
0 siblings, 1 reply; 3+ messages in thread
From: Ning Zhou @ 2015-01-03 16:03 UTC (permalink / raw)
To: gregkh
Cc: teg, davem, dh.herrmann, gulsah.1004, dilekuzulmez, sjw0410,
monamagarwal123, daniel.dy.ngu, josh, devel, linux-kernel,
Ning Zhou
Signed-off-by: Ning Zhou <zhou.ning.gd@gmail.com>
---
drivers/staging/gdm724x/gdm_lte.c | 3 ++-
drivers/staging/gdm724x/gdm_mux.c | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
index 73eede1..7c4a77b 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging/gdm724x/gdm_lte.c
@@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
icmp6_out.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT;
icmp6_out.icmp6_code = 0;
icmp6_out.icmp6_cksum = 0;
- icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); /* R=0, S=1, O=1 */
+ /* R=0, S=1, O=1 */
+ icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000);
ns = (struct neighbour_solicitation *)
(skb_in->data + mac_header_len +
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a..d1ab996 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
static void do_rx(struct work_struct *work)
{
struct mux_dev *mux_dev =
- container_of(work, struct mux_dev , work_rx.work);
+ container_of(work, struct mux_dev, work_rx.work);
struct mux_rx *r;
struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
unsigned long flags;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: gdm724x: fix coding style issues
2015-01-03 16:03 [PATCH] staging: gdm724x: fix coding style issues Ning Zhou
@ 2015-01-04 1:27 ` Konrad Zapalowicz
2015-01-04 7:17 ` Ning Zhou
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Zapalowicz @ 2015-01-04 1:27 UTC (permalink / raw)
To: Ning Zhou
Cc: gregkh, devel, monamagarwal123, gulsah.1004, daniel.dy.ngu,
dh.herrmann, josh, linux-kernel, teg, sjw0410, dilekuzulmez,
davem
On 01/03, Ning Zhou wrote:
> Signed-off-by: Ning Zhou <zhou.ning.gd@gmail.com>
You need to describe your changes, a vague subject is not enough. Also
keep in mind that one patch shall address one category of stuff and
seems that yours could be separated into two.
thanks,
konrad
> ---
> drivers/staging/gdm724x/gdm_lte.c | 3 ++-
> drivers/staging/gdm724x/gdm_mux.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
> index 73eede1..7c4a77b 100644
> --- a/drivers/staging/gdm724x/gdm_lte.c
> +++ b/drivers/staging/gdm724x/gdm_lte.c
> @@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
> icmp6_out.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT;
> icmp6_out.icmp6_code = 0;
> icmp6_out.icmp6_cksum = 0;
> - icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); /* R=0, S=1, O=1 */
> + /* R=0, S=1, O=1 */
> + icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000);
>
> ns = (struct neighbour_solicitation *)
> (skb_in->data + mac_header_len +
> diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
> index b5b063a..d1ab996 100644
> --- a/drivers/staging/gdm724x/gdm_mux.c
> +++ b/drivers/staging/gdm724x/gdm_mux.c
> @@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
> static void do_rx(struct work_struct *work)
> {
> struct mux_dev *mux_dev =
> - container_of(work, struct mux_dev , work_rx.work);
> + container_of(work, struct mux_dev, work_rx.work);
> struct mux_rx *r;
> struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
> unsigned long flags;
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: gdm724x: fix coding style issues
2015-01-04 1:27 ` Konrad Zapalowicz
@ 2015-01-04 7:17 ` Ning Zhou
0 siblings, 0 replies; 3+ messages in thread
From: Ning Zhou @ 2015-01-04 7:17 UTC (permalink / raw)
To: Konrad Zapalowicz
Cc: gregkh, devel, monamagarwal123, gulsah.1004, daniel.dy.ngu,
dh.herrmann, josh, linux-kernel, teg, sjw0410, dilekuzulmez,
davem
OK, then this one is abandoned. I will send two patches instead.
/Ning
On 2015-01-04 02:27, Konrad Zapalowicz wrote:
> On 01/03, Ning Zhou wrote:
>> Signed-off-by: Ning Zhou <zhou.ning.gd@gmail.com>
>
> You need to describe your changes, a vague subject is not enough. Also
> keep in mind that one patch shall address one category of stuff and
> seems that yours could be separated into two.
>
> thanks,
> konrad
>
>> ---
>> drivers/staging/gdm724x/gdm_lte.c | 3 ++-
>> drivers/staging/gdm724x/gdm_mux.c | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
>> index 73eede1..7c4a77b 100644
>> --- a/drivers/staging/gdm724x/gdm_lte.c
>> +++ b/drivers/staging/gdm724x/gdm_lte.c
>> @@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type)
>> icmp6_out.icmp6_type = NDISC_NEIGHBOUR_ADVERTISEMENT;
>> icmp6_out.icmp6_code = 0;
>> icmp6_out.icmp6_cksum = 0;
>> - icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000); /* R=0, S=1, O=1 */
>> + /* R=0, S=1, O=1 */
>> + icmp6_out.icmp6_dataun.un_data32[0] = htonl(0x60000000);
>>
>> ns = (struct neighbour_solicitation *)
>> (skb_in->data + mac_header_len +
>> diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
>> index b5b063a..d1ab996 100644
>> --- a/drivers/staging/gdm724x/gdm_mux.c
>> +++ b/drivers/staging/gdm724x/gdm_mux.c
>> @@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
>> static void do_rx(struct work_struct *work)
>> {
>> struct mux_dev *mux_dev =
>> - container_of(work, struct mux_dev , work_rx.work);
>> + container_of(work, struct mux_dev, work_rx.work);
>> struct mux_rx *r;
>> struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
>> unsigned long flags;
>> --
>> 1.9.1
>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-04 7:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-03 16:03 [PATCH] staging: gdm724x: fix coding style issues Ning Zhou
2015-01-04 1:27 ` Konrad Zapalowicz
2015-01-04 7:17 ` Ning Zhou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.