From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
Yingjoe Chen
<yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC 02/11] i2c: add quirk checks to core
Date: Mon, 12 Jan 2015 11:13:49 +0100 [thread overview]
Message-ID: <20150112101349.GA995@katana> (raw)
In-Reply-To: <20150112095847.GD3625@ldesroches-Latitude-E6320>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
> I am not sure it will perfectly fit at91 quirks.
I think it does.
> The hardware can handle two messages by using the internal address
> feature. The internal address size is from one byte to three bytes. Then
> the length of the first message is limited to three but we don't have
> this constraint for the second one. If we have 'write then read' no problem
> but if we have two write messages, the second one will cause a quirk
> exceeded error.
Yeah, for this reason I seperated I2C_ADAPTER_QUIRK_COMB_WRITE_FIRST
out. The first message is checked against max_comb_write_len which is
set to 3 for your driver. The second is checked agains max_write_len
which is unset in your driver and thus can be of any length.
That should work, no?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 02/11] i2c: add quirk checks to core
Date: Mon, 12 Jan 2015 11:13:49 +0100 [thread overview]
Message-ID: <20150112101349.GA995@katana> (raw)
In-Reply-To: <20150112095847.GD3625@ldesroches-Latitude-E6320>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
> I am not sure it will perfectly fit at91 quirks.
I think it does.
> The hardware can handle two messages by using the internal address
> feature. The internal address size is from one byte to three bytes. Then
> the length of the first message is limited to three but we don't have
> this constraint for the second one. If we have 'write then read' no problem
> but if we have two write messages, the second one will cause a quirk
> exceeded error.
Yeah, for this reason I seperated I2C_ADAPTER_QUIRK_COMB_WRITE_FIRST
out. The first message is checked against max_comb_write_len which is
set to 3 for your driver. The second is checked agains max_write_len
which is unset in your driver and thus can be of any length.
That should work, no?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 02/11] i2c: add quirk checks to core
Date: Mon, 12 Jan 2015 11:13:49 +0100 [thread overview]
Message-ID: <20150112101349.GA995@katana> (raw)
In-Reply-To: <20150112095847.GD3625@ldesroches-Latitude-E6320>
> I am not sure it will perfectly fit at91 quirks.
I think it does.
> The hardware can handle two messages by using the internal address
> feature. The internal address size is from one byte to three bytes. Then
> the length of the first message is limited to three but we don't have
> this constraint for the second one. If we have 'write then read' no problem
> but if we have two write messages, the second one will cause a quirk
> exceeded error.
Yeah, for this reason I seperated I2C_ADAPTER_QUIRK_COMB_WRITE_FIRST
out. The first message is checked against max_comb_write_len which is
set to 3 for your driver. The second is checked agains max_write_len
which is unset in your driver and thus can be of any length.
That should work, no?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150112/8f6c67bb/attachment.sig>
next prev parent reply other threads:[~2015-01-12 10:13 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 17:21 [RFC 00/11] i2c: add generic quirk infrastructure Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
[not found] ` <1420824103-24169-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-09 17:21 ` [RFC 01/11] i2c: add quirk structure to describe adapter flaws Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-16 5:50 ` Eddie Huang
2015-01-16 5:50 ` Eddie Huang
2015-01-16 5:50 ` Eddie Huang
2015-01-16 5:50 ` Eddie Huang
2015-01-19 15:05 ` Wolfram Sang
2015-01-19 15:05 ` Wolfram Sang
2015-01-19 15:05 ` Wolfram Sang
2015-01-19 15:05 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-01-16 8:18 ` Yingjoe Chen
2015-01-16 8:18 ` Yingjoe Chen
2015-01-16 8:18 ` Yingjoe Chen
2015-01-16 8:18 ` Yingjoe Chen
2015-01-19 15:00 ` Wolfram Sang
2015-01-19 15:00 ` Wolfram Sang
2015-01-19 15:00 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 02/11] i2c: add quirk checks to core Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
[not found] ` <1420824103-24169-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 19:35 ` Sergei Shtylyov
[not found] ` <54B02D7F.7040501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 10:13 ` Wolfram Sang [this message]
2015-01-12 10:13 ` Wolfram Sang
2015-01-12 10:13 ` Wolfram Sang
2015-01-12 12:08 ` Russell King - ARM Linux
2015-01-12 12:08 ` Russell King - ARM Linux
2015-01-12 12:08 ` Russell King - ARM Linux
2015-01-12 12:08 ` Russell King - ARM Linux
[not found] ` <20150112120814.GE12302-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-02-24 14:25 ` Wolfram Sang
2015-02-24 14:25 ` Wolfram Sang
2015-02-24 14:25 ` Wolfram Sang
2015-02-24 14:25 ` Wolfram Sang
2015-01-12 13:15 ` Matthias Brugger
2015-01-12 13:15 ` Matthias Brugger
2015-01-12 13:15 ` Matthias Brugger
2015-01-12 13:15 ` Matthias Brugger
2015-02-24 14:16 ` Wolfram Sang
2015-02-24 14:16 ` Wolfram Sang
2015-02-24 14:16 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 03/11] i2c: at91: make use of the new infrastructure for quirks Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 04/11] i2c: opal: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 05/11] i2c: qup: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 06/11] i2c: cpm: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 07/11] i2c: axxia: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 08/11] i2c: dln2: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 09/11] i2c: powermac: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 10/11] i2c: viperboard: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 11/11] i2c: pmcmsp: " Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
2015-01-09 17:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112101349.GA995@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.