From: Mike Turquette <mturquette@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] clk: exynos-audss: Fix memory leak on driver unbind or probe failure
Date: Wed, 14 Jan 2015 14:25:04 -0800 [thread overview]
Message-ID: <20150114222504.22722.49023@quantum> (raw)
In-Reply-To: <54AEF541.1090700@codeaurora.org>
Quoting Stephen Boyd (2015-01-08 13:23:13)
> On 01/05/2015 01:52 AM, Krzysztof Kozlowski wrote:
> > The memory allocated by basic clock divider/gate/mux (struct clk_gate,
> > clk_divider and clk_mux) was leaking. During driver unbind or probe
> > failure the driver only unregistered the clocks.
> >
> > Use clk_unregister_{gate,divider,mux} to release all resources.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
I've applied both patches to clk-next. Krzysztof, let me know if you
would prefer to take the audss patch through the samsung clock branch
instead (to include it in a later pull request).
Regards,
Mike
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: exynos-audss: Fix memory leak on driver unbind or probe failure
Date: Wed, 14 Jan 2015 14:25:04 -0800 [thread overview]
Message-ID: <20150114222504.22722.49023@quantum> (raw)
In-Reply-To: <54AEF541.1090700@codeaurora.org>
Quoting Stephen Boyd (2015-01-08 13:23:13)
> On 01/05/2015 01:52 AM, Krzysztof Kozlowski wrote:
> > The memory allocated by basic clock divider/gate/mux (struct clk_gate,
> > clk_divider and clk_mux) was leaking. During driver unbind or probe
> > failure the driver only unregistered the clocks.
> >
> > Use clk_unregister_{gate,divider,mux} to release all resources.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
I've applied both patches to clk-next. Krzysztof, let me know if you
would prefer to take the audss patch through the samsung clock branch
instead (to include it in a later pull request).
Regards,
Mike
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2015-01-14 22:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 9:52 [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak Krzysztof Kozlowski
2015-01-05 9:52 ` [PATCH 1/2] clk: Add clk_unregister_{divider, gate, mux} " Krzysztof Kozlowski
2015-01-05 9:52 ` [PATCH 2/2] clk: exynos-audss: Fix memory leak on driver unbind or probe failure Krzysztof Kozlowski
2015-01-05 9:52 ` Krzysztof Kozlowski
2015-01-08 21:23 ` Stephen Boyd
2015-01-08 21:23 ` Stephen Boyd
2015-01-14 22:25 ` Mike Turquette [this message]
2015-01-14 22:25 ` Mike Turquette
2015-01-15 8:14 ` Krzysztof Kozlowski
2015-01-15 8:14 ` Krzysztof Kozlowski
2015-01-08 21:22 ` [PATCH 1/2] clk: Add clk_unregister_{divider,gate,mux} to close memory leak Stephen Boyd
2015-01-08 21:22 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114222504.22722.49023@quantum \
--to=mturquette@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.