All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines
Date: Fri, 23 Jan 2015 16:39:38 +0000	[thread overview]
Message-ID: <20150123163938.GC11745@x1> (raw)
In-Reply-To: <alpine.DEB.2.11.1501231656310.5526@nanos>

On Fri, 23 Jan 2015, Thomas Gleixner wrote:

> On Thu, 22 Jan 2015, Lee Jones wrote:
> 
> > These defines are used to allow values used for configuration to be
> > easily human readable and will lessen the chance of logical mistakes.
> > 
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >  create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h
> > 
> > diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h
> > new file mode 100644
> > index 0000000..4c59ace
> > --- /dev/null
> > +++ b/include/dt-bindings/interrupt-controller/irq-st.h
> > @@ -0,0 +1,30 @@
> > +/*
> > + *  include/linux/irqchip/irq-st.h
> 
> Copy & Paste?
> 
> Can we please stop adding these pointless filenames all over the
> place? They are useless and wrong in a lot of cases.

Less of a copy and paste and more and a `mv` without fixing up the
file names.  I guess they are silly, but they are rife, so someone must
think they're a good idea. :)

  for file in `find drivers -name *.c`; do head $file | grep "\.c$"; done

> Aside of that, this needs an ack from the DT folks.

I think you'll be lucky.  I haven't seen a DT review for some time
now.  Perhaps, as it's you, this might be different. ;)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	jason@lakedaemon.net, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines
Date: Fri, 23 Jan 2015 16:39:38 +0000	[thread overview]
Message-ID: <20150123163938.GC11745@x1> (raw)
In-Reply-To: <alpine.DEB.2.11.1501231656310.5526@nanos>

On Fri, 23 Jan 2015, Thomas Gleixner wrote:

> On Thu, 22 Jan 2015, Lee Jones wrote:
> 
> > These defines are used to allow values used for configuration to be
> > easily human readable and will lessen the chance of logical mistakes.
> > 
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >  create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h
> > 
> > diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h
> > new file mode 100644
> > index 0000000..4c59ace
> > --- /dev/null
> > +++ b/include/dt-bindings/interrupt-controller/irq-st.h
> > @@ -0,0 +1,30 @@
> > +/*
> > + *  include/linux/irqchip/irq-st.h
> 
> Copy & Paste?
> 
> Can we please stop adding these pointless filenames all over the
> place? They are useless and wrong in a lot of cases.

Less of a copy and paste and more and a `mv` without fixing up the
file names.  I guess they are silly, but they are rife, so someone must
think they're a good idea. :)

  for file in `find drivers -name *.c`; do head $file | grep "\.c$"; done

> Aside of that, this needs an ack from the DT folks.

I think you'll be lucky.  I haven't seen a DT review for some time
now.  Perhaps, as it's you, this might be different. ;)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-01-23 16:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
2015-01-22  9:48 ` Lee Jones
2015-01-22  9:48 ` Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-23 15:58   ` Thomas Gleixner
2015-01-23 15:58     ` Thomas Gleixner
2015-01-23 16:39     ` Lee Jones [this message]
2015-01-23 16:39       ` Lee Jones
2015-01-24 11:46       ` Thomas Gleixner
2015-01-24 11:46         ` Thomas Gleixner
2015-01-24 11:46         ` Thomas Gleixner
2015-01-22  9:48 ` [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-23 16:10   ` Thomas Gleixner
2015-01-23 16:10     ` Thomas Gleixner
2015-01-23 16:10     ` Thomas Gleixner
2015-01-23 16:32     ` Lee Jones
2015-01-23 16:32       ` Lee Jones
2015-01-24 11:48       ` Thomas Gleixner
2015-01-24 11:48         ` Thomas Gleixner
2015-01-22  9:48 ` [PATCH v2 RESEND 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 5/8] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 7/8] ARM: STi: STiH407: Enable PMU IRQs Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones
2015-01-22  9:48   ` Lee Jones
2015-01-22  9:48   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150123163938.GC11745@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.