All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: kernel-janitors@vger.kernel.org,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] drm/bridge: checking the wrong variable
Date: Wed, 28 Jan 2015 07:59:17 +0000	[thread overview]
Message-ID: <20150128075915.GA23469@ulmo> (raw)
In-Reply-To: <CAGS+omBhW+NRm01zGdZDLjWkO1w7D+ZTRt7_uZpvdQqvy1+gew@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

On Wed, Jan 28, 2015 at 02:46:46PM +0800, Daniel Kurtz wrote:
> Hi Dan,
> 
> nit: this patch is not really for "drm/bridge".
> 
> On Wed, Jan 28, 2015 at 2:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > We were supposed to check "fmts" here instead of "formats".  I suppose
> > it eventually leads to a NULL dereference.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> 
> Otherwise, good catch!
> 
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

I've reworded the commit message slightly and applied this. Thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: kernel-janitors@vger.kernel.org,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [patch] drm/bridge: checking the wrong variable
Date: Wed, 28 Jan 2015 08:59:17 +0100	[thread overview]
Message-ID: <20150128075915.GA23469@ulmo> (raw)
In-Reply-To: <CAGS+omBhW+NRm01zGdZDLjWkO1w7D+ZTRt7_uZpvdQqvy1+gew@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

On Wed, Jan 28, 2015 at 02:46:46PM +0800, Daniel Kurtz wrote:
> Hi Dan,
> 
> nit: this patch is not really for "drm/bridge".
> 
> On Wed, Jan 28, 2015 at 2:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > We were supposed to check "fmts" here instead of "formats".  I suppose
> > it eventually leads to a NULL dereference.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> 
> Otherwise, good catch!
> 
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

I've reworded the commit message slightly and applied this. Thanks.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-01-28  7:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28  6:43 [patch] drm/bridge: checking the wrong variable Dan Carpenter
2015-01-28  6:43 ` Dan Carpenter
2015-01-28  6:46 ` Daniel Kurtz
2015-01-28  6:46   ` Daniel Kurtz
2015-01-28  7:59   ` Thierry Reding [this message]
2015-01-28  7:59     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128075915.GA23469@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.