Re: [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format
Date: Fri, 30 Jan 2015 10:25:47 +0900	[thread overview]
Message-ID: <20150130012544.GA32147@verge.net.au> (raw)
In-Reply-To: <87fvavlr0b.wl%kuninori.morimoto.gx@renesas.com>

On Tue, Jan 27, 2015 at 11:52:47PM +0000, Kuninori Morimoto wrote:
> 
> Hi Lars
> 
> > > I guess if you want to use common .daifmt, it should be same as "codec" side.
> > > (cpu side "S" means, codec / daifmt side "M")
> > > So, this mean above should be
> > >
> > > @@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = {
> > >   	.card		= "FSI2B-HDMI",
> > >   	.codec		= "sh-mobile-hdmi",
> > >   	.platform	= "sh_fsi2",
> > > +	.daifmt		= SND_SOC_DAIFMT_CBM_CFM,   <=
> > >   	.cpu_dai = {
> > > 		.name	= "fsib-dai",
> > > -		.fmt	= SND_SOC_DAIFMT_CBS_CFS,
> > >   	},
> > 
> > Right now the CPU is configured as master, with your proposed change it 
> > would be configured as slave. These flags are always from the CODEC's 
> > perspective.
> 
> I see, your patch was correct for CPU = Master

Morimoto-san, could you clarify if you would like me to pick up
this patch or not? (I am a bit confused.)

WARNING: multiple messages have this Message-ID (diff)

From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format
Date: Fri, 30 Jan 2015 01:25:47 +0000	[thread overview]
Message-ID: <20150130012544.GA32147@verge.net.au> (raw)
In-Reply-To: <87fvavlr0b.wl%kuninori.morimoto.gx@renesas.com>

On Tue, Jan 27, 2015 at 11:52:47PM +0000, Kuninori Morimoto wrote:
> 
> Hi Lars
> 
> > > I guess if you want to use common .daifmt, it should be same as "codec" side.
> > > (cpu side "S" means, codec / daifmt side "M")
> > > So, this mean above should be
> > >
> > > @@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = {
> > >   	.card		= "FSI2B-HDMI",
> > >   	.codec		= "sh-mobile-hdmi",
> > >   	.platform	= "sh_fsi2",
> > > +	.daifmt		= SND_SOC_DAIFMT_CBM_CFM,   <> > >   	.cpu_dai = {
> > > 		.name	= "fsib-dai",
> > > -		.fmt	= SND_SOC_DAIFMT_CBS_CFS,
> > >   	},
> > 
> > Right now the CPU is configured as master, with your proposed change it 
> > would be configured as slave. These flags are always from the CODEC's 
> > perspective.
> 
> I see, your patch was correct for CPU = Master

Morimoto-san, could you clarify if you would like me to pick up
this patch or not? (I am a bit confused.)

WARNING: multiple messages have this Message-ID (diff)

From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format
Date: Fri, 30 Jan 2015 10:25:47 +0900	[thread overview]
Message-ID: <20150130012544.GA32147@verge.net.au> (raw)
In-Reply-To: <87fvavlr0b.wl%kuninori.morimoto.gx@renesas.com>

On Tue, Jan 27, 2015 at 11:52:47PM +0000, Kuninori Morimoto wrote:
> 
> Hi Lars
> 
> > > I guess if you want to use common .daifmt, it should be same as "codec" side.
> > > (cpu side "S" means, codec / daifmt side "M")
> > > So, this mean above should be
> > >
> > > @@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = {
> > >   	.card		= "FSI2B-HDMI",
> > >   	.codec		= "sh-mobile-hdmi",
> > >   	.platform	= "sh_fsi2",
> > > +	.daifmt		= SND_SOC_DAIFMT_CBM_CFM,   <=
> > >   	.cpu_dai = {
> > > 		.name	= "fsib-dai",
> > > -		.fmt	= SND_SOC_DAIFMT_CBS_CFS,
> > >   	},
> > 
> > Right now the CPU is configured as master, with your proposed change it 
> > would be configured as slave. These flags are always from the CODEC's 
> > perspective.
> 
> I see, your patch was correct for CPU = Master

Morimoto-san, could you clarify if you would like me to pick up
this patch or not? (I am a bit confused.)

next prev parent reply	other threads:[~2015-01-30  1:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 13:38 [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format Lars-Peter Clausen
2015-01-21 13:38 ` Lars-Peter Clausen
2015-01-21 13:38 ` Lars-Peter Clausen
2015-01-21 13:38 ` [PATCH v2 2/3] ASoC: sh: fsi: Fix clock inversion Lars-Peter Clausen
2015-01-21 13:38   ` Lars-Peter Clausen
2015-01-21 13:38   ` Lars-Peter Clausen
2016-01-29 15:52   ` Geert Uytterhoeven
2016-01-29 15:52     ` Geert Uytterhoeven
2015-01-21 13:38 ` [PATCH v2 3/3] ASoC: simple-card: Remove support for setting differing DAI formats Lars-Peter Clausen
2015-01-21 13:38   ` Lars-Peter Clausen
2015-01-21 13:38   ` Lars-Peter Clausen
2015-01-27  0:58 ` [PATCH v2 1/3] ARM: shmobile: armadillo800eva: Properly specify HDMI audio link format Simon Horman
2015-01-27  0:58   ` Simon Horman
2015-01-27  0:58   ` Simon Horman
2015-01-27  7:40 ` Kuninori Morimoto
2015-01-27  7:40   ` Kuninori Morimoto
2015-01-27  7:40   ` Kuninori Morimoto
2015-01-27  8:19   ` Lars-Peter Clausen
2015-01-27  8:19     ` Lars-Peter Clausen
2015-01-27  8:19     ` Lars-Peter Clausen
2015-01-27 23:52     ` Kuninori Morimoto
2015-01-27 23:52       ` Kuninori Morimoto
2015-01-27 23:52       ` Kuninori Morimoto
2015-01-30  1:25       ` Simon Horman [this message]
2015-01-30  1:25         ` Simon Horman
2015-01-30  1:25         ` Simon Horman
2015-01-30  5:18 ` Kuninori Morimoto
2015-01-30  5:18   ` Kuninori Morimoto
2015-02-11  0:28   ` Simon Horman
2015-02-11  0:28     ` Simon Horman
2015-02-11  0:28     ` Simon Horman
2015-02-27  0:23     ` Kuninori Morimoto
2015-02-27  0:23       ` Kuninori Morimoto
2015-03-22 18:52       ` Mark Brown
2015-03-22 18:52         ` Mark Brown
2015-03-23  7:00         ` Kuninori Morimoto
2015-03-23  7:00           ` Kuninori Morimoto
2015-03-23 21:12           ` Mark Brown
2015-03-23 21:12             ` Mark Brown
2015-03-23 21:12             ` Mark Brown
2015-03-24  0:07             ` Kuninori Morimoto
2015-03-24  0:07               ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130012544.GA32147@verge.net.au \
    --to=horms@verge.net.au \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.