Re: 3.19 on Nokia n900: audio quality awful

[Pavel Machek <pavel@ucw.cz>]

Hi!

I looked around the diff between 3.18 and 3.19, reverted these, and
audio quality is back to reasonable level.

commit 68f438378cde79e29f71c7e043b10d76001d8892
Author: Lars-Peter Clausen <lars@metafoo.de>
Date:   Wed Nov 26 20:57:57 2014 +0100

    ASoC: tlv320aic3x: Cleanup manual bias level transitions

    Since the ASoC core now takes care of setting the bias level to
        SND_SOC_BIAS_OFF when removing the CODEC there is no need to
        do it manually
	    anymore.

    Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
        Signed-off-by: Mark Brown <broonie@kernel.org>

commit 68d6626925c3529790a2055d41578415fa98495e
Author: Misael Lopez Cruz <misael.lopez@ti.com>
Date:   Tue Nov 11 10:59:01 2014 +0200

    ASoC: tlv320aic3x: Add output driver pop reduction controls

    Output driver has two parameters that can be configured to reduce
        pop noise: power-on delay and ramp-up step time. Two new
        kcontrols
	    have been added to set these parameters.

    Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
        Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
	    Signed-off-by: Mark Brown <broonie@kernel.org>
	    

commit 368494093354ac613a80c2e1d77602aa12473cf0
Author: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date:   Mon Nov 10 12:27:33 2014 +0200

    ASoC: tlv320aic3x: Add TDM support

    TDM support is achieved using DSP transfer mode and setting a
        programmable offset which specifies where data begins with
	    respect to the frame sync.

    It requires 256-clock mode if CODEC is master (not currently
        supported in the driver). No additional dependency if CODEC
	    is slave.

    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
        Signed-off-by: Mark Brown <broonie@kernel.org>
	

> diff --git a/sound/soc/omap/rx51.c b/sound/soc/omap/rx51.c
> index 04896d6252a2..7f299357c2d2 100644
> --- a/sound/soc/omap/rx51.c
> +++ b/sound/soc/omap/rx51.c
> @@ -250,14 +250,14 @@ static const struct snd_soc_dapm_route audio_map[] = {
>  	{"FM Transmitter", NULL, "LLOUT"},
>  	{"FM Transmitter", NULL, "RLOUT"},
> 
> -	{"DMic Rate 64", NULL, "Mic Bias"},
> -	{"Mic Bias", NULL, "DMic"},
> +	{"DMic Rate 64", NULL, "DMic"},
> +	{"DMic", NULL, "Mic Bias"},
> 
>  	{"b LINE2R", NULL, "MONO_LOUT"},
>  	{"Earphone", NULL, "b HPLOUT"},
> 
> -	{"LINE1L", NULL, "b Mic Bias"},
> -	{"b Mic Bias", NULL, "HS Mic"}
> +	{"LINE1L", NULL, "HS Mic"},
> +	{"HS Mic", NULL, "b Mic Bias"},
>  };
> 
>  static const char * const spk_function[] = {"Off", "On"};
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html