All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] USB: gadget: at91_udc: add at91sam9n12 support
Date: Mon, 9 Feb 2015 12:14:34 +0100	[thread overview]
Message-ID: <20150209111434.GN3715@piout.net> (raw)
In-Reply-To: <1423472572-19824-2-git-send-email-voice.shen@atmel.com>

Hi Bo,

On 09/02/2015 at 17:02:50 +0800, Bo Shen wrote :
> Add at91sam9n12 SoC support.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> 
>  drivers/usb/gadget/udc/at91_udc.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index c862656..f4c785f 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -931,7 +931,8 @@ static void pullup(struct at91_udc *udc, int is_on)
>  		at91_udp_write(udc, AT91_UDP_TXVC, 0);
>  		if (cpu_is_at91rm9200())
>  			gpio_set_value(udc->board.pullup_pin, active);
> -		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() || cpu_is_at91sam9g20()) {
> +		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() ||
> +			 cpu_is_at91sam9g20() || cpu_is_at91sam9n12()) {

cpu_is_at91xx have been removed from the kernel, using the correct
compatible should be enough, see
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/usb/gadget/udc/at91_udc.c?id=f0bceab4e3b528e799aba8fda8d2936fcfd41f1f


>  			u32	txvc = at91_udp_read(udc, AT91_UDP_TXVC);
>  
>  			txvc |= AT91_UDP_TXVC_PUON;
> @@ -949,7 +950,8 @@ static void pullup(struct at91_udc *udc, int is_on)
>  		at91_udp_write(udc, AT91_UDP_TXVC, AT91_UDP_TXVC_TXVDIS);
>  		if (cpu_is_at91rm9200())
>  			gpio_set_value(udc->board.pullup_pin, !active);
> -		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() || cpu_is_at91sam9g20()) {
> +		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() ||
> +			 cpu_is_at91sam9g20() || cpu_is_at91sam9n12()) {
>  			u32	txvc = at91_udp_read(udc, AT91_UDP_TXVC);
>  
>  			txvc &= ~AT91_UDP_TXVC_PUON;
> @@ -1758,7 +1760,8 @@ static int at91udc_probe(struct platform_device *pdev)
>  	}
>  
>  	/* newer chips have more FIFO memory than rm9200 */
> -	if (cpu_is_at91sam9260() || cpu_is_at91sam9g20()) {
> +	if (cpu_is_at91sam9260() || cpu_is_at91sam9g20() ||
> +	    cpu_is_at91sam9n12()) {
>  		udc->ep[0].maxpacket = 64;
>  		udc->ep[3].maxpacket = 64;
>  		udc->ep[4].maxpacket = 512;
> -- 
> 2.3.0.rc0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Bo Shen <voice.shen@atmel.com>
Cc: balbi@ti.com, nicolas.ferre@atmel.com,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] USB: gadget: at91_udc: add at91sam9n12 support
Date: Mon, 9 Feb 2015 12:14:34 +0100	[thread overview]
Message-ID: <20150209111434.GN3715@piout.net> (raw)
In-Reply-To: <1423472572-19824-2-git-send-email-voice.shen@atmel.com>

Hi Bo,

On 09/02/2015 at 17:02:50 +0800, Bo Shen wrote :
> Add at91sam9n12 SoC support.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> 
>  drivers/usb/gadget/udc/at91_udc.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index c862656..f4c785f 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -931,7 +931,8 @@ static void pullup(struct at91_udc *udc, int is_on)
>  		at91_udp_write(udc, AT91_UDP_TXVC, 0);
>  		if (cpu_is_at91rm9200())
>  			gpio_set_value(udc->board.pullup_pin, active);
> -		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() || cpu_is_at91sam9g20()) {
> +		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() ||
> +			 cpu_is_at91sam9g20() || cpu_is_at91sam9n12()) {

cpu_is_at91xx have been removed from the kernel, using the correct
compatible should be enough, see
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/usb/gadget/udc/at91_udc.c?id=f0bceab4e3b528e799aba8fda8d2936fcfd41f1f


>  			u32	txvc = at91_udp_read(udc, AT91_UDP_TXVC);
>  
>  			txvc |= AT91_UDP_TXVC_PUON;
> @@ -949,7 +950,8 @@ static void pullup(struct at91_udc *udc, int is_on)
>  		at91_udp_write(udc, AT91_UDP_TXVC, AT91_UDP_TXVC_TXVDIS);
>  		if (cpu_is_at91rm9200())
>  			gpio_set_value(udc->board.pullup_pin, !active);
> -		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() || cpu_is_at91sam9g20()) {
> +		else if (cpu_is_at91sam9260() || cpu_is_at91sam9263() ||
> +			 cpu_is_at91sam9g20() || cpu_is_at91sam9n12()) {
>  			u32	txvc = at91_udp_read(udc, AT91_UDP_TXVC);
>  
>  			txvc &= ~AT91_UDP_TXVC_PUON;
> @@ -1758,7 +1760,8 @@ static int at91udc_probe(struct platform_device *pdev)
>  	}
>  
>  	/* newer chips have more FIFO memory than rm9200 */
> -	if (cpu_is_at91sam9260() || cpu_is_at91sam9g20()) {
> +	if (cpu_is_at91sam9260() || cpu_is_at91sam9g20() ||
> +	    cpu_is_at91sam9n12()) {
>  		udc->ep[0].maxpacket = 64;
>  		udc->ep[3].maxpacket = 64;
>  		udc->ep[4].maxpacket = 512;
> -- 
> 2.3.0.rc0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-02-09 11:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09  9:02 [PATCH 0/3] ARM: at91: at91sam9n12ek: enable usb gadget support Bo Shen
2015-02-09  9:02 ` Bo Shen
2015-02-09  9:02 ` Bo Shen
2015-02-09  9:02 ` [PATCH 1/3] USB: gadget: at91_udc: add at91sam9n12 support Bo Shen
2015-02-09  9:02   ` Bo Shen
2015-02-09  9:02   ` Bo Shen
2015-02-09 11:14   ` Alexandre Belloni [this message]
2015-02-09 11:14     ` Alexandre Belloni
2015-02-10  1:25     ` Bo Shen
2015-02-10  1:25       ` Bo Shen
2015-02-10  1:25       ` Bo Shen
2015-02-09  9:02 ` [PATCH 2/3] ARM: at91: dt: at91sam9n12: add udp device node Bo Shen
2015-02-09  9:02   ` Bo Shen
2015-02-09  9:02   ` Bo Shen
2015-02-09  9:02 ` [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp Bo Shen
2015-02-09  9:02   ` Bo Shen
2015-02-09  9:02   ` Bo Shen
2015-02-09 10:04   ` Sylvain Rochet
2015-02-09 10:04     ` Sylvain Rochet
2015-02-09 10:04     ` Sylvain Rochet
2015-02-09 10:23     ` Bo Shen
2015-02-09 10:23       ` Bo Shen
2015-02-09 10:23       ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209111434.GN3715@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.