From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp
Date: Mon, 9 Feb 2015 18:23:29 +0800 [thread overview]
Message-ID: <54D88AA1.3020402@atmel.com> (raw)
In-Reply-To: <20150209100404.GA17242@gradator.net>
Hi Sylvain,
On 02/09/2015 06:04 PM, Sylvain Rochet wrote:
> Hello Bo,
>
> On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote:
>> Enable usb device port on at91sam9n12ek board.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>>
>> arch/arm/boot/dts/at91sam9n12ek.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index 13bb24e..3e572e5 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -120,6 +120,11 @@
>> };
>> };
>>
>> + usb1: gadget at f803c000 {
>> + atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
>> + status = "okay";
>> + };
>> +
>
> There is an external resistor divider on PB16, acting like a pull-down
> (R22+R23). PB16 reset state is input, pull-up, schmitt trigger, you need
> to disable the pull-up in pinctrl this way:
>
> usb1: gadget at f803c000 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_board_usb1>;
> ?
> }
>
> pinctrl ? {
> usb1 {
> pinctrl_board_usb1: usb1-board {
> atmel,pins = <AT91_PIOB 16 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; /* PB16, no pull up and deglitch */
> };
> };
> };
Thanks.
I will add it in next version.
>
> Sylvain
>
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Sylvain Rochet <sylvain.rochet-ETtyaVkrhkNWk0Htik3J/w@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp
Date: Mon, 9 Feb 2015 18:23:29 +0800 [thread overview]
Message-ID: <54D88AA1.3020402@atmel.com> (raw)
In-Reply-To: <20150209100404.GA17242-XWGZPxRNpGHk1uMJSBkQmQ@public.gmane.org>
Hi Sylvain,
On 02/09/2015 06:04 PM, Sylvain Rochet wrote:
> Hello Bo,
>
> On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote:
>> Enable usb device port on at91sam9n12ek board.
>>
>> Signed-off-by: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>> ---
>>
>> arch/arm/boot/dts/at91sam9n12ek.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index 13bb24e..3e572e5 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -120,6 +120,11 @@
>> };
>> };
>>
>> + usb1: gadget@f803c000 {
>> + atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
>> + status = "okay";
>> + };
>> +
>
> There is an external resistor divider on PB16, acting like a pull-down
> (R22+R23). PB16 reset state is input, pull-up, schmitt trigger, you need
> to disable the pull-up in pinctrl this way:
>
> usb1: gadget@f803c000 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_board_usb1>;
> …
> }
>
> pinctrl … {
> usb1 {
> pinctrl_board_usb1: usb1-board {
> atmel,pins = <AT91_PIOB 16 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; /* PB16, no pull up and deglitch */
> };
> };
> };
Thanks.
I will add it in next version.
>
> Sylvain
>
Best Regards,
Bo Shen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Sylvain Rochet <sylvain.rochet@finsecur.com>
Cc: <balbi@ti.com>, <nicolas.ferre@atmel.com>,
<devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp
Date: Mon, 9 Feb 2015 18:23:29 +0800 [thread overview]
Message-ID: <54D88AA1.3020402@atmel.com> (raw)
In-Reply-To: <20150209100404.GA17242@gradator.net>
Hi Sylvain,
On 02/09/2015 06:04 PM, Sylvain Rochet wrote:
> Hello Bo,
>
> On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote:
>> Enable usb device port on at91sam9n12ek board.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>>
>> arch/arm/boot/dts/at91sam9n12ek.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts
>> index 13bb24e..3e572e5 100644
>> --- a/arch/arm/boot/dts/at91sam9n12ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts
>> @@ -120,6 +120,11 @@
>> };
>> };
>>
>> + usb1: gadget@f803c000 {
>> + atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
>> + status = "okay";
>> + };
>> +
>
> There is an external resistor divider on PB16, acting like a pull-down
> (R22+R23). PB16 reset state is input, pull-up, schmitt trigger, you need
> to disable the pull-up in pinctrl this way:
>
> usb1: gadget@f803c000 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_board_usb1>;
> …
> }
>
> pinctrl … {
> usb1 {
> pinctrl_board_usb1: usb1-board {
> atmel,pins = <AT91_PIOB 16 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; /* PB16, no pull up and deglitch */
> };
> };
> };
Thanks.
I will add it in next version.
>
> Sylvain
>
Best Regards,
Bo Shen
next prev parent reply other threads:[~2015-02-09 10:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 9:02 [PATCH 0/3] ARM: at91: at91sam9n12ek: enable usb gadget support Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 9:02 ` [PATCH 1/3] USB: gadget: at91_udc: add at91sam9n12 support Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 11:14 ` Alexandre Belloni
2015-02-09 11:14 ` Alexandre Belloni
2015-02-10 1:25 ` Bo Shen
2015-02-10 1:25 ` Bo Shen
2015-02-10 1:25 ` Bo Shen
2015-02-09 9:02 ` [PATCH 2/3] ARM: at91: dt: at91sam9n12: add udp device node Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 9:02 ` [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 9:02 ` Bo Shen
2015-02-09 10:04 ` Sylvain Rochet
2015-02-09 10:04 ` Sylvain Rochet
2015-02-09 10:04 ` Sylvain Rochet
2015-02-09 10:23 ` Bo Shen [this message]
2015-02-09 10:23 ` Bo Shen
2015-02-09 10:23 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D88AA1.3020402@atmel.com \
--to=voice.shen@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.