* [patch] PM / devfreq: event: testing the wrong variable
@ 2015-02-10 10:35 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-02-10 10:35 UTC (permalink / raw)
To: linux-arm-kernel
There is a typo here so we test "edev" but we intended to test
"edev[i]".
Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 135be0a..ad83473 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
for (i = 0; i < info->num_events; i++) {
edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
- if (IS_ERR(edev)) {
- ret = PTR_ERR(edev);
+ if (IS_ERR(edev[i])) {
+ ret = PTR_ERR(edev[i]);
dev_err(&pdev->dev,
"failed to add devfreq-event device\n");
goto err;
^ permalink raw reply related [flat|nested] 8+ messages in thread* [patch] PM / devfreq: event: testing the wrong variable
@ 2015-02-10 10:35 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-02-10 10:35 UTC (permalink / raw)
To: linux-arm-kernel
There is a typo here so we test "edev" but we intended to test
"edev[i]".
Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 135be0a..ad83473 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
for (i = 0; i < info->num_events; i++) {
edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
- if (IS_ERR(edev)) {
- ret = PTR_ERR(edev);
+ if (IS_ERR(edev[i])) {
+ ret = PTR_ERR(edev[i]);
dev_err(&pdev->dev,
"failed to add devfreq-event device\n");
goto err;
^ permalink raw reply related [flat|nested] 8+ messages in thread* [patch] PM / devfreq: event: testing the wrong variable
@ 2015-02-10 10:35 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-02-10 10:35 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi
Cc: Kyungmin Park, Kukjin Kim, linux-pm, linux-arm-kernel,
linux-samsung-soc, kernel-janitors
There is a typo here so we test "edev" but we intended to test
"edev[i]".
Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 135be0a..ad83473 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
for (i = 0; i < info->num_events; i++) {
edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
- if (IS_ERR(edev)) {
- ret = PTR_ERR(edev);
+ if (IS_ERR(edev[i])) {
+ ret = PTR_ERR(edev[i]);
dev_err(&pdev->dev,
"failed to add devfreq-event device\n");
goto err;
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [patch] PM / devfreq: event: testing the wrong variable
2015-02-10 10:35 ` Dan Carpenter
(?)
@ 2015-02-10 10:59 ` Chanwoo Choi
-1 siblings, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2015-02-10 10:59 UTC (permalink / raw)
To: linux-arm-kernel
On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> There is a typo here so we test "edev" but we intended to test
> "edev[i]".
>
> Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 135be0a..ad83473 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> - if (IS_ERR(edev)) {
> - ret = PTR_ERR(edev);
> + if (IS_ERR(edev[i])) {
> + ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> goto err;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 8+ messages in thread* [patch] PM / devfreq: event: testing the wrong variable
@ 2015-02-10 10:59 ` Chanwoo Choi
0 siblings, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2015-02-10 10:59 UTC (permalink / raw)
To: linux-arm-kernel
On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> There is a typo here so we test "edev" but we intended to test
> "edev[i]".
>
> Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 135be0a..ad83473 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> - if (IS_ERR(edev)) {
> - ret = PTR_ERR(edev);
> + if (IS_ERR(edev[i])) {
> + ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> goto err;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] PM / devfreq: event: testing the wrong variable
@ 2015-02-10 10:59 ` Chanwoo Choi
0 siblings, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2015-02-10 10:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: MyungJoo Ham, Kyungmin Park, Kukjin Kim, linux-pm,
linux-arm-kernel, linux-samsung-soc, kernel-janitors
On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> There is a typo here so we test "edev" but we intended to test
> "edev[i]".
>
> Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 135be0a..ad83473 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
>
> for (i = 0; i < info->num_events; i++) {
> edev[i] = devm_devfreq_event_add_edev(&pdev->dev, &desc[i]);
> - if (IS_ERR(edev)) {
> - ret = PTR_ERR(edev);
> + if (IS_ERR(edev[i])) {
> + ret = PTR_ERR(edev[i]);
> dev_err(&pdev->dev,
> "failed to add devfreq-event device\n");
> goto err;
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
But,
This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
After releasing Linux 3.20-rc1, this patch will be handled.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [patch] PM / devfreq: event: testing the wrong variable
2015-02-10 10:35 ` Dan Carpenter
@ 2015-02-12 9:00 ` MyungJoo Ham
-1 siblings, 0 replies; 8+ messages in thread
From: MyungJoo Ham @ 2015-02-12 9:00 UTC (permalink / raw)
To: 최찬우, Dan Carpenter
Cc: 박경민, Kukjin Kim, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org
>
> On 02/10/2015 07:35 PM, Dan Carpenter wrote:
> > There is a typo here so we test "edev" but we intended to test
> > "edev[i]".
> >
> > Fixes: f262f28c1470 ('PM / devfreq: event: Add devfreq_event class')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> > index 135be0a..ad83473 100644
> > --- a/drivers/devfreq/event/exynos-ppmu.c
> > +++ b/drivers/devfreq/event/exynos-ppmu.c
> > @@ -327,8 +327,8 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
> > - if (IS_ERR(edev)) {
> > - ret = PTR_ERR(edev);
> > + if (IS_ERR(edev[i])) {
> > + ret = PTR_ERR(edev[i]);
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> But,
> This patch has not yet merged to linux.git (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git).
> After releasing Linux 3.20-rc1, this patch will be handled.
>
> Thanks,
> Chanwoo Choi
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Re: [patch] PM / devfreq: event: testing the wrong variable
@ 2015-02-12 9:00 ` MyungJoo Ham
0 siblings, 0 replies; 8+ messages in thread
From: MyungJoo Ham @ 2015-02-12 9:00 UTC (permalink / raw)
To: 최찬우, Dan Carpenter
Cc: 박경민, Kukjin Kim, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
kernel-janitors@vger.kernel.org
PiAgIA0KPiAgT24gMDIvMTAvMjAxNSAwNzozNSBQTSwgRGFuIENhcnBlbnRlciB3cm90ZToNCj4g
PiBUaGVyZSBpcyBhIHR5cG8gaGVyZSBzbyB3ZSB0ZXN0ICJlZGV2IiBidXQgd2UgaW50ZW5kZWQg
dG8gdGVzdA0KPiA+ICJlZGV2W2ldIi4NCj4gPiANCj4gPiBGaXhlczogZjI2MmYyOGMxNDcwICgn
UE0gLyBkZXZmcmVxOiBldmVudDogQWRkIGRldmZyZXFfZXZlbnQgY2xhc3MnKQ0KPiA+IFNpZ25l
ZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NCj4gPiAN
Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kZXZmcmVxL2V2ZW50L2V4eW5vcy1wcG11LmMgYi9k
cml2ZXJzL2RldmZyZXEvZXZlbnQvZXh5bm9zLXBwbXUuYw0KPiA+IGluZGV4IDEzNWJlMGEuLmFk
ODM0NzMgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9kZXZmcmVxL2V2ZW50L2V4eW5vcy1wcG11
LmMNCj4gPiArKysgYi9kcml2ZXJzL2RldmZyZXEvZXZlbnQvZXh5bm9zLXBwbXUuYw0KPiA+IEBA
IC0zMjcsOCArMzI3LDggQEAgc3RhdGljIGludCBleHlub3NfcHBtdV9wcm9iZShzdHJ1Y3QgcGxh
dGZvcm1fZGV2aWNlICpwZGV2KQ0KPiA+IC0JCWlmIChJU19FUlIoZWRldikpIHsNCj4gPiAtCQkJ
cmV0ID0gUFRSX0VSUihlZGV2KTsNCj4gPiArCQlpZiAoSVNfRVJSKGVkZXZbaV0pKSB7DQo+ID4g
KwkJCXJldCA9IFBUUl9FUlIoZWRldltpXSk7DQo+IA0KPiBSZXZpZXdlZC1ieTogQ2hhbndvbyBD
aG9pIDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+DQo+IA0KPiBCdXQsDQo+IFRoaXMgcGF0Y2ggaGFz
IG5vdCB5ZXQgbWVyZ2VkIHRvIGxpbnV4LmdpdCAoaHR0cDovL2dpdC5rZXJuZWwub3JnL2NnaXQv
bGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQpLg0KPiBBZnRlciByZWxlYXNpbmcg
TGludXggMy4yMC1yYzEsIHRoaXMgcGF0Y2ggd2lsbCBiZSBoYW5kbGVkLg0KPiANCj4gVGhhbmtz
LA0KPiBDaGFud29vIENob2kNCg0KQWNrZWQtYnk6IE15dW5nSm9vIEhhbSA8bXl1bmdqb28uaGFt
QHNhbXN1bmcuY29tPg0KDQo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-12 9:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-10 10:35 [patch] PM / devfreq: event: testing the wrong variable Dan Carpenter
2015-02-10 10:35 ` Dan Carpenter
2015-02-10 10:35 ` Dan Carpenter
2015-02-10 10:59 ` Chanwoo Choi
2015-02-10 10:59 ` Chanwoo Choi
2015-02-10 10:59 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2015-02-12 9:00 MyungJoo Ham
2015-02-12 9:00 ` MyungJoo Ham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.