All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: "Arve Hj�nnev�g" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: android: Remove allocation from declaration line
Date: Tue, 10 Feb 2015 22:24:12 +0000	[thread overview]
Message-ID: <20150210222412.GA27072@kroah.com> (raw)
In-Reply-To: <20150210110945.GA17910@sloth>

On Tue, Feb 10, 2015 at 12:09:45PM +0100, Quentin Lambert wrote:
> This patch removes allocation from declaration line because
> people are known to gloss over declarations.

Then those people should not be reviewing kernel code :)

Seriously, this is unneeded churn, the code is fine as-is.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: "Arve Hj�nnev�g" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: android: Remove allocation from declaration line
Date: Wed, 11 Feb 2015 06:24:12 +0800	[thread overview]
Message-ID: <20150210222412.GA27072@kroah.com> (raw)
In-Reply-To: <20150210110945.GA17910@sloth>

On Tue, Feb 10, 2015 at 12:09:45PM +0100, Quentin Lambert wrote:
> This patch removes allocation from declaration line because
> people are known to gloss over declarations.

Then those people should not be reviewing kernel code :)

Seriously, this is unneeded churn, the code is fine as-is.

thanks,

greg k-h

  reply	other threads:[~2015-02-10 22:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 11:09 [PATCH 1/1] staging: android: Remove allocation from declaration line Quentin Lambert
2015-02-10 11:09 ` Quentin Lambert
2015-02-10 22:24 ` Greg Kroah-Hartman [this message]
2015-02-10 22:24   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150210222412.GA27072@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lambert.quentin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.