From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt
Date: Thu, 19 Feb 2015 12:17:15 +0100 [thread overview]
Message-ID: <20150219111715.GS25269@lukather> (raw)
In-Reply-To: <87vbiz87j2.fsf@free.fr>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On Wed, Feb 18, 2015 at 06:16:17PM +0100, Robert Jarzmik wrote:
> >> @@ -1672,7 +1688,8 @@ static int alloc_nand_resource(struct platform_device *pdev)
> >> /* initialize all interrupts to be disabled */
> >> disable_int(info, NDSR_MASK);
> >>
> >> - ret = request_irq(irq, pxa3xx_nand_irq, 0, pdev->name, info);
> >> + ret = request_threaded_irq(irq, pxa3xx_nand_irq,
> >> + pxa3xx_nand_irq_thread, 0, pdev->name, info);
> >
> > Using IRQF_ONESHOT would allow you not to do the interrupt enable /
> > disable dance.
>
> Yes, that's a very good point. Would your Tested-by still hold with
> this change ?
Yep, I actually tested it before suggesting it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt
Date: Thu, 19 Feb 2015 12:17:15 +0100 [thread overview]
Message-ID: <20150219111715.GS25269@lukather> (raw)
In-Reply-To: <87vbiz87j2.fsf@free.fr>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On Wed, Feb 18, 2015 at 06:16:17PM +0100, Robert Jarzmik wrote:
> >> @@ -1672,7 +1688,8 @@ static int alloc_nand_resource(struct platform_device *pdev)
> >> /* initialize all interrupts to be disabled */
> >> disable_int(info, NDSR_MASK);
> >>
> >> - ret = request_irq(irq, pxa3xx_nand_irq, 0, pdev->name, info);
> >> + ret = request_threaded_irq(irq, pxa3xx_nand_irq,
> >> + pxa3xx_nand_irq_thread, 0, pdev->name, info);
> >
> > Using IRQF_ONESHOT would allow you not to do the interrupt enable /
> > disable dance.
>
> Yes, that's a very good point. Would your Tested-by still hold with
> this change ?
Yep, I actually tested it before suggesting it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-19 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 20:06 [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt Robert Jarzmik
2015-02-17 20:06 ` Robert Jarzmik
2015-02-18 10:16 ` Maxime Ripard
2015-02-18 10:16 ` Maxime Ripard
2015-02-18 17:16 ` Robert Jarzmik
2015-02-18 17:16 ` Robert Jarzmik
2015-02-19 11:17 ` Maxime Ripard [this message]
2015-02-19 11:17 ` Maxime Ripard
2015-02-18 11:42 ` Ezequiel Garcia
2015-02-18 16:09 ` Robert Jarzmik
2015-02-18 16:09 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219111715.GS25269@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.