From: Guenter Roeck <linux@roeck-us.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT
Date: Wed, 25 Feb 2015 16:20:00 +0000 [thread overview]
Message-ID: <20150225162000.GA25241@roeck-us.net> (raw)
In-Reply-To: <20150225150459.GE17992@lunn.ch>
On Wed, Feb 25, 2015 at 04:04:59PM +0100, Andrew Lunn wrote:
> > However, we need to state and check in the code that _some_ property
> > is mandatory. A driver with only optional properties doesn't make
> > sense.
>
> The patch to the binding documentation said:
>
> Note: At least one the "gpios" and "alarm-gpios" properties should be set.
>
> which i then suggested should be:
>
> Note: At least one of "gpios" or "alarm-gpios" properties should be set.
>
"should" is not "must".
Guenter
> What we could do is move this sentence into the Required Properties of
> the documentation.
>
> The patch Simon submitted also does check that this condition is
> fulfilled.
>
> Andrew
>
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT
Date: Wed, 25 Feb 2015 08:20:00 -0800 [thread overview]
Message-ID: <20150225162000.GA25241@roeck-us.net> (raw)
In-Reply-To: <20150225150459.GE17992@lunn.ch>
On Wed, Feb 25, 2015 at 04:04:59PM +0100, Andrew Lunn wrote:
> > However, we need to state and check in the code that _some_ property
> > is mandatory. A driver with only optional properties doesn't make
> > sense.
>
> The patch to the binding documentation said:
>
> Note: At least one the "gpios" and "alarm-gpios" properties should be set.
>
> which i then suggested should be:
>
> Note: At least one of "gpios" or "alarm-gpios" properties should be set.
>
"should" is not "must".
Guenter
> What we could do is move this sentence into the Required Properties of
> the documentation.
>
> The patch Simon submitted also does check that this condition is
> fulfilled.
>
> Andrew
>
>
>
next prev parent reply other threads:[~2015-02-25 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 12:58 [lm-sensors] [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT Simon Guinot
2015-02-23 12:58 ` Simon Guinot
2015-02-23 13:42 ` [lm-sensors] " Andrew Lunn
2015-02-23 13:42 ` Andrew Lunn
2015-02-23 14:06 ` [lm-sensors] " Guenter Roeck
2015-02-23 14:06 ` Guenter Roeck
2015-02-23 14:34 ` [lm-sensors] " Simon Guinot
2015-02-23 14:34 ` Simon Guinot
2015-02-23 14:43 ` [lm-sensors] " Guenter Roeck
2015-02-23 14:43 ` Guenter Roeck
2015-02-25 11:14 ` [lm-sensors] " Simon Guinot
2015-02-25 11:14 ` Simon Guinot
2015-02-25 13:50 ` [lm-sensors] " Andrew Lunn
2015-02-25 13:50 ` Andrew Lunn
2015-02-25 14:29 ` [lm-sensors] " Simon Guinot
2015-02-25 14:29 ` Simon Guinot
2015-02-25 14:52 ` [lm-sensors] " Guenter Roeck
2015-02-25 14:52 ` Guenter Roeck
2015-02-25 14:51 ` [lm-sensors] " Guenter Roeck
2015-02-25 14:51 ` Guenter Roeck
2015-02-25 15:04 ` [lm-sensors] " Andrew Lunn
2015-02-25 15:04 ` Andrew Lunn
2015-02-25 16:20 ` Guenter Roeck [this message]
2015-02-25 16:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225162000.GA25241@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.