From: Guenter Roeck <linux@roeck-us.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT
Date: Wed, 25 Feb 2015 14:51:29 +0000 [thread overview]
Message-ID: <54EDE171.7040403@roeck-us.net> (raw)
In-Reply-To: <20150225135015.GA17992@lunn.ch>
On 02/25/2015 05:50 AM, Andrew Lunn wrote:
>> Handle the GPIO fan alarm feature from the fan controller driver don't
>> look good either to me. This alarm mechanism is not a part of the fan
>> controller itself but rather something apart. Also I am afraid that the
>> result would really look like a hack.
>
> Hi Simon
>
> It sounds like you need to extract the alarm code from gpio-fan into a
> little library. Then put a wrapper around it to make a gpio-fan-alarm
> driver.
>
Please, the intend is to do the right thing, not to cause code bloat.
If it is in fact correct that the alarm mechanism in this case is not tied
to the fan controller, using the gpio-fan driver is ok. However, we need to
state and check in the code that _some_ property is mandatory. A driver with
only optional properties doesn't make sense.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT
Date: Wed, 25 Feb 2015 06:51:29 -0800 [thread overview]
Message-ID: <54EDE171.7040403@roeck-us.net> (raw)
In-Reply-To: <20150225135015.GA17992@lunn.ch>
On 02/25/2015 05:50 AM, Andrew Lunn wrote:
>> Handle the GPIO fan alarm feature from the fan controller driver don't
>> look good either to me. This alarm mechanism is not a part of the fan
>> controller itself but rather something apart. Also I am afraid that the
>> result would really look like a hack.
>
> Hi Simon
>
> It sounds like you need to extract the alarm code from gpio-fan into a
> little library. Then put a wrapper around it to make a gpio-fan-alarm
> driver.
>
Please, the intend is to do the right thing, not to cause code bloat.
If it is in fact correct that the alarm mechanism in this case is not tied
to the fan controller, using the gpio-fan driver is ok. However, we need to
state and check in the code that _some_ property is mandatory. A driver with
only optional properties doesn't make sense.
Guenter
next prev parent reply other threads:[~2015-02-25 14:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 12:58 [lm-sensors] [PATCH] hwmon: (gpio-fan) allow to use alarm support alone from DT Simon Guinot
2015-02-23 12:58 ` Simon Guinot
2015-02-23 13:42 ` [lm-sensors] " Andrew Lunn
2015-02-23 13:42 ` Andrew Lunn
2015-02-23 14:06 ` [lm-sensors] " Guenter Roeck
2015-02-23 14:06 ` Guenter Roeck
2015-02-23 14:34 ` [lm-sensors] " Simon Guinot
2015-02-23 14:34 ` Simon Guinot
2015-02-23 14:43 ` [lm-sensors] " Guenter Roeck
2015-02-23 14:43 ` Guenter Roeck
2015-02-25 11:14 ` [lm-sensors] " Simon Guinot
2015-02-25 11:14 ` Simon Guinot
2015-02-25 13:50 ` [lm-sensors] " Andrew Lunn
2015-02-25 13:50 ` Andrew Lunn
2015-02-25 14:29 ` [lm-sensors] " Simon Guinot
2015-02-25 14:29 ` Simon Guinot
2015-02-25 14:52 ` [lm-sensors] " Guenter Roeck
2015-02-25 14:52 ` Guenter Roeck
2015-02-25 14:51 ` Guenter Roeck [this message]
2015-02-25 14:51 ` Guenter Roeck
2015-02-25 15:04 ` [lm-sensors] " Andrew Lunn
2015-02-25 15:04 ` Andrew Lunn
2015-02-25 16:20 ` [lm-sensors] " Guenter Roeck
2015-02-25 16:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EDE171.7040403@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.