* [PATCH 0/2] Staging: emxx_udc: Fix checkpatch.pl warnings @ 2015-02-20 23:21 Haneen Mohammed 2015-02-20 23:29 ` [PATCH 1/2] Staging: emxx_udc: Fix do not add new typedefs Haneen Mohammed 2015-02-20 23:32 ` [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err Haneen Mohammed 0 siblings, 2 replies; 8+ messages in thread From: Haneen Mohammed @ 2015-02-20 23:21 UTC (permalink / raw) To: outreachy-kernel This patchset fixes the following coding style issues found by checkpatch.pl: Do not add new typedefs Replace printk with pr_err Haneen Mohammed (2): Staging: emxx_udc: Fix do not add new typedefs Staging: emxx_udc: Replace printk with pr_err drivers/staging/emxx_udc/emxx_udc.c | 60 ++++++++++++++++++------------------- drivers/staging/emxx_udc/emxx_udc.h | 28 ++++++++--------- 2 files changed, 44 insertions(+), 44 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] Staging: emxx_udc: Fix do not add new typedefs 2015-02-20 23:21 [PATCH 0/2] Staging: emxx_udc: Fix checkpatch.pl warnings Haneen Mohammed @ 2015-02-20 23:29 ` Haneen Mohammed 2015-02-21 21:01 ` [Outreachy kernel] [PATCH v3 " Julia Lawall 2015-02-20 23:32 ` [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err Haneen Mohammed 1 sibling, 1 reply; 8+ messages in thread From: Haneen Mohammed @ 2015-02-20 23:29 UTC (permalink / raw) To: outreachy-kernel; +Cc: Haneen Mohammed This patch fixes the following checkpatch.pl warning:"do not add new typedefs". Remove typedefs keyword and rename structs identifiers appropriately. Update related files. Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> --- v2: Removed typedefs appropriately and chenged related file. v3: Removed all typedefs. drivers/staging/emxx_udc/emxx_udc.c | 60 ++++++++++++++++++------------------- drivers/staging/emxx_udc/emxx_udc.h | 26 ++++++++-------- 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 82c492f..98093b9 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -201,7 +201,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc) u32 num, buf_type; u32 data, last_ram_adr, use_ram_size; - PT_EP_REGS p_ep_regs; + struct ep_regs *p_ep_regs; last_ram_adr = (D_RAM_SIZE_CTRL / sizeof(u32)) * 2; use_ram_size = 0; @@ -394,7 +394,7 @@ static void _nbu2ss_ep_dma_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) { u32 num; u32 data; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (udc->vbus_active == 0) return; /* VBUS OFF */ @@ -425,7 +425,7 @@ static void _nbu2ss_ep_dma_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) /* Abort DMA */ static void _nbu2ss_ep_dma_abort(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) { - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; _nbu2ss_bitclr(&preg->EP_DCR[ep->epnum-1].EP_DCR1, DCR1_EPn_REQEN); mdelay(DMA_DISABLE_TIME); /* DCR1_EPn_REQEN Clear */ @@ -443,7 +443,7 @@ static void _nbu2ss_ep_in_end( { u32 data; u32 num; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (length >= sizeof(u32)) return; @@ -567,7 +567,7 @@ static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) u32 i; int nret = 0; u32 iWordLength = 0; - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; /*------------------------------------------------------------*/ /* Read Length */ @@ -592,8 +592,8 @@ static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) { u32 i; u32 iReadSize = 0; - USB_REG_ACCESS Temp32; - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; + struct usb_reg_access Temp32; + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; if ((0 < length) && (length < sizeof(u32))) { Temp32.dw = _nbu2ss_readl(&udc->p_regs->EP0_READ); @@ -613,7 +613,7 @@ static int EP0_in_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) u32 iMaxLength = EP0_PACKETSIZE; u32 iWordLength = 0; u32 iWriteLength = 0; - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; /*------------------------------------------------------------*/ /* Transfer Length */ @@ -638,8 +638,8 @@ static int EP0_in_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) static int EP0_in_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 iRemainSize) { u32 i; - USB_REG_ACCESS Temp32; - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; + struct usb_reg_access Temp32; + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; if ((0 < iRemainSize) && (iRemainSize < sizeof(u32))) { for (i = 0 ; i < iRemainSize ; i++) @@ -840,7 +840,7 @@ static int _nbu2ss_out_dma( u32 burst = 1; u32 data; int result = -EINVAL; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (req->dma_flag) return 1; /* DMA is forwarded */ @@ -900,10 +900,10 @@ static int _nbu2ss_epn_out_pio( u32 i; u32 data; u32 iWordLength; - USB_REG_ACCESS Temp32; - USB_REG_ACCESS *pBuf32; + struct usb_reg_access Temp32; + struct usb_reg_access *pBuf32; int result = 0; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (req->dma_flag) return 1; /* DMA is forwarded */ @@ -912,7 +912,7 @@ static int _nbu2ss_epn_out_pio( return 0; pBuffer = (u8 *)req->req.buf; - pBuf32 = (USB_REG_ACCESS *)(pBuffer + req->req.actual); + pBuf32 = (struct usb_reg_access *)(pBuffer + req->req.actual); iWordLength = length / sizeof(u32); if (iWordLength > 0) { @@ -988,7 +988,7 @@ static int _nbu2ss_epn_out_transfer( u32 num; u32 iRecvLength; int result = 1; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (ep->epnum == 0) return -EINVAL; @@ -1051,7 +1051,7 @@ static int _nbu2ss_in_dma( u32 iWriteLength; u32 data; int result = -EINVAL; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (req->dma_flag) return 1; /* DMA is forwarded */ @@ -1123,17 +1123,17 @@ static int _nbu2ss_epn_in_pio( u32 i; u32 data; u32 iWordLength; - USB_REG_ACCESS Temp32; - USB_REG_ACCESS *pBuf32 = NULL; + struct usb_reg_access Temp32; + struct usb_reg_access *pBuf32 = NULL; int result = 0; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (req->dma_flag) return 1; /* DMA is forwarded */ if (length > 0) { pBuffer = (u8 *)req->req.buf; - pBuf32 = (USB_REG_ACCESS *)(pBuffer + req->req.actual); + pBuf32 = (struct usb_reg_access *)(pBuffer + req->req.actual); iWordLength = length / sizeof(u32); if (iWordLength > 0) { @@ -1347,7 +1347,7 @@ static void _nbu2ss_set_endpoint_stall( u8 num, epnum; u32 data; struct nbu2ss_ep *ep; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if ((ep_adrs == 0) || (ep_adrs == 0x80)) { if (bstall) { @@ -1471,7 +1471,7 @@ static int _nbu2ss_get_ep_stall(struct nbu2ss_udc *udc, u8 ep_adrs) { u8 epnum; u32 data = 0, bit_data; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; epnum = ep_adrs & ~USB_ENDPOINT_DIR_MASK; if (epnum == 0) { @@ -1566,7 +1566,7 @@ static void _nbu2ss_epn_set_stall( u32 regdata; int limit_cnt = 0; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (ep->direct == USB_DIR_IN) { for (limit_cnt = 0 @@ -1994,7 +1994,7 @@ static inline void _nbu2ss_epn_in_int( int result = 0; u32 status; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (req->dma_flag) return; /* DMA is forwarded */ @@ -2090,7 +2090,7 @@ static inline void _nbu2ss_epn_out_dma_int( u32 num; u32 dmacnt, ep_dmacnt; u32 mpkt; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; num = ep->epnum - 1; @@ -2293,7 +2293,7 @@ static int _nbu2ss_pullup(struct nbu2ss_udc *udc, int is_on) /*-------------------------------------------------------------------------*/ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) { - PT_FC_REGS p = udc->p_regs; + struct fc_regs *p = udc->p_regs; if (udc->vbus_active == 0) return; @@ -2536,7 +2536,7 @@ static irqreturn_t _nbu2ss_udc_irq(int irq, void *_udc) u32 epnum, int_bit; struct nbu2ss_udc *udc = (struct nbu2ss_udc *)_udc; - PT_FC_REGS preg = udc->p_regs; + struct fc_regs *preg = udc->p_regs; if (gpio_get_value(VBUS_VALUE) == 0) { _nbu2ss_writel(&preg->USB_INT_STA, ~USB_INT_STA_RW); @@ -2944,7 +2944,7 @@ static int nbu2ss_ep_fifo_status(struct usb_ep *_ep) struct nbu2ss_ep *ep; struct nbu2ss_udc *udc; unsigned long flags; - PT_FC_REGS preg; + struct fc_regs *preg; /* INFO("=== %s()\n", __func__); */ @@ -3341,7 +3341,7 @@ static int nbu2ss_drv_probe(struct platform_device *pdev) 0, driver_name, udc); /* IO Memory */ - udc->p_regs = (PT_FC_REGS)mmio_base; + udc->p_regs = (struct fc_regs *)mmio_base; /* USB Function Controller Interrupt */ if (status != 0) { diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h index ee1b80d..c1f98b3 100644 --- a/drivers/staging/emxx_udc/emxx_udc.h +++ b/drivers/staging/emxx_udc/emxx_udc.h @@ -474,8 +474,8 @@ /*===========================================================================*/ /* Struct */ -/*------- T_EP_REGS */ -typedef struct _T_EP_REGS { +/*------- ep_regs */ +struct ep_regs { u32 EP_CONTROL; /* EP Control */ u32 EP_STATUS; /* EP Status */ u32 EP_INT_ENA; /* EP Interrupt Enable */ @@ -484,18 +484,18 @@ typedef struct _T_EP_REGS { u32 EP_LEN_DCNT; /* EP Length & DMA count */ u32 EP_READ; /* EP Read */ u32 EP_WRITE; /* EP Write */ -} T_EP_REGS, *PT_EP_REGS; +}; -/*------- T_EP_DCR */ -typedef struct _T_EP_DCR { +/*------- ep_dcr */ +struct ep_dcr { u32 EP_DCR1; /* EP_DCR1 */ u32 EP_DCR2; /* EP_DCR2 */ u32 EP_TADR; /* EP_TADR */ u32 Reserved; /* Reserved */ -} T_EP_DCR, *PT_EP_DCR; +}; /*------- Function Registers */ -typedef struct _T_FC_REGS { +struct fc_regs { u32 USB_CONTROL; /* (0x0000) USB Control */ u32 USB_STATUS; /* (0x0004) USB Status */ u32 USB_ADDRESS; /* (0x0008) USB Address */ @@ -513,7 +513,7 @@ typedef struct _T_FC_REGS { u32 EP0_READ; /* (0x0038) EP0 Read */ u32 EP0_WRITE; /* (0x003C) EP0 Write */ - T_EP_REGS EP_REGS[REG_EP_NUM]; /* Endpoint Register */ + struct ep_regs EP_REGS[REG_EP_NUM]; /* Endpoint Register */ u8 Reserved220[0x1000-0x220]; /* (0x0220:0x0FFF) Reserved */ @@ -531,11 +531,11 @@ typedef struct _T_FC_REGS { u8 Reserved1028[0x110-0x28]; /* (0x1028:0x110F) Reserved */ - T_EP_DCR EP_DCR[REG_EP_NUM]; /* */ + struct ep_dcr EP_DCR[REG_EP_NUM]; /* */ u8 Reserved1200[0x1000-0x200]; /* Reserved */ -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; +} __attribute__ ((aligned(32))); @@ -632,16 +632,16 @@ struct nbu2ss_udc { u32 curr_config; /* Current Configuration Number */ - PT_FC_REGS p_regs; + struct fc_regs *p_regs; }; /* USB register access structure */ -typedef volatile union { +volatile union usb_reg_access { struct { unsigned char DATA[4]; } byte; unsigned int dw; -} USB_REG_ACCESS; +}; /*-------------------------------------------------------------------------*/ #define ERR(stuff...) printk(KERN_ERR "udc: " stuff) -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH v3 1/2] Staging: emxx_udc: Fix do not add new typedefs 2015-02-20 23:29 ` [PATCH 1/2] Staging: emxx_udc: Fix do not add new typedefs Haneen Mohammed @ 2015-02-21 21:01 ` Julia Lawall 0 siblings, 0 replies; 8+ messages in thread From: Julia Lawall @ 2015-02-21 21:01 UTC (permalink / raw) To: Haneen Mohammed; +Cc: outreachy-kernel On Sat, 21 Feb 2015, Haneen Mohammed wrote: > This patch fixes the following checkpatch.pl warning:"do not add new typedefs". > Remove typedefs keyword and rename structs identifiers appropriately. > Update related files. When you send a revision of a patch, you have to send revisions of all of the patches in the series, all labelled with the current version number. If some don't change, then just put a note below the --- saying that nothing has changed. julia > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> > --- > v2: Removed typedefs appropriately and chenged related file. > v3: Removed all typedefs. > > drivers/staging/emxx_udc/emxx_udc.c | 60 ++++++++++++++++++------------------- > drivers/staging/emxx_udc/emxx_udc.h | 26 ++++++++-------- > 2 files changed, 43 insertions(+), 43 deletions(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c > index 82c492f..98093b9 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.c > +++ b/drivers/staging/emxx_udc/emxx_udc.c > @@ -201,7 +201,7 @@ static u32 _nbu2ss_get_begin_ram_address(struct nbu2ss_udc *udc) > u32 num, buf_type; > u32 data, last_ram_adr, use_ram_size; > > - PT_EP_REGS p_ep_regs; > + struct ep_regs *p_ep_regs; > > last_ram_adr = (D_RAM_SIZE_CTRL / sizeof(u32)) * 2; > use_ram_size = 0; > @@ -394,7 +394,7 @@ static void _nbu2ss_ep_dma_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) > { > u32 num; > u32 data; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (udc->vbus_active == 0) > return; /* VBUS OFF */ > @@ -425,7 +425,7 @@ static void _nbu2ss_ep_dma_exit(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) > /* Abort DMA */ > static void _nbu2ss_ep_dma_abort(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) > { > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > _nbu2ss_bitclr(&preg->EP_DCR[ep->epnum-1].EP_DCR1, DCR1_EPn_REQEN); > mdelay(DMA_DISABLE_TIME); /* DCR1_EPn_REQEN Clear */ > @@ -443,7 +443,7 @@ static void _nbu2ss_ep_in_end( > { > u32 data; > u32 num; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (length >= sizeof(u32)) > return; > @@ -567,7 +567,7 @@ static int EP0_out_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) > u32 i; > int nret = 0; > u32 iWordLength = 0; > - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; > + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; > > /*------------------------------------------------------------*/ > /* Read Length */ > @@ -592,8 +592,8 @@ static int EP0_out_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) > { > u32 i; > u32 iReadSize = 0; > - USB_REG_ACCESS Temp32; > - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; > + struct usb_reg_access Temp32; > + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; > > if ((0 < length) && (length < sizeof(u32))) { > Temp32.dw = _nbu2ss_readl(&udc->p_regs->EP0_READ); > @@ -613,7 +613,7 @@ static int EP0_in_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) > u32 iMaxLength = EP0_PACKETSIZE; > u32 iWordLength = 0; > u32 iWriteLength = 0; > - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; > + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; > > /*------------------------------------------------------------*/ > /* Transfer Length */ > @@ -638,8 +638,8 @@ static int EP0_in_PIO(struct nbu2ss_udc *udc, u8 *pBuf, u32 length) > static int EP0_in_OverBytes(struct nbu2ss_udc *udc, u8 *pBuf, u32 iRemainSize) > { > u32 i; > - USB_REG_ACCESS Temp32; > - USB_REG_ACCESS *pBuf32 = (USB_REG_ACCESS *)pBuf; > + struct usb_reg_access Temp32; > + struct usb_reg_access *pBuf32 = (struct usb_reg_access *)pBuf; > > if ((0 < iRemainSize) && (iRemainSize < sizeof(u32))) { > for (i = 0 ; i < iRemainSize ; i++) > @@ -840,7 +840,7 @@ static int _nbu2ss_out_dma( > u32 burst = 1; > u32 data; > int result = -EINVAL; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (req->dma_flag) > return 1; /* DMA is forwarded */ > @@ -900,10 +900,10 @@ static int _nbu2ss_epn_out_pio( > u32 i; > u32 data; > u32 iWordLength; > - USB_REG_ACCESS Temp32; > - USB_REG_ACCESS *pBuf32; > + struct usb_reg_access Temp32; > + struct usb_reg_access *pBuf32; > int result = 0; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (req->dma_flag) > return 1; /* DMA is forwarded */ > @@ -912,7 +912,7 @@ static int _nbu2ss_epn_out_pio( > return 0; > > pBuffer = (u8 *)req->req.buf; > - pBuf32 = (USB_REG_ACCESS *)(pBuffer + req->req.actual); > + pBuf32 = (struct usb_reg_access *)(pBuffer + req->req.actual); > > iWordLength = length / sizeof(u32); > if (iWordLength > 0) { > @@ -988,7 +988,7 @@ static int _nbu2ss_epn_out_transfer( > u32 num; > u32 iRecvLength; > int result = 1; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (ep->epnum == 0) > return -EINVAL; > @@ -1051,7 +1051,7 @@ static int _nbu2ss_in_dma( > u32 iWriteLength; > u32 data; > int result = -EINVAL; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (req->dma_flag) > return 1; /* DMA is forwarded */ > @@ -1123,17 +1123,17 @@ static int _nbu2ss_epn_in_pio( > u32 i; > u32 data; > u32 iWordLength; > - USB_REG_ACCESS Temp32; > - USB_REG_ACCESS *pBuf32 = NULL; > + struct usb_reg_access Temp32; > + struct usb_reg_access *pBuf32 = NULL; > int result = 0; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (req->dma_flag) > return 1; /* DMA is forwarded */ > > if (length > 0) { > pBuffer = (u8 *)req->req.buf; > - pBuf32 = (USB_REG_ACCESS *)(pBuffer + req->req.actual); > + pBuf32 = (struct usb_reg_access *)(pBuffer + req->req.actual); > > iWordLength = length / sizeof(u32); > if (iWordLength > 0) { > @@ -1347,7 +1347,7 @@ static void _nbu2ss_set_endpoint_stall( > u8 num, epnum; > u32 data; > struct nbu2ss_ep *ep; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if ((ep_adrs == 0) || (ep_adrs == 0x80)) { > if (bstall) { > @@ -1471,7 +1471,7 @@ static int _nbu2ss_get_ep_stall(struct nbu2ss_udc *udc, u8 ep_adrs) > { > u8 epnum; > u32 data = 0, bit_data; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > epnum = ep_adrs & ~USB_ENDPOINT_DIR_MASK; > if (epnum == 0) { > @@ -1566,7 +1566,7 @@ static void _nbu2ss_epn_set_stall( > u32 regdata; > int limit_cnt = 0; > > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (ep->direct == USB_DIR_IN) { > for (limit_cnt = 0 > @@ -1994,7 +1994,7 @@ static inline void _nbu2ss_epn_in_int( > int result = 0; > u32 status; > > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (req->dma_flag) > return; /* DMA is forwarded */ > @@ -2090,7 +2090,7 @@ static inline void _nbu2ss_epn_out_dma_int( > u32 num; > u32 dmacnt, ep_dmacnt; > u32 mpkt; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > num = ep->epnum - 1; > > @@ -2293,7 +2293,7 @@ static int _nbu2ss_pullup(struct nbu2ss_udc *udc, int is_on) > /*-------------------------------------------------------------------------*/ > static void _nbu2ss_fifo_flush(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep) > { > - PT_FC_REGS p = udc->p_regs; > + struct fc_regs *p = udc->p_regs; > > if (udc->vbus_active == 0) > return; > @@ -2536,7 +2536,7 @@ static irqreturn_t _nbu2ss_udc_irq(int irq, void *_udc) > u32 epnum, int_bit; > > struct nbu2ss_udc *udc = (struct nbu2ss_udc *)_udc; > - PT_FC_REGS preg = udc->p_regs; > + struct fc_regs *preg = udc->p_regs; > > if (gpio_get_value(VBUS_VALUE) == 0) { > _nbu2ss_writel(&preg->USB_INT_STA, ~USB_INT_STA_RW); > @@ -2944,7 +2944,7 @@ static int nbu2ss_ep_fifo_status(struct usb_ep *_ep) > struct nbu2ss_ep *ep; > struct nbu2ss_udc *udc; > unsigned long flags; > - PT_FC_REGS preg; > + struct fc_regs *preg; > > /* INFO("=== %s()\n", __func__); */ > > @@ -3341,7 +3341,7 @@ static int nbu2ss_drv_probe(struct platform_device *pdev) > 0, driver_name, udc); > > /* IO Memory */ > - udc->p_regs = (PT_FC_REGS)mmio_base; > + udc->p_regs = (struct fc_regs *)mmio_base; > > /* USB Function Controller Interrupt */ > if (status != 0) { > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h > index ee1b80d..c1f98b3 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.h > +++ b/drivers/staging/emxx_udc/emxx_udc.h > @@ -474,8 +474,8 @@ > > /*===========================================================================*/ > /* Struct */ > -/*------- T_EP_REGS */ > -typedef struct _T_EP_REGS { > +/*------- ep_regs */ > +struct ep_regs { > u32 EP_CONTROL; /* EP Control */ > u32 EP_STATUS; /* EP Status */ > u32 EP_INT_ENA; /* EP Interrupt Enable */ > @@ -484,18 +484,18 @@ typedef struct _T_EP_REGS { > u32 EP_LEN_DCNT; /* EP Length & DMA count */ > u32 EP_READ; /* EP Read */ > u32 EP_WRITE; /* EP Write */ > -} T_EP_REGS, *PT_EP_REGS; > +}; > > -/*------- T_EP_DCR */ > -typedef struct _T_EP_DCR { > +/*------- ep_dcr */ > +struct ep_dcr { > u32 EP_DCR1; /* EP_DCR1 */ > u32 EP_DCR2; /* EP_DCR2 */ > u32 EP_TADR; /* EP_TADR */ > u32 Reserved; /* Reserved */ > -} T_EP_DCR, *PT_EP_DCR; > +}; > > /*------- Function Registers */ > -typedef struct _T_FC_REGS { > +struct fc_regs { > u32 USB_CONTROL; /* (0x0000) USB Control */ > u32 USB_STATUS; /* (0x0004) USB Status */ > u32 USB_ADDRESS; /* (0x0008) USB Address */ > @@ -513,7 +513,7 @@ typedef struct _T_FC_REGS { > u32 EP0_READ; /* (0x0038) EP0 Read */ > u32 EP0_WRITE; /* (0x003C) EP0 Write */ > > - T_EP_REGS EP_REGS[REG_EP_NUM]; /* Endpoint Register */ > + struct ep_regs EP_REGS[REG_EP_NUM]; /* Endpoint Register */ > > u8 Reserved220[0x1000-0x220]; /* (0x0220:0x0FFF) Reserved */ > > @@ -531,11 +531,11 @@ typedef struct _T_FC_REGS { > > u8 Reserved1028[0x110-0x28]; /* (0x1028:0x110F) Reserved */ > > - T_EP_DCR EP_DCR[REG_EP_NUM]; /* */ > + struct ep_dcr EP_DCR[REG_EP_NUM]; /* */ > > u8 Reserved1200[0x1000-0x200]; /* Reserved */ > > -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; > +} __attribute__ ((aligned(32))); > > > > @@ -632,16 +632,16 @@ struct nbu2ss_udc { > > u32 curr_config; /* Current Configuration Number */ > > - PT_FC_REGS p_regs; > + struct fc_regs *p_regs; > }; > > /* USB register access structure */ > -typedef volatile union { > +volatile union usb_reg_access { > struct { > unsigned char DATA[4]; > } byte; > unsigned int dw; > -} USB_REG_ACCESS; > +}; > > /*-------------------------------------------------------------------------*/ > #define ERR(stuff...) printk(KERN_ERR "udc: " stuff) > -- > 1.9.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/311e630256ddb78958e41c7f0fd1f776e6d523c4.1424473862.git.hamohammed.sa%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err 2015-02-20 23:21 [PATCH 0/2] Staging: emxx_udc: Fix checkpatch.pl warnings Haneen Mohammed 2015-02-20 23:29 ` [PATCH 1/2] Staging: emxx_udc: Fix do not add new typedefs Haneen Mohammed @ 2015-02-20 23:32 ` Haneen Mohammed 2015-02-21 20:59 ` [Outreachy kernel] " Julia Lawall 1 sibling, 1 reply; 8+ messages in thread From: Haneen Mohammed @ 2015-02-20 23:32 UTC (permalink / raw) To: outreachy-kernel; +Cc: Haneen Mohammed This patch replaces printk(KERN_ERR .. with pr_err, to fix the following checkpatch.pl warning: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> --- drivers/staging/emxx_udc/emxx_udc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h index c1f98b3..c3fd7f6 100644 --- a/drivers/staging/emxx_udc/emxx_udc.h +++ b/drivers/staging/emxx_udc/emxx_udc.h @@ -644,6 +644,6 @@ volatile union usb_reg_access { }; /*-------------------------------------------------------------------------*/ -#define ERR(stuff...) printk(KERN_ERR "udc: " stuff) +#define ERR(stuff...) pr_err("udc: " stuff) #endif /* _LINUX_EMXX_H */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err 2015-02-20 23:32 ` [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err Haneen Mohammed @ 2015-02-21 20:59 ` Julia Lawall 2015-02-24 23:25 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Julia Lawall @ 2015-02-21 20:59 UTC (permalink / raw) To: Haneen Mohammed; +Cc: outreachy-kernel On Sat, 21 Feb 2015, Haneen Mohammed wrote: > This patch replaces printk(KERN_ERR .. with pr_err, to fix the following > checkpatch.pl warning: > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> > --- > drivers/staging/emxx_udc/emxx_udc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h > index c1f98b3..c3fd7f6 100644 > --- a/drivers/staging/emxx_udc/emxx_udc.h > +++ b/drivers/staging/emxx_udc/emxx_udc.h > @@ -644,6 +644,6 @@ volatile union usb_reg_access { > }; > > /*-------------------------------------------------------------------------*/ > -#define ERR(stuff...) printk(KERN_ERR "udc: " stuff) > +#define ERR(stuff...) pr_err("udc: " stuff) A better approach would be to remove ERR completely, and see which standard kernel debugging function (pr_err?, dev_err?) could be used at each point. julia ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err 2015-02-21 20:59 ` [Outreachy kernel] " Julia Lawall @ 2015-02-24 23:25 ` Greg KH 2015-02-25 16:20 ` Haneen Mohammed 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2015-02-24 23:25 UTC (permalink / raw) To: Julia Lawall; +Cc: Haneen Mohammed, outreachy-kernel On Sat, Feb 21, 2015 at 09:59:55PM +0100, Julia Lawall wrote: > On Sat, 21 Feb 2015, Haneen Mohammed wrote: > > > This patch replaces printk(KERN_ERR .. with pr_err, to fix the following > > checkpatch.pl warning: > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then > > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> > > --- > > drivers/staging/emxx_udc/emxx_udc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h > > index c1f98b3..c3fd7f6 100644 > > --- a/drivers/staging/emxx_udc/emxx_udc.h > > +++ b/drivers/staging/emxx_udc/emxx_udc.h > > @@ -644,6 +644,6 @@ volatile union usb_reg_access { > > }; > > > > /*-------------------------------------------------------------------------*/ > > -#define ERR(stuff...) printk(KERN_ERR "udc: " stuff) > > +#define ERR(stuff...) pr_err("udc: " stuff) > > A better approach would be to remove ERR completely, and see which > standard kernel debugging function (pr_err?, dev_err?) could be used at > each point. Ideally dev_err() should be used, just drop ERR() entirely please. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err 2015-02-24 23:25 ` Greg KH @ 2015-02-25 16:20 ` Haneen Mohammed 2015-02-25 16:54 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Haneen Mohammed @ 2015-02-25 16:20 UTC (permalink / raw) To: outreachy-kernel; +Cc: Greg KH On Tue, Feb 24, 2015 at 03:25:29PM -0800, Greg KH wrote: > On Sat, Feb 21, 2015 at 09:59:55PM +0100, Julia Lawall wrote: > > On Sat, 21 Feb 2015, Haneen Mohammed wrote: > > > > > This patch replaces printk(KERN_ERR .. with pr_err, to fix the following > > > checkpatch.pl warning: > > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then > > > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > > > > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> > > > --- > > > drivers/staging/emxx_udc/emxx_udc.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h > > > index c1f98b3..c3fd7f6 100644 > > > --- a/drivers/staging/emxx_udc/emxx_udc.h > > > +++ b/drivers/staging/emxx_udc/emxx_udc.h > > > @@ -644,6 +644,6 @@ volatile union usb_reg_access { > > > }; > > > > > > /*-------------------------------------------------------------------------*/ > > > -#define ERR(stuff...) printk(KERN_ERR "udc: " stuff) > > > +#define ERR(stuff...) pr_err("udc: " stuff) > > > > A better approach would be to remove ERR completely, and see which > > standard kernel debugging function (pr_err?, dev_err?) could be used at > > each point. > > Ideally dev_err() should be used, just drop ERR() entirely please. > > thanks, > > greg k-h I did drop ERR() macro and sent it as new patchset. the last revision was "[PATCH v5 0/6] Staging: emxx_udc: Fix checkpatch.pl warnings" Thanks, Haneen ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err 2015-02-25 16:20 ` Haneen Mohammed @ 2015-02-25 16:54 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2015-02-25 16:54 UTC (permalink / raw) To: Haneen Mohammed; +Cc: outreachy-kernel On Wed, Feb 25, 2015 at 07:20:28PM +0300, Haneen Mohammed wrote: > On Tue, Feb 24, 2015 at 03:25:29PM -0800, Greg KH wrote: > > On Sat, Feb 21, 2015 at 09:59:55PM +0100, Julia Lawall wrote: > > > On Sat, 21 Feb 2015, Haneen Mohammed wrote: > > > > > > > This patch replaces printk(KERN_ERR .. with pr_err, to fix the following > > > > checkpatch.pl warning: > > > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then > > > > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > > > > > > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com> > > > > --- > > > > drivers/staging/emxx_udc/emxx_udc.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h > > > > index c1f98b3..c3fd7f6 100644 > > > > --- a/drivers/staging/emxx_udc/emxx_udc.h > > > > +++ b/drivers/staging/emxx_udc/emxx_udc.h > > > > @@ -644,6 +644,6 @@ volatile union usb_reg_access { > > > > }; > > > > > > > > /*-------------------------------------------------------------------------*/ > > > > -#define ERR(stuff...) printk(KERN_ERR "udc: " stuff) > > > > +#define ERR(stuff...) pr_err("udc: " stuff) > > > > > > A better approach would be to remove ERR completely, and see which > > > standard kernel debugging function (pr_err?, dev_err?) could be used at > > > each point. > > > > Ideally dev_err() should be used, just drop ERR() entirely please. > > > > thanks, > > > > greg k-h > > I did drop ERR() macro and sent it as new patchset. the last revision > was "[PATCH v5 0/6] Staging: emxx_udc: Fix checkpatch.pl warnings" Great, thanks for this, still sifting through the submissions, in order, so I hadn't gotten to these yet. greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-02-25 16:54 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-02-20 23:21 [PATCH 0/2] Staging: emxx_udc: Fix checkpatch.pl warnings Haneen Mohammed 2015-02-20 23:29 ` [PATCH 1/2] Staging: emxx_udc: Fix do not add new typedefs Haneen Mohammed 2015-02-21 21:01 ` [Outreachy kernel] [PATCH v3 " Julia Lawall 2015-02-20 23:32 ` [PATCH 2/2] Staging: emxx_udc: Replace printk with pr_err Haneen Mohammed 2015-02-21 20:59 ` [Outreachy kernel] " Julia Lawall 2015-02-24 23:25 ` Greg KH 2015-02-25 16:20 ` Haneen Mohammed 2015-02-25 16:54 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.