All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/4] Staging: lustre: lnet: klnds: socklnd: Deleted space prohibited between function name and open parenthesis
Date: Thu, 26 Feb 2015 10:16:29 -0800	[thread overview]
Message-ID: <20150226181629.GA23249@kroah.com> (raw)
In-Reply-To: <1424446070-14232-1-git-send-email-aysemelikeyurtoglu@gmail.com>

On Fri, Feb 20, 2015 at 05:27:47PM +0200, Melike Yurtoglu wrote:
> WARNING: space prohibited between function name and open parenthesis '('
> checkpatch.pl warning in socklnd.c
> 
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
> ---
>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    | 448 ++++++++++-----------
>  1 file changed, 224 insertions(+), 224 deletions(-)

This patch breaks the build, which implies that you never even test
built it :(

Please be more careful, I can't take anything in this series now.
Please fix up, test it, and resend.

thanks,

greg k-h


      parent reply	other threads:[~2015-02-26 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 15:27 [PATCH 1/4] Staging: lustre: lnet: klnds: socklnd: Deleted space prohibited between function name and open parenthesis Melike Yurtoglu
2015-02-20 15:27 ` [PATCH 2/4] Staging: lustre: lnet: klnds: socklnd: removed suspect code indent for conditional statements Melike Yurtoglu
2015-02-20 15:27 ` [PATCH 3/4] Staging: lustre: lnet: klnds: socklnd: Remove return in void function Melike Yurtoglu
2015-02-20 15:27 ` [PATCH 4/4] Staging: lustre: lnet: klnds: socklnd: Add blank line after declarations Melike Yurtoglu
2015-02-20 17:22   ` [Outreachy kernel] " Julia Lawall
2015-02-20 17:02 ` [Outreachy kernel] [PATCH 1/4] Staging: lustre: lnet: klnds: socklnd: Deleted space prohibited between function name and open parenthesis Jes Sorensen
2015-02-20 17:25   ` Ayşe Melike Yurtoğlu
2015-02-20 17:28     ` Jes Sorensen
2015-02-26 18:16 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150226181629.GA23249@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aysemelikeyurtoglu@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.