Re: [Outreachy kernel] [PATCH 1/4] Staging: lustre: lnet: klnds: socklnd: Deleted space prohibited between function name and open parenthesis

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 12:25, Ayşe Melike Yurtoğlu wrote:
> I will pay much more attention to the commit messages and subject line.I am
> using the following command while the patch series.I'm doing it wrong, I
> wonder.
> "git format-patch -n --subject-prefix="PATCH vY" --cover-letter"

That looks right - I didn't receive a 0/4 email with the set you posted.
Normally you should use the 0000-cover-letter.patch to write a small
description of the patchset that won't go into the git commit log. Like
'This set cleans up a number of cosmetic issues to XYZ. These issues
were found because of <something> ....'.

Cheers,
Jes


> Thanks
> 
> 2015-02-20 19:02 GMT+02:00 Jes Sorensen <jes.sorensen@gmail.com>:
> 
>> On 02/20/15 10:27, Melike Yurtoglu wrote:
>>> WARNING: space prohibited between function name and open parenthesis '('
>>> checkpatch.pl warning in socklnd.c
>>>
>>> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
>>> ---
>>>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    | 448
>> ++++++++++-----------
>>>  1 file changed, 224 insertions(+), 224 deletions(-)
>>
>> When posting multi patch series, you need to use a cover letter to
>> describe the reason for the patch set. Argument '--cover-letter' for
>> 'git format-patch'
>>
>> In addition, please try to write a human patch description for each
>> commit rather than just paste in the automated checkpatch output.
>> Something like:
>>
>> "Remove unnecessary space between function name and opening parenthesis.
>> That was found by running checkpatch.
>>
>> Cheers,
>> Jes
>>
>>
>>> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>> b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>>> index 5956dba..aac3a7d 100644
>>> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>>> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
>>> @@ -65,15 +65,15 @@ ksocknal_ip2iface(lnet_ni_t *ni, __u32 ip)
>>>  }
>>>
>>>  static ksock_route_t *
>>> -ksocknal_create_route (__u32 ipaddr, int port)
>>> +ksocknal_create_route(__u32 ipaddr, int port)
>>>  {
>>>       ksock_route_t *route;
>>>
>>> -     LIBCFS_ALLOC (route, sizeof (*route));
>>> +     LIBCFS_ALLOC(route, sizeof(*route));
>>>       if (route == NULL)
>>>               return NULL;
>>>
>>> -     atomic_set (&route->ksnr_refcount, 1);
>>> +     atomic_set(&route->ksnr_refcount, 1);
>>>       route->ksnr_peer = NULL;
>>>       route->ksnr_retry_interval = 0;  /* OK to connect at any time */
>>>       route->ksnr_ipaddr = ipaddr;
>>> @@ -89,43 +89,43 @@ ksocknal_create_route (__u32 ipaddr, int port)
>>>  }
>>
>>
>