Re: [Outreachy kernel] [PATCH 1/4] Staging: lustre: lnet: klnds: socklnd: Deleted space prohibited between function name and open parenthesis

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 10:27, Melike Yurtoglu wrote:
> WARNING: space prohibited between function name and open parenthesis '('
> checkpatch.pl warning in socklnd.c
> 
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
> ---
>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    | 448 ++++++++++-----------
>  1 file changed, 224 insertions(+), 224 deletions(-)

When posting multi patch series, you need to use a cover letter to
describe the reason for the patch set. Argument '--cover-letter' for
'git format-patch'

In addition, please try to write a human patch description for each
commit rather than just paste in the automated checkpatch output.
Something like:

"Remove unnecessary space between function name and opening parenthesis.
That was found by running checkpatch.

Cheers,
Jes


> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> index 5956dba..aac3a7d 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> @@ -65,15 +65,15 @@ ksocknal_ip2iface(lnet_ni_t *ni, __u32 ip)
>  }
>  
>  static ksock_route_t *
> -ksocknal_create_route (__u32 ipaddr, int port)
> +ksocknal_create_route(__u32 ipaddr, int port)
>  {
>  	ksock_route_t *route;
>  
> -	LIBCFS_ALLOC (route, sizeof (*route));
> +	LIBCFS_ALLOC(route, sizeof(*route));
>  	if (route == NULL)
>  		return NULL;
>  
> -	atomic_set (&route->ksnr_refcount, 1);
> +	atomic_set(&route->ksnr_refcount, 1);
>  	route->ksnr_peer = NULL;
>  	route->ksnr_retry_interval = 0;	 /* OK to connect at any time */
>  	route->ksnr_ipaddr = ipaddr;
> @@ -89,43 +89,43 @@ ksocknal_create_route (__u32 ipaddr, int port)
>  }