From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0
Date: Mon, 2 Mar 2015 13:16:51 +0100 [thread overview]
Message-ID: <20150302121651.GC12040@redhat.com> (raw)
In-Reply-To: <20150302125655.50a9063a.cornelia.huck@de.ibm.com>
On Mon, Mar 02, 2015 at 12:56:55PM +0100, Cornelia Huck wrote:
> On Mon, 2 Mar 2015 12:40:28 +0100
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > virtio 1.0 config space is in LE format for all
> > devices, use modern wrappers when accessed through
> > the 1.0 BAR.
> >
> > Reported-by: Rusty Russell <rusty@rustcorp.com.au>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/virtio/virtio-pci.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Not that I'm deeply familiar with pci :), but this looks good to me.
>
> (This is on top of your pci branch, btw?)
virtio 1.0 branch
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0
Date: Mon, 2 Mar 2015 13:16:51 +0100 [thread overview]
Message-ID: <20150302121651.GC12040@redhat.com> (raw)
In-Reply-To: <20150302125655.50a9063a.cornelia.huck@de.ibm.com>
On Mon, Mar 02, 2015 at 12:56:55PM +0100, Cornelia Huck wrote:
> On Mon, 2 Mar 2015 12:40:28 +0100
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > virtio 1.0 config space is in LE format for all
> > devices, use modern wrappers when accessed through
> > the 1.0 BAR.
> >
> > Reported-by: Rusty Russell <rusty@rustcorp.com.au>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/virtio/virtio-pci.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Not that I'm deeply familiar with pci :), but this looks good to me.
>
> (This is on top of your pci branch, btw?)
virtio 1.0 branch
next prev parent reply other threads:[~2015-03-02 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 11:40 [PATCH 1/2] virtio: add modern config accessors Michael S. Tsirkin
2015-03-02 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-02 11:40 ` [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0 Michael S. Tsirkin
2015-03-02 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-02 11:56 ` Cornelia Huck
2015-03-02 11:56 ` [Qemu-devel] " Cornelia Huck
2015-03-02 12:16 ` Michael S. Tsirkin [this message]
2015-03-02 12:16 ` Michael S. Tsirkin
2015-03-04 0:36 ` Rusty Russell
2015-03-04 0:36 ` [Qemu-devel] " Rusty Russell
2015-03-04 10:14 ` Michael S. Tsirkin
2015-03-04 10:14 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-05 0:13 ` Rusty Russell
2015-03-05 0:13 ` [Qemu-devel] " Rusty Russell
2015-03-02 11:55 ` [PATCH 1/2] virtio: add modern config accessors Cornelia Huck
2015-03-02 11:55 ` [Qemu-devel] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302121651.GC12040@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.