From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0
Date: Wed, 4 Mar 2015 11:14:10 +0100 [thread overview]
Message-ID: <20150304101410.GA26213@redhat.com> (raw)
In-Reply-To: <87ioehk39j.fsf@rustcorp.com.au>
On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > virtio 1.0 config space is in LE format for all
> > devices, use modern wrappers when accessed through
> > the 1.0 BAR.
>
> Hmm, I'm not so sure about these patches. It's easy to miss the
> existence of the _modern variants, and they're 90% the same as the
> legacy variants.
>
> But as long as it's fixed...
>
> Thanks,
> Rusty.
> PS. rng, block, net and 9p virtio 1.0 seem to work OK on BE guests (LE host).
Hmm good point. What if I'll rework this to get bool legacy parameter?
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: cornelia.huck@de.ibm.com, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0
Date: Wed, 4 Mar 2015 11:14:10 +0100 [thread overview]
Message-ID: <20150304101410.GA26213@redhat.com> (raw)
In-Reply-To: <87ioehk39j.fsf@rustcorp.com.au>
On Wed, Mar 04, 2015 at 11:06:08AM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > virtio 1.0 config space is in LE format for all
> > devices, use modern wrappers when accessed through
> > the 1.0 BAR.
>
> Hmm, I'm not so sure about these patches. It's easy to miss the
> existence of the _modern variants, and they're 90% the same as the
> legacy variants.
>
> But as long as it's fixed...
>
> Thanks,
> Rusty.
> PS. rng, block, net and 9p virtio 1.0 seem to work OK on BE guests (LE host).
Hmm good point. What if I'll rework this to get bool legacy parameter?
next prev parent reply other threads:[~2015-03-04 10:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 11:40 [PATCH 1/2] virtio: add modern config accessors Michael S. Tsirkin
2015-03-02 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-02 11:40 ` [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0 Michael S. Tsirkin
2015-03-02 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-02 11:56 ` Cornelia Huck
2015-03-02 11:56 ` [Qemu-devel] " Cornelia Huck
2015-03-02 12:16 ` Michael S. Tsirkin
2015-03-02 12:16 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-04 0:36 ` Rusty Russell
2015-03-04 0:36 ` [Qemu-devel] " Rusty Russell
2015-03-04 10:14 ` Michael S. Tsirkin [this message]
2015-03-04 10:14 ` Michael S. Tsirkin
2015-03-05 0:13 ` Rusty Russell
2015-03-05 0:13 ` [Qemu-devel] " Rusty Russell
2015-03-02 11:55 ` [PATCH 1/2] virtio: add modern config accessors Cornelia Huck
2015-03-02 11:55 ` [Qemu-devel] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304101410.GA26213@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.