From: Guenter Roeck <linux@roeck-us.net>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Lee Jones <lee.jones@linaro.org>,
Wim Van Sebroeck <wim@iguana.be>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon
Date: Wed, 4 Mar 2015 09:48:33 -0800 [thread overview]
Message-ID: <20150304174826.GA5568@roeck-us.net> (raw)
In-Reply-To: <20150304150815.GG3989@piout.net>
On Wed, Mar 04, 2015 at 04:08:15PM +0100, Alexandre Belloni wrote:
> On 04/03/2015 at 06:51:51 -0800, Guenter Roeck wrote :
> > >@@ -267,7 +276,7 @@ static struct platform_driver at91wdt_driver = {
> > > .suspend = at91wdt_suspend,
> > > .resume = at91wdt_resume,
> > > .driver = {
> > >- .name = "at91_wdt",
> > >+ .name = "atmel_st_watchdog",
> >
> > If you change the driver name you also need to change the MODULE_ALIAS
> > a few lines down.
> >
> > But why change it in the first place ? Maybe that was discussed somewhere,
> > but not here where it belongs, and not in patch 0/9 either.
> >
>
> That's because it conflicts with drivers/watchdog/at91sam9_wdt.c
>
You still have to update MODULE_ALIAS (or drop it if it is not needed anymore).
Guenter
> I'm not sure that is relevant anymore as they will only be probed using
> DT now.
>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon
Date: Wed, 4 Mar 2015 09:48:33 -0800 [thread overview]
Message-ID: <20150304174826.GA5568@roeck-us.net> (raw)
In-Reply-To: <20150304150815.GG3989@piout.net>
On Wed, Mar 04, 2015 at 04:08:15PM +0100, Alexandre Belloni wrote:
> On 04/03/2015 at 06:51:51 -0800, Guenter Roeck wrote :
> > >@@ -267,7 +276,7 @@ static struct platform_driver at91wdt_driver = {
> > > .suspend = at91wdt_suspend,
> > > .resume = at91wdt_resume,
> > > .driver = {
> > >- .name = "at91_wdt",
> > >+ .name = "atmel_st_watchdog",
> >
> > If you change the driver name you also need to change the MODULE_ALIAS
> > a few lines down.
> >
> > But why change it in the first place ? Maybe that was discussed somewhere,
> > but not here where it belongs, and not in patch 0/9 either.
> >
>
> That's because it conflicts with drivers/watchdog/at91sam9_wdt.c
>
You still have to update MODULE_ALIAS (or drop it if it is not needed anymore).
Guenter
> I'm not sure that is relevant anymore as they will only be probed using
> DT now.
>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
next prev parent reply other threads:[~2015-03-04 17:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 14:21 [PATCH v3 0/9] Atmel System Timer cleanups Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 1/9] ARM: at91/dt: declare atmel,at91rm9200-st as a syscon Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 2/9] mfd: syscon: Add atmel system timer registers definition Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 15:44 ` Lee Jones
2015-03-04 15:44 ` Lee Jones
2015-03-04 15:44 ` Lee Jones
2015-03-04 14:21 ` [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:51 ` Guenter Roeck
2015-03-04 14:51 ` Guenter Roeck
2015-03-04 15:08 ` Alexandre Belloni
2015-03-04 15:08 ` Alexandre Belloni
2015-03-04 17:48 ` Guenter Roeck [this message]
2015-03-04 17:48 ` Guenter Roeck
2015-03-04 14:21 ` [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 17:17 ` Sebastian Reichel
2015-03-04 17:17 ` Sebastian Reichel
2015-03-05 15:09 ` Alexandre Belloni
2015-03-05 15:09 ` Alexandre Belloni
2015-03-05 15:09 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 5/9] ARM: at91: at91rm9200: remove deprecated arm_pm_restart Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 6/9] ARM: at91: time: move the system timer driver to drivers/clocksource Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 7/9] clocksource: atmel-st: properly initialize driver Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 8/9] clocksource: atmel-st: use syscon/regmap Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 9/9] ARM: at91: remove useless include Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304174826.GA5568@roeck-us.net \
--to=linux@roeck-us.net \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=daniel.lezcano@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.