From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Dmitry Eremin-Solenikov
<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver
Date: Thu, 5 Mar 2015 16:09:56 +0100 [thread overview]
Message-ID: <20150305150956.GT3989@piout.net> (raw)
In-Reply-To: <20150304171758.GA8717@earth>
On 04/03/2015 at 18:17:58 +0100, Sebastian Reichel wrote :
> Hi,
>
> On Wed, Mar 04, 2015 at 03:21:32PM +0100, Alexandre Belloni wrote:
> > AT91RM9200 uses the watchdog from the system timer to reset.
> > [...]
> > + regmap_write(regmap_st, AT91_ST_WDMR,
> > + AT91_ST_RSTEN | AT91_ST_EXTEN | 1);
> > + regmap_write(regmap_st, AT91_ST_CR, AT91_ST_WDRST);
> > +
> > + mdelay(2000);
>
> At pity that you have to write into two registers, otherwise you
> could have used the syscon-reboot driver.
>
Exactly what I was thinking :)
> > [...]
> > +module_platform_driver(at91rm9200_reset_driver);
>
> Apart from missing module metadata (MODULE_AUTHOR(),
> MODULE_LICENSE(), ...) the driver looks fine to me.
>
I'll add those.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Lee Jones <lee.jones@linaro.org>,
Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver
Date: Thu, 5 Mar 2015 16:09:56 +0100 [thread overview]
Message-ID: <20150305150956.GT3989@piout.net> (raw)
In-Reply-To: <20150304171758.GA8717@earth>
On 04/03/2015 at 18:17:58 +0100, Sebastian Reichel wrote :
> Hi,
>
> On Wed, Mar 04, 2015 at 03:21:32PM +0100, Alexandre Belloni wrote:
> > AT91RM9200 uses the watchdog from the system timer to reset.
> > [...]
> > + regmap_write(regmap_st, AT91_ST_WDMR,
> > + AT91_ST_RSTEN | AT91_ST_EXTEN | 1);
> > + regmap_write(regmap_st, AT91_ST_CR, AT91_ST_WDRST);
> > +
> > + mdelay(2000);
>
> At pity that you have to write into two registers, otherwise you
> could have used the syscon-reboot driver.
>
Exactly what I was thinking :)
> > [...]
> > +module_platform_driver(at91rm9200_reset_driver);
>
> Apart from missing module metadata (MODULE_AUTHOR(),
> MODULE_LICENSE(), ...) the driver looks fine to me.
>
I'll add those.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver
Date: Thu, 5 Mar 2015 16:09:56 +0100 [thread overview]
Message-ID: <20150305150956.GT3989@piout.net> (raw)
In-Reply-To: <20150304171758.GA8717@earth>
On 04/03/2015 at 18:17:58 +0100, Sebastian Reichel wrote :
> Hi,
>
> On Wed, Mar 04, 2015 at 03:21:32PM +0100, Alexandre Belloni wrote:
> > AT91RM9200 uses the watchdog from the system timer to reset.
> > [...]
> > + regmap_write(regmap_st, AT91_ST_WDMR,
> > + AT91_ST_RSTEN | AT91_ST_EXTEN | 1);
> > + regmap_write(regmap_st, AT91_ST_CR, AT91_ST_WDRST);
> > +
> > + mdelay(2000);
>
> At pity that you have to write into two registers, otherwise you
> could have used the syscon-reboot driver.
>
Exactly what I was thinking :)
> > [...]
> > +module_platform_driver(at91rm9200_reset_driver);
>
> Apart from missing module metadata (MODULE_AUTHOR(),
> MODULE_LICENSE(), ...) the driver looks fine to me.
>
I'll add those.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-05 15:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 14:21 [PATCH v3 0/9] Atmel System Timer cleanups Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 1/9] ARM: at91/dt: declare atmel,at91rm9200-st as a syscon Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 2/9] mfd: syscon: Add atmel system timer registers definition Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 15:44 ` Lee Jones
2015-03-04 15:44 ` Lee Jones
2015-03-04 15:44 ` Lee Jones
2015-03-04 14:21 ` [PATCH v3 3/9] watchdog: at91rm9200: use the system timer syscon Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:51 ` Guenter Roeck
2015-03-04 14:51 ` Guenter Roeck
2015-03-04 15:08 ` Alexandre Belloni
2015-03-04 15:08 ` Alexandre Belloni
2015-03-04 17:48 ` Guenter Roeck
2015-03-04 17:48 ` Guenter Roeck
2015-03-04 14:21 ` [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 17:17 ` Sebastian Reichel
2015-03-04 17:17 ` Sebastian Reichel
2015-03-05 15:09 ` Alexandre Belloni [this message]
2015-03-05 15:09 ` Alexandre Belloni
2015-03-05 15:09 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 5/9] ARM: at91: at91rm9200: remove deprecated arm_pm_restart Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 6/9] ARM: at91: time: move the system timer driver to drivers/clocksource Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 7/9] clocksource: atmel-st: properly initialize driver Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 8/9] clocksource: atmel-st: use syscon/regmap Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
2015-03-04 14:21 ` [PATCH v3 9/9] ARM: at91: remove useless include Alexandre Belloni
2015-03-04 14:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305150956.GT3989@piout.net \
--to=alexandre.belloni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.