From: Dan Carpenter <dan.carpenter@oracle.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: akpm@linux-foundation.org, Jonathan Corbet <corbet@lwn.net>,
Ralf Baechle <ralf@linux-mips.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Paul Bolle <pebolle@tiscali.nl>, Jiri Kosina <jkosina@suse.cz>,
Ewan Milne <emilne@redhat.com>, Hannes Reinecke <hare@suse.de>,
Christoph Hellwig <hch@lst.de>, Huacai Chen <chenhc@lemote.com>,
Hongliang Tao <taohl@lemote.com>, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tony Lindgren <tony@atomide.com>, Rajendra Nayak <rnayak@ti.com>,
Sricharan R <r.sricharan@ti.com>, Afzal Mohammed <afzal@ti.com>,
Keerthy <j-keerthy@ti.com>, Zhou Wang <wangzhou1@hisilicon.com>,
Felipe Balbi <balbi@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thomas Gleixner <tglx@linutronix.de>,
Randy Dunlap <rdunlap@infradead.org>,
Kukjin Kim <kgene.kim@samsung.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Quentin Lambert <lambert.quentin@gmail.com>,
Eyal Perry <eyalpe@mellanox.com>, Arnd Bergmann <arnd@arndb.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, iss_storagedev@hp.com,
linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely
Date: Thu, 5 Mar 2015 16:08:50 +0300 [thread overview]
Message-ID: <20150305130850.GK5437@mwanda> (raw)
In-Reply-To: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com>
On Thu, Mar 05, 2015 at 01:59:39PM +0100, Valentin Rothberg wrote:
> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
> index 289ad3ac3e80..7f9f9c827c1d 100644
> --- a/drivers/mtd/nand/hisi504_nand.c
> +++ b/drivers/mtd/nand/hisi504_nand.c
> @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev)
>
> hisi_nfc_host_init(host);
>
> - ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED,
> - "nandc", host);
> + ret = devm_request_irq(dev, irq, hinfc_irq_handle, "nandc", host);
I think this breaks the build.
> if (ret) {
> dev_err(dev, "failed to request IRQ\n");
> goto err_res;
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Nishanth Menon <nm@ti.com>,
linux-mips@linux-mips.org,
Quentin Lambert <lambert.quentin@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Tony Lindgren <tony@atomide.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sricharan R <r.sricharan@ti.com>,
linux-mtd@lists.infradead.org, Felipe Balbi <balbi@ti.com>,
Huacai Chen <chenhc@lemote.com>, Christoph Hellwig <hch@lst.de>,
Kukjin Kim <kgene.kim@samsung.com>,
iss_storagedev@hp.com, Jonathan Corbet <corbet@lwn.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ewan Milne <emilne@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Afzal Mohammed <afzal@ti.com>, Arnd Bergmann <arnd@arndb.de>,
Rajendra Nayak <rnayak@ti.com>, Eyal Perry <eyalpe@mellanox.com>,
Hannes Reinecke <hare@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Bolle <pebolle@tiscali.nl>, Keerthy <j-keerthy@ti.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
Zhou Wang <wangzhou1@hisilicon.com>,
linux-usb@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hongliang Tao <taohl@lemote.com>,
akpm@linux-foundation.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] Remove deprecated IRQF_DISABLED flag entirely
Date: Thu, 5 Mar 2015 16:08:50 +0300 [thread overview]
Message-ID: <20150305130850.GK5437@mwanda> (raw)
In-Reply-To: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com>
On Thu, Mar 05, 2015 at 01:59:39PM +0100, Valentin Rothberg wrote:
> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
> index 289ad3ac3e80..7f9f9c827c1d 100644
> --- a/drivers/mtd/nand/hisi504_nand.c
> +++ b/drivers/mtd/nand/hisi504_nand.c
> @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev)
>
> hisi_nfc_host_init(host);
>
> - ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED,
> - "nandc", host);
> + ret = devm_request_irq(dev, irq, hinfc_irq_handle, "nandc", host);
I think this breaks the build.
> if (ret) {
> dev_err(dev, "failed to request IRQ\n");
> goto err_res;
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-05 13:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 12:59 [PATCH] Remove deprecated IRQF_DISABLED flag entirely Valentin Rothberg
2015-03-05 12:59 ` Valentin Rothberg
2015-03-05 13:08 ` Dan Carpenter [this message]
2015-03-05 13:08 ` Dan Carpenter
2015-03-05 13:33 ` Valentin Rothberg
2015-03-05 13:33 ` Valentin Rothberg
2015-03-05 13:11 ` Hannes Reinecke
2015-03-05 13:11 ` Hannes Reinecke
2015-03-05 13:41 ` Valentin Rothberg
2015-03-05 13:41 ` Valentin Rothberg
2015-03-06 19:41 ` Dmitry Torokhov
2015-03-06 19:41 ` Dmitry Torokhov
2015-03-09 8:41 ` Valentin Rothberg
2015-03-09 8:41 ` Valentin Rothberg
2015-03-05 14:23 ` [PATCH v2] " Valentin Rothberg
2015-03-05 14:23 ` Valentin Rothberg
2015-03-06 8:37 ` [tip:irq/core] genirq: Remove the deprecated 'IRQF_DISABLED' request_irq() " tip-bot for Valentin Rothberg
2015-03-06 18:31 ` [PATCH v2] Remove deprecated IRQF_DISABLED " Tony Lindgren
2015-03-06 18:31 ` Tony Lindgren
2015-03-06 18:46 ` Brian Norris
2015-03-06 18:46 ` Brian Norris
2015-03-09 16:52 ` Felipe Balbi
2015-03-09 16:52 ` Felipe Balbi
2015-03-09 16:52 ` Felipe Balbi
2015-03-09 17:24 ` Valentin Rothberg
2015-03-09 17:24 ` Valentin Rothberg
2015-03-09 17:29 ` Felipe Balbi
2015-03-09 17:29 ` Felipe Balbi
2015-03-09 17:29 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305130850.GK5437@mwanda \
--to=dan.carpenter@oracle.com \
--cc=afzal@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=chenhc@lemote.com \
--cc=computersforpeace@gmail.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=emilne@redhat.com \
--cc=eyalpe@mellanox.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=iss_storagedev@hp.com \
--cc=j-keerthy@ti.com \
--cc=jkosina@suse.cz \
--cc=kgene.kim@samsung.com \
--cc=lambert.quentin@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=pebolle@tiscali.nl \
--cc=peter.ujfalusi@ti.com \
--cc=peterz@infradead.org \
--cc=r.sricharan@ti.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ralf@linux-mips.org \
--cc=rdunlap@infradead.org \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=taohl@lemote.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=valentinrothberg@gmail.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.