From: Dario Faggioli <dario.faggioli@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Juergen Gross <JGross@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 9/9] xl: use libxl_cpupoolinfo_list_free() in main_cpupoolnumasplit
Date: Fri, 06 Mar 2015 18:22:07 +0100 [thread overview]
Message-ID: <20150306172207.7269.13948.stgit@Solace.station> (raw)
In-Reply-To: <20150306170758.7269.53821.stgit@Solace.station>
instead manually free the elements of the list, which is
exactly the purpose of the said function.
Trade also a couple of 'return'-s with 'goto out'-s, which
is more in line with libxl usage paradigm.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Juergen Gross <JGross@suse.com>
---
tools/libxl/xl_cmdimpl.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 14b5a3d..ec2b6a9 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -7477,9 +7477,8 @@ int main_cpupoolnumasplit(int argc, char **argv)
}
poolid = poolinfo[0].poolid;
sched = poolinfo[0].sched;
- for (p = 0; p < n_pools; p++) {
- libxl_cpupoolinfo_dispose(poolinfo + p);
- }
+ libxl_cpupoolinfo_list_free(poolinfo, n_pools);
+
if (n_pools > 1) {
fprintf(stderr, "splitting not possible, already cpupools in use\n");
return 1;
@@ -7493,8 +7492,7 @@ int main_cpupoolnumasplit(int argc, char **argv)
if (libxl_cpu_bitmap_alloc(ctx, &cpumap, 0)) {
fprintf(stderr, "Failed to allocate cpumap\n");
- libxl_cputopology_list_free(topology, n_cpus);
- return 1;
+ goto out;
}
/* Reset Pool-0 to 1st node: first add cpus, then remove cpus to avoid
@@ -7503,7 +7501,7 @@ int main_cpupoolnumasplit(int argc, char **argv)
node = topology[0].node;
if (libxl_cpupool_cpuadd_node(ctx, 0, node, &n)) {
fprintf(stderr, "error on adding cpu to Pool 0\n");
- return 1;
+ goto out;
}
snprintf(name, 15, "Pool-node%d", node);
next prev parent reply other threads:[~2015-03-06 17:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 17:20 [PATCH 0/9] Some (not only) cpupool related fixes and improvements Dario Faggioli
2015-03-06 17:20 ` [PATCH 1/9] docs: RTDS is a valid alternative as a scheduler for a cpupool Dario Faggioli
2015-03-06 19:16 ` Meng Xu
2015-03-09 10:20 ` Wei Liu
2015-03-06 17:21 ` [PATCH 2/9] docs: fix `xl list' manpage entry Dario Faggioli
2015-03-09 10:21 ` Wei Liu
2015-03-06 17:21 ` [PATCH 3/9] xl: turn some int local variable into bool Dario Faggioli
2015-03-09 10:24 ` Wei Liu
2015-03-06 17:21 ` [PATCH 4/9] xl: add -c/--cpupool option to `xl list' Dario Faggioli
2015-03-09 10:27 ` Wei Liu
2015-03-06 17:21 ` [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap() Dario Faggioli
2015-03-09 10:39 ` Wei Liu
2015-03-09 11:31 ` Dario Faggioli
2015-03-09 11:47 ` Wei Liu
2015-03-11 16:42 ` Ian Campbell
2015-03-11 16:50 ` Dario Faggioli
2015-03-11 16:57 ` Ian Campbell
2015-03-06 17:21 ` [PATCH 6/9] xl: enable using ranges of pCPUs when manipulating cpupools Dario Faggioli
2015-03-09 10:51 ` Wei Liu
2015-03-09 11:37 ` Dario Faggioli
2015-03-06 17:21 ` [PATCH 7/9] xl: enable using ranges of pCPUs when creating cpupools Dario Faggioli
2015-03-09 10:58 ` Wei Liu
2015-03-09 11:18 ` Dario Faggioli
2015-03-09 11:20 ` Wei Liu
2015-03-06 17:21 ` [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent Dario Faggioli
2015-03-09 11:01 ` Wei Liu
2015-03-09 11:23 ` Dario Faggioli
2015-03-11 14:52 ` Ian Campbell
2015-03-11 15:04 ` Wei Liu
2015-03-11 15:13 ` Dario Faggioli
2015-03-11 15:23 ` Wei Liu
2015-03-11 16:22 ` Dario Faggioli
2015-03-11 16:24 ` Wei Liu
2015-03-11 16:28 ` Dario Faggioli
2015-03-11 15:14 ` Ian Campbell
2015-03-06 17:22 ` Dario Faggioli [this message]
2015-03-09 11:02 ` [PATCH 9/9] xl: use libxl_cpupoolinfo_list_free() in main_cpupoolnumasplit Wei Liu
2015-03-11 14:54 ` Ian Campbell
2015-03-11 14:56 ` [PATCH 0/9] Some (not only) cpupool related fixes and improvements Ian Campbell
2015-03-11 15:09 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306172207.7269.13948.stgit@Solace.station \
--to=dario.faggioli@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JGross@suse.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.