From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "JGross@suse.com" <JGross@suse.com>,
Ian Jackson <Ian.Jackson@citrix.com>,
Stefano Stabellini <Stefano.Stabellini@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent
Date: Mon, 9 Mar 2015 11:23:55 +0000 [thread overview]
Message-ID: <1425900233.2729.26.camel@citrix.com> (raw)
In-Reply-To: <20150309110122.GK18491@zion.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]
On Mon, 2015-03-09 at 11:01 +0000, Wei Liu wrote:
> On Fri, Mar 06, 2015 at 06:21:59PM +0100, Dario Faggioli wrote:
> > with the rest of the file, where we return 1 on 0, rather
> > than using libxl error codes.
> >
>
> While being consistent is good I'm not very sure if we should go for 0/1
> rather than libxl error codes.
>
If there is a plan to switch everything in xl to use libxl error code,
then just let me know, ad I'll drop this patch.
As far as I could see, there is __A__ __LOT__ of 'return 0/1' (or
'exit(1)'), and only these few libxl error code usage, so it's really
inconsistent! :-)
> I vaguely remember at some point we
> discussed we should make xl exit code better but I don't remember the
> exact details.
>
As I said, just let me know.
Dario
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-03-09 11:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 17:20 [PATCH 0/9] Some (not only) cpupool related fixes and improvements Dario Faggioli
2015-03-06 17:20 ` [PATCH 1/9] docs: RTDS is a valid alternative as a scheduler for a cpupool Dario Faggioli
2015-03-06 19:16 ` Meng Xu
2015-03-09 10:20 ` Wei Liu
2015-03-06 17:21 ` [PATCH 2/9] docs: fix `xl list' manpage entry Dario Faggioli
2015-03-09 10:21 ` Wei Liu
2015-03-06 17:21 ` [PATCH 3/9] xl: turn some int local variable into bool Dario Faggioli
2015-03-09 10:24 ` Wei Liu
2015-03-06 17:21 ` [PATCH 4/9] xl: add -c/--cpupool option to `xl list' Dario Faggioli
2015-03-09 10:27 ` Wei Liu
2015-03-06 17:21 ` [PATCH 5/9] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap() Dario Faggioli
2015-03-09 10:39 ` Wei Liu
2015-03-09 11:31 ` Dario Faggioli
2015-03-09 11:47 ` Wei Liu
2015-03-11 16:42 ` Ian Campbell
2015-03-11 16:50 ` Dario Faggioli
2015-03-11 16:57 ` Ian Campbell
2015-03-06 17:21 ` [PATCH 6/9] xl: enable using ranges of pCPUs when manipulating cpupools Dario Faggioli
2015-03-09 10:51 ` Wei Liu
2015-03-09 11:37 ` Dario Faggioli
2015-03-06 17:21 ` [PATCH 7/9] xl: enable using ranges of pCPUs when creating cpupools Dario Faggioli
2015-03-09 10:58 ` Wei Liu
2015-03-09 11:18 ` Dario Faggioli
2015-03-09 11:20 ` Wei Liu
2015-03-06 17:21 ` [PATCH 8/9] xl: make error reporting of cpupool subcommands consistent Dario Faggioli
2015-03-09 11:01 ` Wei Liu
2015-03-09 11:23 ` Dario Faggioli [this message]
2015-03-11 14:52 ` Ian Campbell
2015-03-11 15:04 ` Wei Liu
2015-03-11 15:13 ` Dario Faggioli
2015-03-11 15:23 ` Wei Liu
2015-03-11 16:22 ` Dario Faggioli
2015-03-11 16:24 ` Wei Liu
2015-03-11 16:28 ` Dario Faggioli
2015-03-11 15:14 ` Ian Campbell
2015-03-06 17:22 ` [PATCH 9/9] xl: use libxl_cpupoolinfo_list_free() in main_cpupoolnumasplit Dario Faggioli
2015-03-09 11:02 ` Wei Liu
2015-03-11 14:54 ` Ian Campbell
2015-03-11 14:56 ` [PATCH 0/9] Some (not only) cpupool related fixes and improvements Ian Campbell
2015-03-11 15:09 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425900233.2729.26.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JGross@suse.com \
--cc=Stefano.Stabellini@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.