Re: [PATCH 6/9] xl: enable using ranges of pCPUs when manipulating cpupools

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2263 bytes --]

On Mon, 2015-03-09 at 10:51 +0000, Wei Liu wrote:
> On Fri, Mar 06, 2015 at 06:21:42PM +0100, Dario Faggioli wrote:

> > ---
> >  docs/man/xl.pod.1        |   25 ++++++++++--
> >  tools/libxl/xl_cmdimpl.c |   94 ++++++++++++++++++++--------------------------
> >  2 files changed, 62 insertions(+), 57 deletions(-)
> > 
> > diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> > index c330016..ef0d763 100644
> > --- a/docs/man/xl.pod.1
> > +++ b/docs/man/xl.pod.1
> > @@ -1147,13 +1147,30 @@ This is possible only if no domain is active in the cpu-pool.
> >  
> >  Renames a cpu-pool to I<newname>.
> >  
> > -=item B<cpupool-cpu-add> I<cpu-pool> I<cpu-nr|node:node-nr>
> > +=item B<cpupool-cpu-add> I<cpu-pool> I<cpus|node:nodes>
> >  
> > -Adds a cpu or all cpus of a numa node to a cpu-pool.
> > +Adds I<cpus> or full NUMA I<nodes> to I<cpu-pool>. pCPUs and NUMA nodes
>                    ^^^^
> You can also specify some cpus inside a NUMA node.
> 
Well, if you use "node:1,2", that means _all_ the cpus of NUMA node 1
and 2. Then, of course, you can add only some of then by just saying
"0,1,8,9", or something like "node:1,^2-7", so yes, of course you can
specify only some of the cpus of a NUMA node, but that was meant at
describing what "node:" does.

That being said, I'll look for a better wording, or just use

"Adds pCPUs and/or NUMA nodes to I<cpu-pool>"

and leave it to the more detailed explanation and to the examples below.

> > +can be specified as single pCPU/node IDs or as ranges.
> >  
> > -=item B<cpupool-cpu-remove> I<cpu-nr|node:node-nr>
> > +For example:
> > +
> > + (a) xl cpupool-cpu-add mypool 4
> > + (b) xl cpupool-cpu-add mypool 1,5,10-16,^13
> > + (c) xl cpupool-cpu-add mypool node:0,nodes:2-3,^10-12,8
> > +
> > +means adding pCPU 4 to mypool, in (a); adding pCPUs 1,5,10,11,12,14,15
> > +and 16, in (b); and adding all the pCPUs of NUMA nodes 0, 2 and 3,
> > +plus pCPU 8, but keeping out pCPUs 10,11,12, in (c).
> > +
> > +All the specified pCPUs that can be added to the cpupool will be added
> > +to it. If some pCPU can't (e.g., because they're already part of another
> > +cpupool), an error is reported about each one of them.
> > +

Thanks and Regards,
Dario

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel