All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: dts: sun7i: Add OOB irq support to boards with broadcom sdio wifi
Date: Sun, 8 Mar 2015 18:25:01 +0100	[thread overview]
Message-ID: <20150308172501.GG5085@lukather> (raw)
In-Reply-To: <1425754884-7875-6-git-send-email-hdegoede@redhat.com>

On Sat, Mar 07, 2015 at 08:01:23PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 11 +++++++++++
>  arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts  | 11 +++++++++++
>  2 files changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index 0c219a4..8111b0c 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -167,12 +167,23 @@
>  };
>  
>  &mmc3 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +

Aside from Chen-Yu's comments, that should be in the DTSI.

>  	pinctrl-names = "default";
>  	pinctrl-0 = <&mmc3_pins_a>;
>  	vmmc-supply = <&reg_vmmc3>;
>  	bus-width = <4>;
>  	non-removable;
>  	status = "okay";
> +
> +	brcmf: bcrmf at 1 {
> +		reg = <1>;
> +		compatible = "brcm,bcm4329-fmac";
> +		interrupt-parent = <&pio>;
> +		interrupts = <10 8>; /* PH10 / EINT10 */

And you can use interrupts-extented here (not that I really care much,
both solutions works for me).

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150308/2fc0ca41/attachment-0001.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 6/7] ARM: dts: sun7i: Add OOB irq support to boards with broadcom sdio wifi
Date: Sun, 8 Mar 2015 18:25:01 +0100	[thread overview]
Message-ID: <20150308172501.GG5085@lukather> (raw)
In-Reply-To: <1425754884-7875-6-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

On Sat, Mar 07, 2015 at 08:01:23PM +0100, Hans de Goede wrote:
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 11 +++++++++++
>  arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts  | 11 +++++++++++
>  2 files changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index 0c219a4..8111b0c 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -167,12 +167,23 @@
>  };
>  
>  &mmc3 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +

Aside from Chen-Yu's comments, that should be in the DTSI.

>  	pinctrl-names = "default";
>  	pinctrl-0 = <&mmc3_pins_a>;
>  	vmmc-supply = <&reg_vmmc3>;
>  	bus-width = <4>;
>  	non-removable;
>  	status = "okay";
> +
> +	brcmf: bcrmf@1 {
> +		reg = <1>;
> +		compatible = "brcm,bcm4329-fmac";
> +		interrupt-parent = <&pio>;
> +		interrupts = <10 8>; /* PH10 / EINT10 */

And you can use interrupts-extented here (not that I really care much,
both solutions works for me).

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-03-08 17:25 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 19:01 [PATCH 1/7] ARM: dts: sun4i: Enable tablet keys on Chuwi V7 CW0825 Hans de Goede
2015-03-07 19:01 ` Hans de Goede
2015-03-07 19:01 ` [PATCH 2/7] ARM: dts: sun5i: Stop using different compatibles for ehci/ohci on a13 vs a10s Hans de Goede
2015-03-07 19:01   ` Hans de Goede
2015-03-08 17:19   ` Maxime Ripard
2015-03-08 17:19     ` Maxime Ripard
2015-03-07 19:01 ` [PATCH 3/7] ARM: dts: sun5i: Add mmc2 pinmux settings Hans de Goede
2015-03-07 19:01   ` Hans de Goede
2015-03-08 17:19   ` Maxime Ripard
2015-03-08 17:19     ` Maxime Ripard
2015-03-07 19:01 ` [PATCH 4/7] ARM: dts: sun5i: Add new Auxtek-t004 board Hans de Goede
2015-03-07 19:01   ` Hans de Goede
2015-03-08 17:21   ` Maxime Ripard
2015-03-08 17:21     ` Maxime Ripard
2015-03-08 19:15     ` Hans de Goede
2015-03-08 19:15       ` Hans de Goede
2015-03-09 14:53       ` Maxime Ripard
2015-03-09 14:53         ` Maxime Ripard
2015-03-07 19:01 ` [PATCH 5/7] ARM: dts: sun5i: Add new Utoo P66 board Hans de Goede
2015-03-07 19:01   ` Hans de Goede
2015-03-08 17:22   ` Maxime Ripard
2015-03-08 17:22     ` Maxime Ripard
2015-03-07 19:01 ` [PATCH 6/7] ARM: dts: sun7i: Add OOB irq support to boards with broadcom sdio wifi Hans de Goede
2015-03-07 19:01   ` Hans de Goede
2015-03-08  2:40   ` [linux-sunxi] " Chen-Yu Tsai
2015-03-08  2:40     ` Chen-Yu Tsai
2015-03-08  3:12   ` [linux-sunxi] " Chen-Yu Tsai
2015-03-08  3:12     ` Chen-Yu Tsai
2015-03-08 11:25     ` [linux-sunxi] " Hans de Goede
2015-03-08 11:25       ` Hans de Goede
2015-03-08 17:25   ` Maxime Ripard [this message]
2015-03-08 17:25     ` Maxime Ripard
2015-03-08 19:19     ` Hans de Goede
2015-03-08 19:19       ` Hans de Goede
2015-03-07 19:01 ` [PATCH 7/7] ARM: dts: sun7i: Enable cap-sdio-irq for bananapro " Hans de Goede
2015-03-07 19:01   ` Hans de Goede
2015-03-08  2:42   ` [linux-sunxi] " Chen-Yu Tsai
2015-03-08  2:42     ` Chen-Yu Tsai
2015-03-08 11:27     ` [linux-sunxi] " Hans de Goede
2015-03-08 11:27       ` Hans de Goede
2015-03-08 17:26       ` [linux-sunxi] " Maxime Ripard
2015-03-08 17:26         ` Maxime Ripard
2015-03-08 17:18 ` [PATCH 1/7] ARM: dts: sun4i: Enable tablet keys on Chuwi V7 CW0825 Maxime Ripard
2015-03-08 17:18   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150308172501.GG5085@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.