From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print
Date: Mon, 09 Mar 2015 09:22:09 +0000 [thread overview]
Message-ID: <20150309092209.GB10964@mwanda> (raw)
In-Reply-To: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com>
On Sun, Mar 08, 2015 at 06:01:23PM +0530, Sudip Mukherjee wrote:
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index 711676c..2ab7b74 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -59,10 +59,10 @@ struct lynx_share{
> }mtrr;
> #endif
> /* all smi graphic adaptor got below attributes */
> - resource_size_t vidmem_start;
> - resource_size_t vidreg_start;
> - resource_size_t vidmem_size;
> - resource_size_t vidreg_size;
> + unsigned long vidmem_start;
> + unsigned long vidreg_start;
> + unsigned long vidmem_size;
> + unsigned long vidreg_size;
> volatile unsigned char __iomem * pvReg;
> unsigned char __iomem * pvMem;
> /* locks*/
This seems like a very risky sort of change. It's not explained very
well in the changelog. What's the deal?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: sm750fb: wrong type for print
Date: Mon, 9 Mar 2015 12:22:09 +0300 [thread overview]
Message-ID: <20150309092209.GB10964@mwanda> (raw)
In-Reply-To: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com>
On Sun, Mar 08, 2015 at 06:01:23PM +0530, Sudip Mukherjee wrote:
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index 711676c..2ab7b74 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -59,10 +59,10 @@ struct lynx_share{
> }mtrr;
> #endif
> /* all smi graphic adaptor got below attributes */
> - resource_size_t vidmem_start;
> - resource_size_t vidreg_start;
> - resource_size_t vidmem_size;
> - resource_size_t vidreg_size;
> + unsigned long vidmem_start;
> + unsigned long vidreg_start;
> + unsigned long vidmem_size;
> + unsigned long vidreg_size;
> volatile unsigned char __iomem * pvReg;
> unsigned char __iomem * pvMem;
> /* locks*/
This seems like a very risky sort of change. It's not explained very
well in the changelog. What's the deal?
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-09 9:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 12:31 [PATCH 1/4] staging: sm750fb: wrong type for print Sudip Mukherjee
2015-03-08 12:43 ` Sudip Mukherjee
2015-03-08 12:31 ` [PATCH 2/4] staging: sm750fb: remove pragma optimize Sudip Mukherjee
2015-03-08 12:43 ` Sudip Mukherjee
2015-03-08 12:31 ` [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Sudip Mukherjee
2015-03-08 12:43 ` Sudip Mukherjee
2015-03-08 12:59 ` Giedrius Statkevičius
2015-03-08 12:59 ` Giedrius Statkevičius
2015-03-08 17:31 ` Sudip Mukherjee
2015-03-08 17:43 ` Sudip Mukherjee
2015-03-08 12:31 ` [PATCH 4/4] staging: sm750fb: fix undeclared function Sudip Mukherjee
2015-03-08 12:43 ` Sudip Mukherjee
2015-03-08 13:02 ` Giedrius Statkevičius
2015-03-08 13:02 ` Giedrius Statkevičius
2015-03-08 12:40 ` [PATCH 1/4] staging: sm750fb: wrong type for print Giedrius Statkevičius
2015-03-08 12:40 ` Giedrius Statkevičius
2015-03-08 12:58 ` Sudip Mukherjee
2015-03-08 12:59 ` Sudip Mukherjee
2015-03-09 9:22 ` Dan Carpenter [this message]
2015-03-09 9:22 ` Dan Carpenter
2015-03-09 9:35 ` Sudip Mukherjee
2015-03-09 9:47 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309092209.GB10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.