From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print
Date: Mon, 09 Mar 2015 12:23:55 +0000 [thread overview]
Message-ID: <20150309121155.GA11724@sudip-PC> (raw)
In-Reply-To: <20150309115337.GD10964@mwanda>
On Mon, Mar 09, 2015 at 02:53:37PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote:
> >
> > V2: Giedrius commented resource_size_t can be either u64 or u32
> > depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i
> > should have kept the datatype as resource_size_t and used %pa as the
> > format specifier. But since this is a framebuffer device and it
> > should follow what the framebuffer layer is suggesting in
> > struct fb_fix_screeninfo at smem_start and mmio_start.
> > adding Tomi for his comments.
>
>
> This should all have gone into the changelog because it changes how the
> code works.
ok, then should i send a v3 of only this patch or the whole series?
regards
sudip
>
> regards,
> dan carpenter
>
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] staging: sm750fb: wrong type for print
Date: Mon, 9 Mar 2015 17:41:55 +0530 [thread overview]
Message-ID: <20150309121155.GA11724@sudip-PC> (raw)
In-Reply-To: <20150309115337.GD10964@mwanda>
On Mon, Mar 09, 2015 at 02:53:37PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote:
> >
> > V2: Giedrius commented resource_size_t can be either u64 or u32
> > depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i
> > should have kept the datatype as resource_size_t and used %pa as the
> > format specifier. But since this is a framebuffer device and it
> > should follow what the framebuffer layer is suggesting in
> > struct fb_fix_screeninfo at smem_start and mmio_start.
> > adding Tomi for his comments.
>
>
> This should all have gone into the changelog because it changes how the
> code works.
ok, then should i send a v3 of only this patch or the whole series?
regards
sudip
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2015-03-09 12:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 7:35 [PATCH v2 1/4] staging: sm750fb: wrong type for print Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 7:35 ` [PATCH v2 2/4] staging: sm750fb: remove pragma optimize Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 7:35 ` [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 7:47 ` Lad, Prabhakar
2015-03-09 7:47 ` Lad, Prabhakar
2015-03-09 8:41 ` Sudip Mukherjee
2015-03-09 8:53 ` Sudip Mukherjee
2015-03-09 7:35 ` [PATCH v2 4/4] staging: sm750fb: fix undeclared function Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 12:42 ` Dan Carpenter
2015-03-09 12:42 ` Dan Carpenter
2015-03-09 12:55 ` Sudip Mukherjee
2015-03-09 12:55 ` Sudip Mukherjee
2015-03-09 13:29 ` Dan Carpenter
2015-03-09 13:29 ` Dan Carpenter
2015-03-09 7:42 ` [PATCH v2 1/4] staging: sm750fb: wrong type for print Lad, Prabhakar
2015-03-09 7:42 ` Lad, Prabhakar
2015-03-09 8:30 ` Sudip Mukherjee
2015-03-09 8:42 ` Sudip Mukherjee
2015-03-09 11:53 ` Dan Carpenter
2015-03-09 11:53 ` Dan Carpenter
2015-03-09 12:11 ` Sudip Mukherjee [this message]
2015-03-09 12:23 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309121155.GA11724@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.