From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function
Date: Mon, 09 Mar 2015 13:29:13 +0000 [thread overview]
Message-ID: <20150309132913.GH10964@mwanda> (raw)
In-Reply-To: <20150309125503.GB11724@sudip-PC>
On Mon, Mar 09, 2015 at 06:25:03PM +0530, Sudip Mukherjee wrote:
> Actually I thought, since this is a vendor crude driver there will be many such changes, so if i can combine some changes together then atleast the number of patches can be kept low and also i thought of clubbing these changes together as Joe Perches once told me "Don't get carried away with patch type separation" (reference: https://lkml.org/lkml/2015/1/1/2).
How to break up patches is more art than science. I wouldn't have
complained about the minor extra white space changes except that I was
already going to email you about breaking my scripts.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function
Date: Mon, 9 Mar 2015 16:29:13 +0300 [thread overview]
Message-ID: <20150309132913.GH10964@mwanda> (raw)
In-Reply-To: <20150309125503.GB11724@sudip-PC>
On Mon, Mar 09, 2015 at 06:25:03PM +0530, Sudip Mukherjee wrote:
> Actually I thought, since this is a vendor crude driver there will be many such changes, so if i can combine some changes together then atleast the number of patches can be kept low and also i thought of clubbing these changes together as Joe Perches once told me "Don't get carried away with patch type separation" (reference: https://lkml.org/lkml/2015/1/1/2).
How to break up patches is more art than science. I wouldn't have
complained about the minor extra white space changes except that I was
already going to email you about breaking my scripts.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-09 13:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 7:35 [PATCH v2 1/4] staging: sm750fb: wrong type for print Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 7:35 ` [PATCH v2 2/4] staging: sm750fb: remove pragma optimize Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 7:35 ` [PATCH v2 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 7:47 ` Lad, Prabhakar
2015-03-09 7:47 ` Lad, Prabhakar
2015-03-09 8:41 ` Sudip Mukherjee
2015-03-09 8:53 ` Sudip Mukherjee
2015-03-09 7:35 ` [PATCH v2 4/4] staging: sm750fb: fix undeclared function Sudip Mukherjee
2015-03-09 7:47 ` Sudip Mukherjee
2015-03-09 12:42 ` Dan Carpenter
2015-03-09 12:42 ` Dan Carpenter
2015-03-09 12:55 ` Sudip Mukherjee
2015-03-09 12:55 ` Sudip Mukherjee
2015-03-09 13:29 ` Dan Carpenter [this message]
2015-03-09 13:29 ` Dan Carpenter
2015-03-09 7:42 ` [PATCH v2 1/4] staging: sm750fb: wrong type for print Lad, Prabhakar
2015-03-09 7:42 ` Lad, Prabhakar
2015-03-09 8:30 ` Sudip Mukherjee
2015-03-09 8:42 ` Sudip Mukherjee
2015-03-09 11:53 ` Dan Carpenter
2015-03-09 11:53 ` Dan Carpenter
2015-03-09 12:11 ` Sudip Mukherjee
2015-03-09 12:23 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309132913.GH10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.