From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix sparse warning
Date: Tue, 10 Mar 2015 07:54:26 +0000 [thread overview]
Message-ID: <20150310074226.GA12561@sudip-PC> (raw)
In-Reply-To: <1425934628-3717-1-git-send-email-lstoakes@gmail.com>
On Mon, Mar 09, 2015 at 08:57:08PM +0000, Lorenzo Stoakes wrote:
>
> +#include <asm/io.h>
> +
apart from what Dan Carpenter has said,
this is introducing one checkpatch warning, better to use #include <linux/io.h>
checkpatch is also giving warning about your patch subject
only one concern - if Greg first applies the patches i sent yesterday then this patch will not apply, and if this one is applied first then my series will not apply ...
regards
sudip
> /* This is all the chips recognized by this library */
> mmio750 = addr;
> devId750 = devId;
> --
> 2.3.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix sparse warning
Date: Tue, 10 Mar 2015 13:12:26 +0530 [thread overview]
Message-ID: <20150310074226.GA12561@sudip-PC> (raw)
In-Reply-To: <1425934628-3717-1-git-send-email-lstoakes@gmail.com>
On Mon, Mar 09, 2015 at 08:57:08PM +0000, Lorenzo Stoakes wrote:
>
> +#include <asm/io.h>
> +
apart from what Dan Carpenter has said,
this is introducing one checkpatch warning, better to use #include <linux/io.h>
checkpatch is also giving warning about your patch subject
only one concern - if Greg first applies the patches i sent yesterday then this patch will not apply, and if this one is applied first then my series will not apply ...
regards
sudip
> /* This is all the chips recognized by this library */
> mmio750 = addr;
> devId750 = devId;
> --
> 2.3.2
>
next prev parent reply other threads:[~2015-03-10 7:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:57 [PATCH] staging: sm750fb: Fix sparse warning Lorenzo Stoakes
2015-03-09 20:57 ` Lorenzo Stoakes
2015-03-10 7:00 ` Dan Carpenter
2015-03-10 7:00 ` Dan Carpenter
2015-03-10 8:47 ` Lorenzo Stoakes
2015-03-10 8:59 ` Dan Carpenter
2015-03-10 8:59 ` Dan Carpenter
2015-03-10 9:14 ` Lorenzo Stoakes
2015-03-10 7:42 ` Sudip Mukherjee [this message]
2015-03-10 7:54 ` Sudip Mukherjee
2015-03-10 8:44 ` Lorenzo Stoakes
2015-08-05 13:26 ` [PATCH] staging: sm750fb: fix sparse warning for lock Peng Fan
2015-08-05 13:26 ` Peng Fan
2015-08-05 19:01 ` Greg KH
2015-08-05 19:01 ` Greg KH
2015-08-05 22:34 ` Dan Carpenter
2015-08-05 22:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310074226.GA12561@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.