All of lore.kernel.org
 help / color / mirror / Atom feed
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: force CPU selection
Date: Tue, 10 Mar 2015 10:42:09 +0100	[thread overview]
Message-ID: <20150310094209.GD9188@piout.net> (raw)
In-Reply-To: <2216832.iXiqHye8YX@wuerfel>

On 10/03/2015 at 10:02:15 +0100, Arnd Bergmann wrote :
> On Monday 09 March 2015 23:59:58 Brian Norris wrote:
> > @@ -114,6 +114,12 @@ config SOC_AT91SAM9
> >             AT91SAM9XE
> >  endif # SOC_SAM_V4_V5
> >  
> > +config MACH_AT91_AUTO
> > +       def_bool y
> > +       depends on !SOC_AT91SAM9 && !SOC_SAMA5D4
> > +       select SOC_SAMA5D3 if SOC_SAM_V7
> > +       select SOC_AT91RM9200 if SOC_SAM_V4_V5
> > +
> >  comment "AT91 Feature Selections"
> >  
> >  config AT91_SLOW_CLOCK
> 
> Hi Brian,
> 
> I actually added a bunch of these in other places, but have stopped
> doing so because Russell didn't like them, and I tend to follow
> his argument now that it's actually pretty confusing.
> 
> In case of at91, we can do better now, once we have multiplatform
> enabled, and we can simply remove the SOC_SAM_V7 and SOC_SAM_V4_V5
> symbols entirely (if Alexandre's patch doesn't already do that).
> 

I didn't remove it to keep the sub menus SOC_SAM_V7 -> SOC_SAMA5D4 and
SOC_SAMA5D3, SOC_SAM_V4_V5 -> SOC_AT91SAM9 and SOC_AT91RM9200. But I can
also expose SOC_AT91RM9200, SOC_AT91SAM9, SOC_SAMA5D3 and SOC_SAMA5D4
instead of SOC_SAM_V7 and SOC_SAM_V4_V5 and remove them.

> With multiplatform enabled, you no longer have to select a particular
> SoC, because we always get the default selection and the kernel
> will build without any one of them being enabled.
> 

Indeed, with multiplatform, the kernel will compile without any of those
being selected.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	Andrew Victor <linux@maxim.org.za>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-kernel@vger.kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] ARM: at91: force CPU selection
Date: Tue, 10 Mar 2015 10:42:09 +0100	[thread overview]
Message-ID: <20150310094209.GD9188@piout.net> (raw)
In-Reply-To: <2216832.iXiqHye8YX@wuerfel>

On 10/03/2015 at 10:02:15 +0100, Arnd Bergmann wrote :
> On Monday 09 March 2015 23:59:58 Brian Norris wrote:
> > @@ -114,6 +114,12 @@ config SOC_AT91SAM9
> >             AT91SAM9XE
> >  endif # SOC_SAM_V4_V5
> >  
> > +config MACH_AT91_AUTO
> > +       def_bool y
> > +       depends on !SOC_AT91SAM9 && !SOC_SAMA5D4
> > +       select SOC_SAMA5D3 if SOC_SAM_V7
> > +       select SOC_AT91RM9200 if SOC_SAM_V4_V5
> > +
> >  comment "AT91 Feature Selections"
> >  
> >  config AT91_SLOW_CLOCK
> 
> Hi Brian,
> 
> I actually added a bunch of these in other places, but have stopped
> doing so because Russell didn't like them, and I tend to follow
> his argument now that it's actually pretty confusing.
> 
> In case of at91, we can do better now, once we have multiplatform
> enabled, and we can simply remove the SOC_SAM_V7 and SOC_SAM_V4_V5
> symbols entirely (if Alexandre's patch doesn't already do that).
> 

I didn't remove it to keep the sub menus SOC_SAM_V7 -> SOC_SAMA5D4 and
SOC_SAMA5D3, SOC_SAM_V4_V5 -> SOC_AT91SAM9 and SOC_AT91RM9200. But I can
also expose SOC_AT91RM9200, SOC_AT91SAM9, SOC_SAMA5D3 and SOC_SAMA5D4
instead of SOC_SAM_V7 and SOC_SAM_V4_V5 and remove them.

> With multiplatform enabled, you no longer have to select a particular
> SoC, because we always get the default selection and the kernel
> will build without any one of them being enabled.
> 

Indeed, with multiplatform, the kernel will compile without any of those
being selected.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-10  9:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  6:59 [PATCH] ARM: at91: force CPU selection Brian Norris
2015-03-10  6:59 ` Brian Norris
2015-03-10  9:02 ` Arnd Bergmann
2015-03-10  9:02   ` Arnd Bergmann
2015-03-10  9:42   ` Alexandre Belloni [this message]
2015-03-10  9:42     ` Alexandre Belloni
2015-03-10 13:42     ` Arnd Bergmann
2015-03-10 13:42       ` Arnd Bergmann
2015-03-13 18:32       ` Alexandre Belloni
2015-03-13 18:32         ` Alexandre Belloni
2015-03-13 19:50         ` Arnd Bergmann
2015-03-13 19:50           ` Arnd Bergmann
2015-03-13 20:30           ` Alexandre Belloni
2015-03-13 20:30             ` Alexandre Belloni
2015-03-10 20:02   ` Brian Norris
2015-03-10 20:02     ` Brian Norris
2015-03-10 21:13     ` Alexandre Belloni
2015-03-10 21:13       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310094209.GD9188@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.