All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: joe@perches.com, mdcasey@chabloom.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: rtllib_wx: code style improvements
Date: Wed, 11 Mar 2015 08:53:30 +0100	[thread overview]
Message-ID: <20150311075330.GA6197@kroah.com> (raw)
In-Reply-To: <1426059960-11587-1-git-send-email-mateusz.kulikowski@gmail.com>

On Wed, Mar 11, 2015 at 08:46:00AM +0100, Mateusz Kulikowski wrote:
> Code reformatting based on checkpatch.pl:
> - Replaced min() with min_t()
> - Replaced printk() with netdev_*()
> - Merged broken string

That's three different things, which means this should be at least 3
different patches.  Please fix up and resend a patch series, as each
patch should only do one thing.

thanks,

greg k-h

  reply	other threads:[~2015-03-11  7:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 22:53 [PATCH] staging: rtl8192e: rtllib_wx: code style improvements Mateusz Kulikowski
2015-03-10 23:01 ` Joe Perches
2015-03-11  7:32   ` Mateusz Kulikowski
2015-03-11  7:46 ` [PATCH v2] " Mateusz Kulikowski
2015-03-11  7:53   ` Greg KH [this message]
2015-03-11 22:19     ` Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 0/6] staging: rtl8192e: fix coding style issues Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) Mateusz Kulikowski
2015-03-13  0:27     ` Joe Perches
2015-03-16 21:57       ` Mateusz Kulikowski
2015-03-17  0:17         ` Joe Perches
2015-03-16  8:44     ` Dan Carpenter
2015-03-16 21:45       ` Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 2/6] staging: rtl8192e: fix coding style issues (replace min with min_t) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 3/6] staging: rtl8192e: fix coding style issues (spaces before semicolon) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 4/6] staging: rtl8192e: fix coding style errors (macros in parentheses) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 5/6] staging: rtl8192e: rtllib_wx: fix coding style (printk -> netdev_*) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 6/6] staging: rtl8192e: rtllib_wx: remove duplicate messages Mateusz Kulikowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311075330.GA6197@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mateusz.kulikowski@gmail.com \
    --cc=mdcasey@chabloom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.