All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, joe@perches.com,
	devel@driverdev.osuosl.org, mdcasey@chabloom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)
Date: Mon, 16 Mar 2015 22:45:40 +0100	[thread overview]
Message-ID: <55074F04.2070700@gmail.com> (raw)
In-Reply-To: <20150316084405.GG10964@mwanda>

On 16.03.2015 09:44, Dan Carpenter wrote:
> On Fri, Mar 13, 2015 at 12:53:16AM +0100, Mateusz Kulikowski wrote:
>> -			RT_TRACE(COMP_RECV, "HwRateToMRate90(): Non supported"
>> -				 "Rate [%x], bIsHT = %d!!!\n", rate, bIsHT);
>> -						  break;
>> +			RT_TRACE(COMP_RECV,
>> +				 "HwRateToMRate90(): Non supportedRate [%x], bIsHT = %d!!!\n",
> 
> There should be a space character between "supported" and "Rate".  You
> can fix it in a later patch though, it's minor.  And really no one cares
> about RT_TRACE() output.

Thanks for the hint - there is a lot of other typos in messages - I will probably fix them later on;

As for RT_TRACE - my plan is to replace the whole "proprietary logging system" with dynamic debug 
(i.e. netdev_dbg() or pr_debug()), but again - this is bigger patch and I'll prepare it after this series is merged.


Regards,
Mateusz


  reply	other threads:[~2015-03-16 21:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 22:53 [PATCH] staging: rtl8192e: rtllib_wx: code style improvements Mateusz Kulikowski
2015-03-10 23:01 ` Joe Perches
2015-03-11  7:32   ` Mateusz Kulikowski
2015-03-11  7:46 ` [PATCH v2] " Mateusz Kulikowski
2015-03-11  7:53   ` Greg KH
2015-03-11 22:19     ` Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 0/6] staging: rtl8192e: fix coding style issues Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) Mateusz Kulikowski
2015-03-13  0:27     ` Joe Perches
2015-03-16 21:57       ` Mateusz Kulikowski
2015-03-17  0:17         ` Joe Perches
2015-03-16  8:44     ` Dan Carpenter
2015-03-16 21:45       ` Mateusz Kulikowski [this message]
2015-03-12 23:53   ` [PATCH v3 2/6] staging: rtl8192e: fix coding style issues (replace min with min_t) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 3/6] staging: rtl8192e: fix coding style issues (spaces before semicolon) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 4/6] staging: rtl8192e: fix coding style errors (macros in parentheses) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 5/6] staging: rtl8192e: rtllib_wx: fix coding style (printk -> netdev_*) Mateusz Kulikowski
2015-03-12 23:53   ` [PATCH v3 6/6] staging: rtl8192e: rtllib_wx: remove duplicate messages Mateusz Kulikowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55074F04.2070700@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdcasey@chabloom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.