From: Joe Perches <joe@perches.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: gregkh@linuxfoundation.org, mdcasey@chabloom.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings)
Date: Thu, 12 Mar 2015 17:27:06 -0700 [thread overview]
Message-ID: <1426206426.9314.4.camel@perches.com> (raw)
In-Reply-To: <1426204401-20414-2-git-send-email-mateusz.kulikowski@gmail.com>
On Fri, 2015-03-13 at 00:53 +0100, Mateusz Kulikowski wrote:
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 0e6bdd2..01d2201 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> @@ -47,8 +47,8 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev,
> 0x0e, bMask12Bits, 0x021);
>
> } else {
> - RT_TRACE(COMP_ERR, "PHY_SetRF8256Bandwidth(): "
> - "unknown hardware version\n");
> + RT_TRACE(COMP_ERR,
> + "PHY_SetRF8256Bandwidth(): unknown hardware version\n");
Another thing you might consider is to change these
embedded function names in another patch to use
"%s: ", __func__
RT_TRACE(COMP_ERR,
"%s: "unknown hardware version\n",
__func__)
There's a cocci script for that.
http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names
next prev parent reply other threads:[~2015-03-13 0:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 22:53 [PATCH] staging: rtl8192e: rtllib_wx: code style improvements Mateusz Kulikowski
2015-03-10 23:01 ` Joe Perches
2015-03-11 7:32 ` Mateusz Kulikowski
2015-03-11 7:46 ` [PATCH v2] " Mateusz Kulikowski
2015-03-11 7:53 ` Greg KH
2015-03-11 22:19 ` Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 0/6] staging: rtl8192e: fix coding style issues Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 1/6] staging: rtl8192e: fix coding style issues (merge broken strings) Mateusz Kulikowski
2015-03-13 0:27 ` Joe Perches [this message]
2015-03-16 21:57 ` Mateusz Kulikowski
2015-03-17 0:17 ` Joe Perches
2015-03-16 8:44 ` Dan Carpenter
2015-03-16 21:45 ` Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 2/6] staging: rtl8192e: fix coding style issues (replace min with min_t) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 3/6] staging: rtl8192e: fix coding style issues (spaces before semicolon) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 4/6] staging: rtl8192e: fix coding style errors (macros in parentheses) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 5/6] staging: rtl8192e: rtllib_wx: fix coding style (printk -> netdev_*) Mateusz Kulikowski
2015-03-12 23:53 ` [PATCH v3 6/6] staging: rtl8192e: rtllib_wx: remove duplicate messages Mateusz Kulikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426206426.9314.4.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=mdcasey@chabloom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.