All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-pwm@vger.kernel.org, alsa-devel@alsa-project.org,
	Mike Turquette <mturquette@linaro.org>,
	linux-serial@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	dri-devel@lists.freedesktop.org, Mark Brown <broonie@kernel.org>,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: provide clk_is_match() dummy for non-common clk
Date: Wed, 11 Mar 2015 12:17:55 +0100	[thread overview]
Message-ID: <20150311111755.GI952@pengutronix.de> (raw)
In-Reply-To: <20150311102208.GX8656@n2100.arm.linux.org.uk>

Hey Russell,

On Wed, Mar 11, 2015 at 10:22:09AM +0000, Russell King - ARM Linux wrote:
> On Sun, Mar 08, 2015 at 10:05:29PM +0100, Arnd Bergmann wrote:
> > ARM randconfig build tests found a new error for configurations
> > with COMMON_CLK disabled but HAS_CLK selected by the platform:
> > 
> > ERROR: "clk_is_match" [sound/soc/fsl/snd-soc-fsl-spdif.ko] undefined!
> > 
> > This moves the declaration around, so this case is covered
> > by the existing static inline helper function.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c69e182e51d89 ("clk: introduce clk_is_match")
> > ----
> > BTW, we have a preexisting problem in clk_get_parent,
> > clk_round_rate and clk_set_parent, which I've worked around in
> > my randconfig builds so far. Should we do that the same way?
> 
> NAK, as Uwe points out, you didn't address my comment.
You commented on the patch that is c69e182e51d8 ("clk: introduce
clk_is_match") now in next. Arnd just moved this around.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: provide clk_is_match() dummy for non-common clk
Date: Wed, 11 Mar 2015 12:17:55 +0100	[thread overview]
Message-ID: <20150311111755.GI952@pengutronix.de> (raw)
In-Reply-To: <20150311102208.GX8656@n2100.arm.linux.org.uk>

Hey Russell,

On Wed, Mar 11, 2015 at 10:22:09AM +0000, Russell King - ARM Linux wrote:
> On Sun, Mar 08, 2015 at 10:05:29PM +0100, Arnd Bergmann wrote:
> > ARM randconfig build tests found a new error for configurations
> > with COMMON_CLK disabled but HAS_CLK selected by the platform:
> > 
> > ERROR: "clk_is_match" [sound/soc/fsl/snd-soc-fsl-spdif.ko] undefined!
> > 
> > This moves the declaration around, so this case is covered
> > by the existing static inline helper function.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c69e182e51d89 ("clk: introduce clk_is_match")
> > ----
> > BTW, we have a preexisting problem in clk_get_parent,
> > clk_round_rate and clk_set_parent, which I've worked around in
> > my randconfig builds so far. Should we do that the same way?
> 
> NAK, as Uwe points out, you didn't address my comment.
You commented on the patch that is c69e182e51d8 ("clk: introduce
clk_is_match") now in next. Arnd just moved this around.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2015-03-11 11:17 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 14:53 [PATCH 0/8] Fix struct clk pointer comparing Shawn Guo
2015-02-25 14:53 ` Shawn Guo
2015-02-25 14:53 ` [PATCH 1/8] clk: add helper function clk_is_match() Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-25 17:27   ` Mike Turquette
2015-02-25 17:27     ` Mike Turquette
2015-02-26  0:37     ` Shawn Guo
2015-02-26  0:37       ` Shawn Guo
2015-02-26  9:02     ` Ben Dooks
2015-02-26  9:02       ` [alsa-devel] " Ben Dooks
2015-02-26  9:56       ` Philipp Zabel
2015-02-26  9:56         ` Philipp Zabel
2015-02-26 11:25         ` Ben Dooks
2015-02-26 11:25           ` Ben Dooks
2015-02-26 11:59           ` Ricard Wanderlof
2015-02-26 11:59             ` Ricard Wanderlof
2015-03-04  8:55     ` Geert Uytterhoeven
2015-03-04  8:55       ` Geert Uytterhoeven
2015-03-04  9:51     ` Russell King - ARM Linux
2015-03-04  9:51       ` Russell King - ARM Linux
2015-03-08 21:05     ` [PATCH] clk: provide clk_is_match() dummy for non-common clk Arnd Bergmann
2015-03-08 21:05       ` Arnd Bergmann
2015-03-10 21:42       ` Geert Uytterhoeven
2015-03-10 21:42         ` Geert Uytterhoeven
2015-03-11  7:09       ` Uwe Kleine-König
2015-03-11  7:09         ` Uwe Kleine-König
2015-03-11 10:22       ` Russell King - ARM Linux
2015-03-11 10:22         ` Russell King - ARM Linux
2015-03-11 11:17         ` Uwe Kleine-König [this message]
2015-03-11 11:17           ` Uwe Kleine-König
2015-03-11 12:29           ` Russell King - ARM Linux
2015-03-11 12:29             ` Russell King - ARM Linux
2015-03-12  0:35             ` Stephen Boyd
2015-03-12  0:35               ` Stephen Boyd
2015-02-25 14:53 ` [PATCH 2/8] ARM: imx: fix struct clk pointer comparing Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-25 14:53 ` [PATCH 3/8] drm: armada: " Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-25 14:53 ` [PATCH 4/8] pwm: atmel-hlcdc: " Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-26  9:22   ` Nicolas Ferre
2015-02-26  9:22     ` Nicolas Ferre
2015-02-26  9:31     ` Boris Brezillon
2015-02-26  9:31       ` Boris Brezillon
2015-03-11 10:54   ` Thierry Reding
2015-03-11 10:54     ` Thierry Reding
2015-02-25 14:53 ` [PATCH 5/8] serial: samsung: " Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-25 14:53 ` [PATCH 6/8] ASoC: fsl_esai: " Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-26  2:36   ` Mark Brown
2015-02-26  2:36     ` Mark Brown
2015-02-25 14:53 ` [PATCH 7/8] ASoC: fsl_spdif: " Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-25 21:04   ` Stephen Boyd
2015-02-25 21:04     ` Stephen Boyd
2015-02-26  1:17     ` Shawn Guo
2015-02-26  1:17       ` Shawn Guo
2015-02-26  2:12   ` Mark Brown
2015-02-26  2:12     ` Mark Brown
2015-02-26  2:20     ` Shawn Guo
2015-02-26  2:20       ` Shawn Guo
2015-02-26  2:29       ` Mark Brown
2015-02-26  2:29         ` Mark Brown
2015-02-26  2:36   ` Mark Brown
2015-02-26  2:36     ` Mark Brown
2015-02-25 14:53 ` [PATCH 8/8] ASoC: kirkwood: " Shawn Guo
2015-02-25 14:53   ` Shawn Guo
2015-02-26  2:12   ` Mark Brown
2015-02-26  2:12     ` Mark Brown
2015-02-26  2:36   ` Mark Brown
2015-02-26  2:36     ` Mark Brown
2015-02-25 15:03 ` [PATCH 0/8] Fix " Russell King - ARM Linux
2015-02-25 15:03   ` Russell King - ARM Linux
2015-02-25 17:55   ` Mike Turquette
2015-02-25 17:55     ` Mike Turquette
2015-02-25 20:42     ` Stephen Boyd
2015-02-25 20:42       ` Stephen Boyd
2015-02-26  1:21       ` Shawn Guo
2015-02-26  1:21         ` Shawn Guo
2015-02-26  1:24       ` Mike Turquette
2015-02-26  1:24         ` Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311111755.GI952@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@linaro.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.