From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ragavendra BN <ragavendra.bn@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: moved open brace next to declaration
Date: Thu, 12 Mar 2015 09:50:37 +0000 [thread overview]
Message-ID: <20150312095037.GY10964@mwanda> (raw)
In-Reply-To: <20150312093155.GA28806@localhost.localdomain>
On Thu, Mar 12, 2015 at 02:31:55AM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com [user]>
Don't include this. Fix your From header so it has your legal name.
Remover the [user] part.
>
> This patch fixes the coding style warning found by checkpath.pl for the
> open braces next to declaration.
No signed-off.
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index b71169e..2c12dd0 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -11,8 +11,7 @@ typedef struct _pllcalparam{
> pllcalparam;
>
>
> -logical_chip_type_t getChipType()
> -{
> +logical_chip_type_t getChipType(){
This is not correct. The braces were better in the original.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ragavendra BN <ragavendra.bn@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: moved open brace next to declaration
Date: Thu, 12 Mar 2015 12:50:37 +0300 [thread overview]
Message-ID: <20150312095037.GY10964@mwanda> (raw)
In-Reply-To: <20150312093155.GA28806@localhost.localdomain>
On Thu, Mar 12, 2015 at 02:31:55AM -0700, Ragavendra BN wrote:
> Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com [user]>
Don't include this. Fix your From header so it has your legal name.
Remover the [user] part.
>
> This patch fixes the coding style warning found by checkpath.pl for the
> open braces next to declaration.
No signed-off.
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index b71169e..2c12dd0 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -11,8 +11,7 @@ typedef struct _pllcalparam{
> pllcalparam;
>
>
> -logical_chip_type_t getChipType()
> -{
> +logical_chip_type_t getChipType(){
This is not correct. The braces were better in the original.
regards,
dan carpenter
next parent reply other threads:[~2015-03-12 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150312093155.GA28806@localhost.localdomain>
2015-03-12 9:50 ` Dan Carpenter [this message]
2015-03-12 9:50 ` [PATCH] staging: sm750fb: moved open brace next to declaration Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312095037.GY10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ragavendra.bn@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.