* Re: [PATCH] staging: sm750fb: moved open brace next to declaration [not found] <20150312093155.GA28806@localhost.localdomain> @ 2015-03-12 9:50 ` Dan Carpenter 0 siblings, 0 replies; 2+ messages in thread From: Dan Carpenter @ 2015-03-12 9:50 UTC (permalink / raw) To: Ragavendra BN Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel, linux-kernel On Thu, Mar 12, 2015 at 02:31:55AM -0700, Ragavendra BN wrote: > Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com [user]> Don't include this. Fix your From header so it has your legal name. Remover the [user] part. > > This patch fixes the coding style warning found by checkpath.pl for the > open braces next to declaration. No signed-off. > --- > drivers/staging/sm750fb/ddk750_chip.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index b71169e..2c12dd0 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -11,8 +11,7 @@ typedef struct _pllcalparam{ > pllcalparam; > > > -logical_chip_type_t getChipType() > -{ > +logical_chip_type_t getChipType(){ This is not correct. The braces were better in the original. regards, dan carpenter ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: moved open brace next to declaration @ 2015-03-12 9:50 ` Dan Carpenter 0 siblings, 0 replies; 2+ messages in thread From: Dan Carpenter @ 2015-03-12 9:50 UTC (permalink / raw) To: Ragavendra BN Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, devel, linux-kernel On Thu, Mar 12, 2015 at 02:31:55AM -0700, Ragavendra BN wrote: > Signed-off-by: Ragavendra BN <ragavendra.bn@gmail.com [user]> Don't include this. Fix your From header so it has your legal name. Remover the [user] part. > > This patch fixes the coding style warning found by checkpath.pl for the > open braces next to declaration. No signed-off. > --- > drivers/staging/sm750fb/ddk750_chip.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index b71169e..2c12dd0 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -11,8 +11,7 @@ typedef struct _pllcalparam{ > pllcalparam; > > > -logical_chip_type_t getChipType() > -{ > +logical_chip_type_t getChipType(){ This is not correct. The braces were better in the original. regards, dan carpenter ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-12 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150312093155.GA28806@localhost.localdomain>
2015-03-12 9:50 ` [PATCH] staging: sm750fb: moved open brace next to declaration Dan Carpenter
2015-03-12 9:50 ` Dan Carpenter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.