All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] clk: divider: three exactness fixes (and a rant)
Date: Fri, 13 Mar 2015 08:50:58 +0100	[thread overview]
Message-ID: <20150313075058.GL952@pengutronix.de> (raw)
In-Reply-To: <1426150673.14455.11.camel@pengutronix.de>

On Thu, Mar 12, 2015 at 09:57:53AM +0100, Philipp Zabel wrote:
> Am Mittwoch, den 11.03.2015, 18:21 -0700 schrieb Stephen Boyd:
> [...]
> > Why does Philipp like 110Hz the most? Where is the desire for that rate
> > coming from?
> > 
> > > And the lower
> > > abs(1 / 110 - 1 / r) the better. 
> > 
> > Similarly, where is this requirement coming from? Some datasheet? Or is
> > it just some arbitrary decision we've made that may not hold true for
> > all consumers?
It's not comming from a datasheet. But that's what I guess is the right
metric for quite some cases. E.g. an UART sample rate and I also
wouldn't be surprised if Philipp's panel example would call for this
metric, too.

For an UART running with say 38400 Bd you want to sample with a freqency
of 38400 Hz (not considering oversampling, but that is only a factor
that doesn't makes my reasoning wrong). If you now consider 38401 Hz and
38399 Hz the respective deltas are 1 Hz. But if you look at the time
between two samples we have:

	38401 Hz -> 26.04098852 us -> delta: 0.6781507 ns
	38400 Hz -> 26.04166667 us
	38399 Hz -> 26.04234485 us -> delta: 0.6781861 ns

So with 38401 it takes a little longer until the slightly deviating rate
results in sampling the wrong bit.

> In this use case, the driver doesn't want the pixel clock to stay below
> a hard frequency limit, but to get as close as possible to the target
> frequency, either above or below, so the relative error to the nominal
> panel refresh rate stays as small as possible. Thus for a fictional
> target rate of 110 Hz, I'd like to minimize abs((round_rate / 110) - 1).
Note that minimizing

	abs((round_rate / 110) - 1)

is equivalent to minimizing

	abs(round_rate - 110)

.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Stephen Boyd <sboyd@codeaurora.org>
Cc: "Mike Turquette" <mturquette@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	kernel@pengutronix.de
Subject: Re: [PATCH 0/3] clk: divider: three exactness fixes (and a rant)
Date: Fri, 13 Mar 2015 08:50:58 +0100	[thread overview]
Message-ID: <20150313075058.GL952@pengutronix.de> (raw)
In-Reply-To: <1426150673.14455.11.camel@pengutronix.de>

On Thu, Mar 12, 2015 at 09:57:53AM +0100, Philipp Zabel wrote:
> Am Mittwoch, den 11.03.2015, 18:21 -0700 schrieb Stephen Boyd:
> [...]
> > Why does Philipp like 110Hz the most? Where is the desire for that rate
> > coming from?
> > 
> > > And the lower
> > > abs(1 / 110 - 1 / r) the better. 
> > 
> > Similarly, where is this requirement coming from? Some datasheet? Or is
> > it just some arbitrary decision we've made that may not hold true for
> > all consumers?
It's not comming from a datasheet. But that's what I guess is the right
metric for quite some cases. E.g. an UART sample rate and I also
wouldn't be surprised if Philipp's panel example would call for this
metric, too.

For an UART running with say 38400 Bd you want to sample with a freqency
of 38400 Hz (not considering oversampling, but that is only a factor
that doesn't makes my reasoning wrong). If you now consider 38401 Hz and
38399 Hz the respective deltas are 1 Hz. But if you look at the time
between two samples we have:

	38401 Hz -> 26.04098852 us -> delta: 0.6781507 ns
	38400 Hz -> 26.04166667 us
	38399 Hz -> 26.04234485 us -> delta: 0.6781861 ns

So with 38401 it takes a little longer until the slightly deviating rate
results in sampling the wrong bit.

> In this use case, the driver doesn't want the pixel clock to stay below
> a hard frequency limit, but to get as close as possible to the target
> frequency, either above or below, so the relative error to the nominal
> panel refresh rate stays as small as possible. Thus for a fictional
> target rate of 110 Hz, I'd like to minimize abs((round_rate / 110) - 1).
Note that minimizing

	abs((round_rate / 110) - 1)

is equivalent to minimizing

	abs(round_rate - 110)

.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2015-03-13  7:50 UTC|newest]

Thread overview: 194+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  6:01 [PATCH RFC v9 00/20] Add support for i.MX MIPI DSI DRM driver Liu Ying
2015-02-12  6:01 ` Liu Ying
2015-02-12  6:01 ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 01/20] clk: divider: Correct parent clk round rate if no bestdiv is normally found Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  9:33   ` Sascha Hauer
2015-02-12  9:33     ` Sascha Hauer
2015-02-12  9:33     ` Sascha Hauer
2015-02-12 10:39     ` Liu Ying
2015-02-12 10:39       ` Liu Ying
2015-02-12 10:39       ` Liu Ying
2015-02-12 12:24       ` Sascha Hauer
2015-02-12 12:24         ` Sascha Hauer
2015-02-12 12:24         ` Sascha Hauer
2015-02-12 12:56         ` Russell King - ARM Linux
2015-02-12 12:56           ` Russell King - ARM Linux
2015-02-12 12:56           ` Russell King - ARM Linux
2015-02-12 13:41           ` Sascha Hauer
2015-02-12 13:41             ` Sascha Hauer
2015-02-12 13:41             ` Sascha Hauer
2015-02-12 14:06             ` Liu Ying
2015-02-12 14:06               ` Liu Ying
2015-02-12 14:06               ` Liu Ying
2015-02-13  2:58               ` Liu Ying
2015-02-13  2:58                 ` Liu Ying
2015-02-13  2:58                 ` Liu Ying
2015-02-13  2:58                 ` Travis
2015-02-13  2:58                   ` Travis
2015-02-13  2:58                   ` Travis
2015-02-13 14:35             ` Tomi Valkeinen
2015-02-13 14:35               ` Tomi Valkeinen
2015-02-13 14:35               ` Tomi Valkeinen
2015-02-13 18:57               ` Sascha Hauer
2015-02-13 18:57                 ` Sascha Hauer
2015-02-13 18:57                 ` Sascha Hauer
2015-02-16 11:18                 ` Tomi Valkeinen
2015-02-16 11:18                   ` Tomi Valkeinen
2015-02-16 11:18                   ` Tomi Valkeinen
2015-02-17 10:32                   ` Sascha Hauer
2015-02-17 10:32                     ` Sascha Hauer
2015-02-17 10:32                     ` Sascha Hauer
2015-02-16 11:27                 ` Russell King - ARM Linux
2015-02-16 11:27                   ` Russell King - ARM Linux
2015-02-16 11:27                   ` Russell King - ARM Linux
2015-02-20 19:13                   ` Mike Turquette
2015-02-20 19:13                     ` Mike Turquette
2015-02-20 19:20                     ` Russell King - ARM Linux
2015-02-20 19:20                       ` Russell King - ARM Linux
2015-02-20 19:20                       ` Russell King - ARM Linux
2015-02-20 19:42                       ` Mike Turquette
2015-02-20 19:42                         ` Mike Turquette
2015-02-21  8:56         ` Uwe Kleine-König
2015-02-21  8:56           ` Uwe Kleine-König
2015-02-21  8:56           ` Uwe Kleine-König
2015-02-21 10:40           ` [PATCH 0/3] clk: divider: three exactness fixes (and a rant) Uwe Kleine-König
2015-02-21 10:40             ` Uwe Kleine-König
2015-02-21 10:40             ` [PATCH 1/3] clk: divider: fix calculation of maximal parent rate for a given divider Uwe Kleine-König
2015-02-21 10:40               ` Uwe Kleine-König
2015-02-23  7:32               ` Sascha Hauer
2015-02-23  7:32                 ` Sascha Hauer
2015-03-05  8:35               ` Uwe Kleine-König
2015-03-05  8:35                 ` Uwe Kleine-König
2015-02-21 10:40             ` [PATCH 2/3] clk: divider: fix selection of divider when rounding to closest Uwe Kleine-König
2015-02-21 10:40               ` Uwe Kleine-König
2015-02-23  9:46               ` Maxime Coquelin
2015-02-23  9:46                 ` Maxime Coquelin
2015-02-21 10:40             ` [PATCH 3/3] clk: divider: fix calculation of initial best " Uwe Kleine-König
2015-02-21 10:40               ` Uwe Kleine-König
2015-02-23  9:42               ` Maxime Coquelin
2015-02-23  9:42                 ` Maxime Coquelin
2015-02-23  7:23             ` [PATCH 0/3] clk: divider: three exactness fixes (and a rant) Sascha Hauer
2015-02-23  7:23               ` Sascha Hauer
2015-03-06 18:57             ` Mike Turquette
2015-03-06 18:57               ` Mike Turquette
2015-03-06 19:28               ` Uwe Kleine-König
2015-03-06 19:28                 ` Uwe Kleine-König
2015-03-06 19:40                 ` Stephen Boyd
2015-03-06 19:40                   ` Stephen Boyd
2015-03-09  9:58                   ` Philipp Zabel
2015-03-09  9:58                     ` Philipp Zabel
2015-03-09 19:05                     ` Stephen Boyd
2015-03-09 19:05                       ` Stephen Boyd
2015-03-09 20:23                       ` Uwe Kleine-König
2015-03-09 20:23                         ` Uwe Kleine-König
2015-03-09 21:07                       ` Mike Turquette
2015-03-09 21:07                         ` Mike Turquette
2015-03-09 21:58                         ` Uwe Kleine-König
2015-03-09 21:58                           ` Uwe Kleine-König
2015-03-09 22:40                           ` Stephen Boyd
2015-03-09 22:40                             ` Stephen Boyd
2015-03-09 23:34                             ` Uwe Kleine-König
2015-03-09 23:34                               ` Uwe Kleine-König
2015-03-12  1:21                               ` Stephen Boyd
2015-03-12  1:21                                 ` Stephen Boyd
2015-03-12  8:57                                 ` Philipp Zabel
2015-03-12  8:57                                   ` Philipp Zabel
2015-03-13  7:50                                   ` Uwe Kleine-König [this message]
2015-03-13  7:50                                     ` Uwe Kleine-König
2015-03-13  8:13                                     ` Philipp Zabel
2015-03-13  8:13                                       ` Philipp Zabel
2015-03-06 19:44               ` Stephen Boyd
2015-03-06 19:44                 ` Stephen Boyd
2015-03-06 21:09                 ` Uwe Kleine-König
2015-03-06 21:09                   ` Uwe Kleine-König
2015-02-12  6:01 ` [PATCH RFC v9 02/20] ARM: imx6q: Add GPR3 MIPI muxing control register field shift bits definition Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 03/20] ARM: imx6q: clk: Add the video_27m clock Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 04/20] ARM: imx6q: clk: Change hdmi_isfr clock's parent to be " Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 05/20] ARM: imx6q: clk: Change hsi_tx clock to be a shared clock gate Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 06/20] ARM: imx6q: clk: Add support for mipi_core_cfg clock as " Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 07/20] ARM: imx6q: clk: Add support for mipi_ipg " Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 08/20] ARM: dts: imx6qdl: Move existing MIPI DSI ports into a new 'ports' node Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  9:26   ` Daniel Vetter
2015-02-12  9:26     ` Daniel Vetter
2015-02-12  9:26     ` Daniel Vetter
2015-02-13  5:01     ` Liu Ying
2015-02-13  5:01       ` Liu Ying
2015-02-13  5:01       ` Liu Ying
2015-03-03 11:07   ` Philipp Zabel
2015-03-03 11:07     ` Philipp Zabel
2015-03-03 11:07     ` Philipp Zabel
2015-04-03  3:28     ` Liu Ying
2015-04-03  3:28       ` Liu Ying
2015-04-09  7:10   ` Thierry Reding
2015-04-09  7:10     ` Thierry Reding
2015-04-09  7:10     ` Thierry Reding
2015-02-12  6:01 ` [PATCH RFC v9 10/20] Documentation: dt-bindings: Add bindings for Synopsys DW MIPI DSI DRM bridge driver Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 11/20] drm/bridge: Add Synopsys DesignWare MIPI DSI host controller driver Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-04-09  8:43   ` Thierry Reding
2015-04-09  8:43     ` Thierry Reding
2015-04-09  8:43     ` Thierry Reding
2015-04-16  5:39     ` Archit Taneja
2015-04-16  5:39       ` Archit Taneja
2015-04-16  5:39       ` Archit Taneja
2015-04-22 12:13       ` Heiko Stübner
2015-04-22 12:13         ` Heiko Stübner
2015-04-22 12:13         ` Heiko Stübner
2015-02-12  6:01 ` [PATCH RFC v9 12/20] Documentation: dt-bindings: Add bindings for i.MX specific Synopsys DW MIPI DSI driver Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 13/20] drm: imx: Support Synopsys DesignWare MIPI DSI host controller Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 14/20] Documentation: dt-bindings: Add bindings for Himax HX8369A DRM panel driver Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-04-09  7:20   ` Thierry Reding
2015-04-09  7:20     ` Thierry Reding
2015-04-09  7:20     ` Thierry Reding
2015-02-12  6:01 ` [PATCH RFC v9 15/20] drm: panel: Add support for Himax HX8369A MIPI DSI panel Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-04-09  8:09   ` Thierry Reding
2015-04-09  8:09     ` Thierry Reding
2015-04-09  8:09     ` Thierry Reding
2015-02-12  6:01 ` [PATCH RFC v9 16/20] ARM: dtsi: imx6qdl: Add support for MIPI DSI host controller Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 17/20] ARM: dts: imx6qdl-sabresd: Add support for TRULY TFT480800-16-E MIPI DSI panel Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 18/20] ARM: imx_v6_v7_defconfig: Cleanup for imx drm being moved out of staging Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 19/20] ARM: imx_v6_v7_defconfig: Add support for MIPI DSI host controller Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01 ` [PATCH RFC v9 20/20] ARM: imx_v6_v7_defconfig: Add support for Himax HX8369A panel Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-02-12  6:01   ` Liu Ying
2015-03-02 13:24 ` [PATCH RFC v9 00/20] Add support for i.MX MIPI DSI DRM driver Shawn Guo
2015-03-02 13:24   ` Shawn Guo
2015-03-02 13:24   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313075058.GL952@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.