From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Isaac Lleida <illeida@openaliasbox.org>
Cc: willy@meta-x.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] staging: panel: change struct bits to a bit array
Date: Sat, 14 Mar 2015 08:44:31 +0000 [thread overview]
Message-ID: <20150314083231.GA4120@sudip-PC> (raw)
In-Reply-To: <1426288836-25749-1-git-send-email-illeida@openaliasbox.org>
On Sat, Mar 14, 2015 at 12:20:36AM +0100, Isaac Lleida wrote:
> This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage.
commit log should wrap at 72 char
>
> Signed-off-by: Isaac Lleida <illeida@openaliasbox.org
missing '>'
> ---
> v2: fix some stupid errors from the first patch
>
<snip>
> +#define BIT_ON(b, m) (b |= m)
> +#define BIT_OFF(b, m) (b &= ~m)
> +#define BIT_CHK(b, m) (b & m)
> +#define BIT_MOD(b, m, v) \
> + (((v) ? BIT_ON(b, m) : BIT_OFF(b, m))?1:0) \
missing ' ' around ? and :
please test your patch by checkpatch.pl before sending
regards
sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Isaac Lleida <illeida@openaliasbox.org>
Cc: willy@meta-x.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] staging: panel: change struct bits to a bit array
Date: Sat, 14 Mar 2015 14:02:31 +0530 [thread overview]
Message-ID: <20150314083231.GA4120@sudip-PC> (raw)
In-Reply-To: <1426288836-25749-1-git-send-email-illeida@openaliasbox.org>
On Sat, Mar 14, 2015 at 12:20:36AM +0100, Isaac Lleida wrote:
> This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage.
commit log should wrap at 72 char
>
> Signed-off-by: Isaac Lleida <illeida@openaliasbox.org
missing '>'
> ---
> v2: fix some stupid errors from the first patch
>
<snip>
> +#define BIT_ON(b, m) (b |= m)
> +#define BIT_OFF(b, m) (b &= ~m)
> +#define BIT_CHK(b, m) (b & m)
> +#define BIT_MOD(b, m, v) \
> + (((v) ? BIT_ON(b, m) : BIT_OFF(b, m))?1:0) \
missing ' ' around ? and :
please test your patch by checkpatch.pl before sending
regards
sudip
next prev parent reply other threads:[~2015-03-14 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 23:20 [PATCH v2] staging: panel: change struct bits to a bit array Isaac Lleida
2015-03-13 23:20 ` Isaac Lleida
2015-03-14 5:22 ` Christophe JAILLET
2015-03-14 5:27 ` Christophe JAILLET
2015-03-14 8:32 ` Sudip Mukherjee [this message]
2015-03-14 8:44 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150314083231.GA4120@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=illeida@openaliasbox.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.