From: Andy Gross <agross@codeaurora.org>
To: sricharan@codeaurora.org
Cc: Vinod Koul <vinod.koul@intel.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Kumar Gala <galak@codeaurora.org>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [Patch v4 2/2] dmaengine: Add ADM driver
Date: Tue, 17 Mar 2015 00:04:15 -0500 [thread overview]
Message-ID: <20150317050415.GB28722@qualcomm.com> (raw)
In-Reply-To: <11135b79b94477532e57f30b1ea3c715.squirrel@www.codeaurora.org>
On Mon, Mar 16, 2015 at 08:15:26AM -0000, sricharan@codeaurora.org wrote:
> Hi,
>
> <snip>
> >
> >>
> >> > +static int adm_get_blksize(unsigned int burst)
> >> > +{
> >> > + int ret;
> >> > +
> >> > + switch (burst) {
> >> > + case 16:
> >> > + ret = 0;
> >> > + break;
> >> > + case 32:
> >> > + ret = 1;
> >> > + break;
> >> > + case 64:
> >> > + ret = 2;
> >> > + break;
> >> > + case 128:
> >> > + ret = 3;
> >> > + break;
> >> > + case 192:
> >> > + ret = 4;
> >> > + break;
> >> > + case 256:
> >> > + ret = 5;
> >> > + break;
> >> ffs(burst>>4) ?
> >
> > that should work nicely. thanks.
> >
> Will not work for 192, 256 ?
you are right. I'll have to separate those out into 2 more cases. Good catch!
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: agross@codeaurora.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v4 2/2] dmaengine: Add ADM driver
Date: Tue, 17 Mar 2015 00:04:15 -0500 [thread overview]
Message-ID: <20150317050415.GB28722@qualcomm.com> (raw)
In-Reply-To: <11135b79b94477532e57f30b1ea3c715.squirrel@www.codeaurora.org>
On Mon, Mar 16, 2015 at 08:15:26AM -0000, sricharan at codeaurora.org wrote:
> Hi,
>
> <snip>
> >
> >>
> >> > +static int adm_get_blksize(unsigned int burst)
> >> > +{
> >> > + int ret;
> >> > +
> >> > + switch (burst) {
> >> > + case 16:
> >> > + ret = 0;
> >> > + break;
> >> > + case 32:
> >> > + ret = 1;
> >> > + break;
> >> > + case 64:
> >> > + ret = 2;
> >> > + break;
> >> > + case 128:
> >> > + ret = 3;
> >> > + break;
> >> > + case 192:
> >> > + ret = 4;
> >> > + break;
> >> > + case 256:
> >> > + ret = 5;
> >> > + break;
> >> ffs(burst>>4) ?
> >
> > that should work nicely. thanks.
> >
> Will not work for 192, 256 ?
you are right. I'll have to separate those out into 2 more cases. Good catch!
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-03-17 5:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 5:46 [Patch v4 0/2] Add Qualcomm ADM dmaengine driver Andy Gross
2015-02-12 5:46 ` Andy Gross
2015-02-12 5:46 ` [Patch v4 1/2] dt/bindings: qcom_adm: Fix channel specifiers Andy Gross
2015-02-12 5:46 ` Andy Gross
2015-02-12 5:46 ` [Patch v4 2/2] dmaengine: Add ADM driver Andy Gross
2015-02-12 5:46 ` Andy Gross
2015-03-13 8:57 ` Vinod Koul
2015-03-13 8:57 ` Vinod Koul
2015-03-13 22:06 ` Andy Gross
2015-03-13 22:06 ` Andy Gross
2015-03-16 8:15 ` sricharan
2015-03-16 8:15 ` sricharan at codeaurora.org
2015-03-17 5:04 ` Andy Gross [this message]
2015-03-17 5:04 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317050415.GB28722@qualcomm.com \
--to=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sricharan@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.