From: Pavel Machek <pavel@ucw.cz>
To: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Belisko Marek <marek.belisko@gmail.com>,
mark.rutland@arm.com, Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Tony Lindgren <tony@atomide.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux PM mailing list <linux-pm@vger.kernel.org>,
GTA04 owners <gta04-owner@goldelico.com>
Subject: Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings
Date: Tue, 17 Mar 2015 14:59:13 +0100 [thread overview]
Message-ID: <20150317135913.GA4034@amd> (raw)
In-Reply-To: <CDA0FF88-2D00-46E0-828E-DD6F4FF4ADAF@goldelico.com>
Hi!
> >>>>> to introduce coefficients for temperature and discharge rate?
> >>>> What do you mean? Nothing like that is used in current driver why do
> >>>> we need to add it?
> >>>
> >>> Well, conversion between Li-ion's voltage and state of charge at 0
> >>> current is well known:
> >>
> >> We can’t measure at 0 current since the OMAP is driven from battery
> >> and charger and may also draw some mA…
> >
> > Yes, but you know how many mA you are taking just now. So if you knew
> > the internal resistance, you could compute the voltage at 0
> > current. (And it should also work during charging, as long as you know
> > how much current is going in.)
>
> As far as I understand the twl4030 charger and MADC it is not possible to
> separate these values. It is only reporting the inflow from charger to
> battery + system. So you don’t know how many mA are supplying the system
> and how many mA are left over for charging.
>
> You can only assume how much the system is drawing while running (something
> between 50 and 600 mA but this depends on system activities, power state
> of peripherald and e.g. backlight being switched on).
>
> I think your basic assumption that we know any time how many mA the system
> is taking is not given.
So.. you won't be able to get exact value while charging, but you
get one while discharging, which is what really matters...?
> > Yes, and that coefficient should be internal battery resistance ;-).
>
> But where do you know this value from to write it into a DT file?
> Usually you can’t measure it easily and for some batteries you don’t have
> a data sheet.
>
> Contrary, the calibration curves can easily be measured on the device
> (assuming that the charge level decreases/increases linearly over time
> between Full and Empty).
If you can copy it from the data sheet, that's the easiest option. If
not, you should be able to easily compute it from the charge/discharge
curves or from measured voltage at different loads.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings
Date: Tue, 17 Mar 2015 14:59:13 +0100 [thread overview]
Message-ID: <20150317135913.GA4034@amd> (raw)
In-Reply-To: <CDA0FF88-2D00-46E0-828E-DD6F4FF4ADAF@goldelico.com>
Hi!
> >>>>> to introduce coefficients for temperature and discharge rate?
> >>>> What do you mean? Nothing like that is used in current driver why do
> >>>> we need to add it?
> >>>
> >>> Well, conversion between Li-ion's voltage and state of charge at 0
> >>> current is well known:
> >>
> >> We can?t measure at 0 current since the OMAP is driven from battery
> >> and charger and may also draw some mA?
> >
> > Yes, but you know how many mA you are taking just now. So if you knew
> > the internal resistance, you could compute the voltage at 0
> > current. (And it should also work during charging, as long as you know
> > how much current is going in.)
>
> As far as I understand the twl4030 charger and MADC it is not possible to
> separate these values. It is only reporting the inflow from charger to
> battery + system. So you don?t know how many mA are supplying the system
> and how many mA are left over for charging.
>
> You can only assume how much the system is drawing while running (something
> between 50 and 600 mA but this depends on system activities, power state
> of peripherald and e.g. backlight being switched on).
>
> I think your basic assumption that we know any time how many mA the system
> is taking is not given.
So.. you won't be able to get exact value while charging, but you
get one while discharging, which is what really matters...?
> > Yes, and that coefficient should be internal battery resistance ;-).
>
> But where do you know this value from to write it into a DT file?
> Usually you can?t measure it easily and for some batteries you don?t have
> a data sheet.
>
> Contrary, the calibration curves can easily be measured on the device
> (assuming that the charge level decreases/increases linearly over time
> between Full and Empty).
If you can copy it from the data sheet, that's the easiest option. If
not, you should be able to easily compute it from the charge/discharge
curves or from measured voltage at different loads.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-03-17 13:59 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 22:14 [PATCH v3 0/6] Convert twl4030_madc_battery to IIO consumer and add DT aupport Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` [PATCH v3 1/6] power: twl4030-madc-battery: Convert to iio consumer Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` [PATCH v3 2/6] power: twl4030_madc_battery: Add device tree support Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-03-05 0:48 ` Sebastian Reichel
2015-03-05 0:48 ` Sebastian Reichel
[not found] ` <1423088075-10025-4-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-03-16 21:05 ` Pavel Machek
2015-03-16 21:05 ` Pavel Machek
2015-03-16 21:05 ` Pavel Machek
2015-03-16 21:20 ` Belisko Marek
2015-03-16 21:20 ` Belisko Marek
2015-03-16 21:37 ` Dr. H. Nikolaus Schaller
2015-03-16 21:37 ` Dr. H. Nikolaus Schaller
2015-03-17 8:48 ` Pavel Machek
2015-03-17 8:48 ` Pavel Machek
2015-03-17 8:59 ` Dr. H. Nikolaus Schaller
2015-03-17 8:59 ` Dr. H. Nikolaus Schaller
2015-03-17 8:47 ` Pavel Machek
2015-03-17 8:47 ` Pavel Machek
2015-03-17 8:47 ` Pavel Machek
2015-03-17 8:56 ` Dr. H. Nikolaus Schaller
2015-03-17 8:56 ` Dr. H. Nikolaus Schaller
2015-03-17 8:56 ` Dr. H. Nikolaus Schaller
[not found] ` <940EE988-03A4-4B1B-A168-959E367953A6-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-03-17 10:37 ` Pavel Machek
2015-03-17 10:37 ` Pavel Machek
2015-03-17 10:37 ` Pavel Machek
2015-03-17 11:14 ` Dr. H. Nikolaus Schaller
2015-03-17 11:14 ` Dr. H. Nikolaus Schaller
2015-03-17 13:59 ` Pavel Machek [this message]
2015-03-17 13:59 ` Pavel Machek
2015-03-17 14:12 ` Dr. H. Nikolaus Schaller
2015-03-17 14:12 ` Dr. H. Nikolaus Schaller
2015-03-17 14:12 ` Dr. H. Nikolaus Schaller
2015-03-17 9:07 ` Dr. H. Nikolaus Schaller
2015-03-17 9:07 ` Dr. H. Nikolaus Schaller
2015-03-17 10:01 ` Pavel Machek
2015-03-17 10:01 ` Pavel Machek
[not found] ` <1423088075-10025-1-git-send-email-marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2015-02-04 22:14 ` [PATCH v3 4/6] ARM: dts: omap3-gta04: Add battery support Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-03-05 0:37 ` Sebastian Reichel
2015-03-05 0:37 ` Sebastian Reichel
2015-03-16 20:35 ` Tony Lindgren
2015-03-16 20:35 ` Tony Lindgren
2015-03-16 20:47 ` Belisko Marek
2015-03-16 20:47 ` Belisko Marek
2015-03-16 20:50 ` Tony Lindgren
2015-03-16 20:50 ` Tony Lindgren
2015-02-04 22:14 ` [PATCH v3 5/6] power: twl4030_madc_battery: Add of_twl4030_madc_match to MODULE_DEVICE_TABLE Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-04 22:14 ` [PATCH v3 6/6] power: twl4030_madc_battery: Add missing MODULE_ALIAS Marek Belisko
2015-02-04 22:14 ` Marek Belisko
2015-02-18 7:46 ` [PATCH v3 0/6] Convert twl4030_madc_battery to IIO consumer and add DT aupport Belisko Marek
2015-02-18 7:46 ` Belisko Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317135913.GA4034@amd \
--to=pavel@ucw.cz \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=gta04-owner@goldelico.com \
--cc=hns@goldelico.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.