From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset
Date: Wed, 18 Mar 2015 10:17:17 +0000 [thread overview]
Message-ID: <20150318101717.GN10964@mwanda> (raw)
In-Reply-To: <1426669046-29935-1-git-send-email-lstoakes@gmail.com>
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +0000, Lorenzo Stoakes wrote:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:490:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:501:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:502:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:833:5: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces)
>
This changelog still sucks. It doesn't describe the effect of this
behavior change for the user. It doesn't even make it clear that you
are aware that this is a behavior change.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset
Date: Wed, 18 Mar 2015 13:17:17 +0300 [thread overview]
Message-ID: <20150318101717.GN10964@mwanda> (raw)
In-Reply-To: <1426669046-29935-1-git-send-email-lstoakes@gmail.com>
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +0000, Lorenzo Stoakes wrote:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:490:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:501:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:502:17: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:833:5: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces)
>
This changelog still sucks. It doesn't describe the effect of this
behavior change for the user. It doesn't even make it clear that you
are aware that this is a behavior change.
regards,
dan carpenter
next prev parent reply other threads:[~2015-03-18 10:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 8:57 [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 2/5] staging: sm750fb: Make internal functions static Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 3/5] staging: sm750fb: Remove unused function Lorenzo Stoakes
2015-03-18 8:57 ` Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 4/5] staging: sm750fb: Fix __iomem pointer types Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 5/5] staging: sm750fb: Remove spinlock helper function Lorenzo Stoakes
2015-03-18 8:57 ` Lorenzo Stoakes
2015-03-18 10:17 ` Dan Carpenter [this message]
2015-03-18 10:17 ` [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Dan Carpenter
2015-03-18 10:18 ` Dan Carpenter
2015-03-18 10:18 ` Dan Carpenter
2015-03-18 10:44 ` Lorenzo Stoakes
2015-03-18 10:52 ` Dan Carpenter
2015-03-18 10:52 ` Dan Carpenter
2015-03-18 10:55 ` Lorenzo Stoakes
2015-03-18 10:46 ` Lorenzo Stoakes
2015-03-18 10:59 ` Dan Carpenter
2015-03-18 10:59 ` Dan Carpenter
2015-03-18 11:14 ` Lorenzo Stoakes
2015-03-18 19:09 ` Lorenzo Stoakes
2015-03-18 10:50 ` Vitaly Kuznetsov
2015-03-18 10:50 ` Vitaly Kuznetsov
2015-03-18 11:12 ` Lorenzo Stoakes
2015-03-18 11:25 ` Dan Carpenter
2015-03-18 11:25 ` Dan Carpenter
2015-03-18 13:06 ` Sudip Mukherjee
2015-03-18 13:18 ` Sudip Mukherjee
2015-03-18 13:23 ` Dan Carpenter
2015-03-18 13:23 ` Dan Carpenter
2015-03-18 13:29 ` Sudip Mukherjee
2015-03-18 13:41 ` Sudip Mukherjee
2015-03-18 19:10 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318101717.GN10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.