From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
Lorenzo Stoakes <lstoakes@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset
Date: Wed, 18 Mar 2015 13:41:41 +0000 [thread overview]
Message-ID: <20150318132941.GA1922@sudip-PC> (raw)
In-Reply-To: <20150318132339.GR10964@mwanda>
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote:
> > https://lkml.org/lkml/2015/3/10/685
> >
>
> You were making random white space changes and not on the same line. It
> was hard to review because you had to count how many u32 arguments there
> were (a million) and really look at it to see what the compile warning
> was. There was no compile warning in the end. Very annoying.
ok, now understood. Thanks.
like you said once - combining different changes in a single patch is
an art. :)
regards
sudip
>
> regards,
> dan carpenter
>
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
Lorenzo Stoakes <lstoakes@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>
Subject: Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset
Date: Wed, 18 Mar 2015 18:59:41 +0530 [thread overview]
Message-ID: <20150318132941.GA1922@sudip-PC> (raw)
In-Reply-To: <20150318132339.GR10964@mwanda>
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote:
> > https://lkml.org/lkml/2015/3/10/685
> >
>
> You were making random white space changes and not on the same line. It
> was hard to review because you had to count how many u32 arguments there
> were (a million) and really look at it to see what the compile warning
> was. There was no compile warning in the end. Very annoying.
ok, now understood. Thanks.
like you said once - combining different changes in a single patch is
an art. :)
regards
sudip
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2015-03-18 13:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 8:57 [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 2/5] staging: sm750fb: Make internal functions static Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 3/5] staging: sm750fb: Remove unused function Lorenzo Stoakes
2015-03-18 8:57 ` Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 4/5] staging: sm750fb: Fix __iomem pointer types Lorenzo Stoakes
2015-03-18 8:57 ` [PATCH RESEND 5/5] staging: sm750fb: Remove spinlock helper function Lorenzo Stoakes
2015-03-18 8:57 ` Lorenzo Stoakes
2015-03-18 10:17 ` [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset Dan Carpenter
2015-03-18 10:17 ` Dan Carpenter
2015-03-18 10:18 ` Dan Carpenter
2015-03-18 10:18 ` Dan Carpenter
2015-03-18 10:44 ` Lorenzo Stoakes
2015-03-18 10:52 ` Dan Carpenter
2015-03-18 10:52 ` Dan Carpenter
2015-03-18 10:55 ` Lorenzo Stoakes
2015-03-18 10:46 ` Lorenzo Stoakes
2015-03-18 10:59 ` Dan Carpenter
2015-03-18 10:59 ` Dan Carpenter
2015-03-18 11:14 ` Lorenzo Stoakes
2015-03-18 19:09 ` Lorenzo Stoakes
2015-03-18 10:50 ` Vitaly Kuznetsov
2015-03-18 10:50 ` Vitaly Kuznetsov
2015-03-18 11:12 ` Lorenzo Stoakes
2015-03-18 11:25 ` Dan Carpenter
2015-03-18 11:25 ` Dan Carpenter
2015-03-18 13:06 ` Sudip Mukherjee
2015-03-18 13:18 ` Sudip Mukherjee
2015-03-18 13:23 ` Dan Carpenter
2015-03-18 13:23 ` Dan Carpenter
2015-03-18 13:29 ` Sudip Mukherjee [this message]
2015-03-18 13:41 ` Sudip Mukherjee
2015-03-18 19:10 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318132941.GA1922@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.