All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types
Date: Fri, 20 Mar 2015 13:03:29 +0000	[thread overview]
Message-ID: <20150320130329.GA23287@kroah.com> (raw)
In-Reply-To: <1426705493-26615-2-git-send-email-lstoakes@gmail.com>

On Wed, Mar 18, 2015 at 07:04:53PM +0000, Lorenzo Stoakes wrote:
> This patch annotates pointers as referring to I/O mapped memory where they ought
> to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O
> mapped memory by using iowrite16 instead, and updates the pointer arithmetic
> accordingly to take into account that the pointers are now byte-sized. This
> fixes the following sparse warnings:-
> 
> drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression
> drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> ---
> v2: Whitespace fixups
> 
>  drivers/staging/sm750fb/sm750_cursor.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

I only see 2 patches in this "series", yet you refer to 5?  Please
resend the whole series, I dropped your previous ones from my queue.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types
Date: Fri, 20 Mar 2015 14:03:29 +0100	[thread overview]
Message-ID: <20150320130329.GA23287@kroah.com> (raw)
In-Reply-To: <1426705493-26615-2-git-send-email-lstoakes@gmail.com>

On Wed, Mar 18, 2015 at 07:04:53PM +0000, Lorenzo Stoakes wrote:
> This patch annotates pointers as referring to I/O mapped memory where they ought
> to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O
> mapped memory by using iowrite16 instead, and updates the pointer arithmetic
> accordingly to take into account that the pointers are now byte-sized. This
> fixes the following sparse warnings:-
> 
> drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression
> drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> ---
> v2: Whitespace fixups
> 
>  drivers/staging/sm750fb/sm750_cursor.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

I only see 2 patches in this "series", yet you refer to 5?  Please
resend the whole series, I dropped your previous ones from my queue.

thanks,

greg k-h

  reply	other threads:[~2015-03-20 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 19:04 [PATCH RESEND v2 1/5] staging: sm750fb: Use memset_io instead of memset Lorenzo Stoakes
2015-03-18 19:04 ` [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types Lorenzo Stoakes
2015-03-20 13:03   ` Greg KH [this message]
2015-03-20 13:03     ` Greg KH
2015-03-20 15:24     ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320130329.GA23287@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lstoakes@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.